refactor: address code review findings across all projects

Apply comprehensive fixes from code reviews including:
- Extract shared utilities (SqlFormatHelper, CellValueConverter, DbDestinationBase)
- Add interface abstractions (IAuthenticationService, IDatabaseMigrator, IMisQueryBuilder)
- Implement SecureStore for encrypted secrets storage
- Fix error handling with proper HTTP status codes and logging
- Optimize double enumeration in DevEtlRegistry
- Add DataSync.Dev README for developer onboarding
- Extract filter panel base classes to reduce duplication
- Update code review docs to mark all issues as fixed
This commit is contained in:
Joseph Doherty
2026-01-19 11:05:36 -05:00
parent 08f5aa1447
commit 604bfe919c
148 changed files with 8696 additions and 1538 deletions
@@ -0,0 +1,76 @@
using System.Windows.Input;
namespace JdeScoping.SecureStoreManager.ViewModels;
/// <summary>
/// A command implementation that delegates to action methods.
/// </summary>
public class RelayCommand : ICommand
{
private readonly Action<object?> _execute;
private readonly Predicate<object?>? _canExecute;
private EventHandler? _canExecuteChanged;
public event EventHandler? CanExecuteChanged
{
add => _canExecuteChanged += value;
remove => _canExecuteChanged -= value;
}
/// <summary>
/// Creates a new RelayCommand that can always execute.
/// </summary>
/// <param name="execute">The action to execute.</param>
public RelayCommand(Action<object?> execute)
: this(execute, null)
{
}
/// <summary>
/// Creates a new RelayCommand with a CanExecute predicate.
/// </summary>
/// <param name="execute">The action to execute.</param>
/// <param name="canExecute">The predicate to determine if the command can execute.</param>
public RelayCommand(Action<object?> execute, Predicate<object?>? canExecute)
{
_execute = execute ?? throw new ArgumentNullException(nameof(execute));
_canExecute = canExecute;
}
/// <summary>
/// Creates a new RelayCommand from a parameterless action.
/// </summary>
/// <param name="execute">The action to execute.</param>
public RelayCommand(Action execute)
: this(_ => execute(), null)
{
}
/// <summary>
/// Creates a new RelayCommand from a parameterless action with a CanExecute predicate.
/// </summary>
/// <param name="execute">The action to execute.</param>
/// <param name="canExecute">The predicate to determine if the command can execute.</param>
public RelayCommand(Action execute, Func<bool>? canExecute)
: this(_ => execute(), canExecute != null ? _ => canExecute() : null)
{
}
public bool CanExecute(object? parameter)
{
return _canExecute == null || _canExecute(parameter);
}
public void Execute(object? parameter)
{
_execute(parameter);
}
/// <summary>
/// Raises the CanExecuteChanged event.
/// </summary>
public void RaiseCanExecuteChanged()
{
_canExecuteChanged?.Invoke(this, EventArgs.Empty);
}
}