refactor: address code review findings across all projects

Apply comprehensive fixes from code reviews including:
- Extract shared utilities (SqlFormatHelper, CellValueConverter, DbDestinationBase)
- Add interface abstractions (IAuthenticationService, IDatabaseMigrator, IMisQueryBuilder)
- Implement SecureStore for encrypted secrets storage
- Fix error handling with proper HTTP status codes and logging
- Optimize double enumeration in DevEtlRegistry
- Add DataSync.Dev README for developer onboarding
- Extract filter panel base classes to reduce duplication
- Update code review docs to mark all issues as fixed
This commit is contained in:
Joseph Doherty
2026-01-19 11:05:36 -05:00
parent 08f5aa1447
commit 604bfe919c
148 changed files with 8696 additions and 1538 deletions
@@ -9,7 +9,6 @@ using JdeScoping.DataAccess.QueryBuilders;
using Microsoft.Data.SqlClient;
using Microsoft.Extensions.Logging;
using Microsoft.Extensions.Options;
using SqlKata.Compilers;
namespace JdeScoping.DataAccess.Services;
@@ -21,7 +20,7 @@ public sealed class SearchProcessor : ISearchProcessor
private readonly IDbConnectionFactory _connectionFactory;
private readonly ISearchQueryBuilder _queryBuilder;
private readonly IWorkOrderTraversalService _traversalService;
private readonly MisQueryBuilder _misQueryBuilder;
private readonly IMisQueryBuilder _misQueryBuilder;
private readonly SearchProcessingConfiguration _options;
private readonly ILogger<SearchProcessor> _logger;
@@ -32,14 +31,14 @@ public sealed class SearchProcessor : ISearchProcessor
IDbConnectionFactory connectionFactory,
ISearchQueryBuilder queryBuilder,
IWorkOrderTraversalService traversalService,
SqlServerCompiler compiler,
IMisQueryBuilder misQueryBuilder,
IOptions<SearchProcessingConfiguration> options,
ILogger<SearchProcessor> logger)
{
_connectionFactory = connectionFactory;
_queryBuilder = queryBuilder;
_traversalService = traversalService;
_misQueryBuilder = new MisQueryBuilder(compiler);
_misQueryBuilder = misQueryBuilder;
_options = options.Value;
_logger = logger;
}