refactor: address code review findings across all projects

Apply comprehensive fixes from code reviews including:
- Extract shared utilities (SqlFormatHelper, CellValueConverter, DbDestinationBase)
- Add interface abstractions (IAuthenticationService, IDatabaseMigrator, IMisQueryBuilder)
- Implement SecureStore for encrypted secrets storage
- Fix error handling with proper HTTP status codes and logging
- Optimize double enumeration in DevEtlRegistry
- Add DataSync.Dev README for developer onboarding
- Extract filter panel base classes to reduce duplication
- Update code review docs to mark all issues as fixed

CodeReviews/Database/review.md

@@ -0,0 +1,174 @@
+# Code Review: JdeScoping.Database
+
+**Project Path:** `NEW/src/JdeScoping.Database`
+**Layer:** Infrastructure
+**Purpose:** SQL Server schema, migrations
+
+---
+
+## Executive Summary
+
+The JdeScoping.Database project is a well-structured database migration and schema management project using DbUp for SQL Server. The project demonstrates solid foundational practices with room for improvement in testability and abstraction.
+
+**Overall Assessment: Good with targeted improvements recommended**
+
+| Category | Rating | Notes |
+|----------|--------|-------|
+| SOLID Principles | Fair | Missing interface abstraction for migrator |
+| Clean Architecture | Good | Clear infrastructure layer responsibilities |
+| Code Organization | Good | Logical folder structure with numbered scripts |
+| Error Handling | Good | Consistent patterns in SQL; C# could improve |
+| Testability | Fair | Concrete class instantiation limits mocking |
+| Code Duplication | Fair | Significant duplication in SQL scripts |
+| Async Patterns | N/A | Synchronous by design (DbUp limitation) |
+| Null Safety | Good | Nullable enabled with proper checks |
+| Documentation | Good | SQL comments present; C# XML docs sparse |
+
+---
+
+## 1. SOLID Principles
+
+### Single Responsibility Principle (SRP)
+
+**Good:** `DatabaseMigrator` class has a single, clear responsibility.
+
+### Dependency Inversion Principle (DIP)
+
+**Issue:** `DatabaseMigrator` is a concrete class without an interface abstraction.
+
+**Recommendation:** Extract an interface:
+```csharp
+public interface IDatabaseMigrator
+{
+    DatabaseUpgradeResult Migrate();
+}
+```
+
+---
+
+## 2. Clean Architecture
+
+**Good:** The project correctly sits in the Infrastructure layer with minimal dependencies.
+
+---
+
+## 3. Code Organization
+
+### Folder Structure
+
+**Good:**
+```
+JdeScoping.Database/
+    DatabaseMigrator.cs
+    Scripts/
+        001_CreateSearchTable.sql
+        002_CreateDataUpdateTable.sql
+        ... (48 numbered scripts)
+```
+
+### Naming Conventions
+
+**Good:** Clear, descriptive names following pattern `NNN_VerbObjectDescription.sql`.
+
+SQL object prefixes:
+- Stored Procedures: `usp_` prefix
+- Functions: `fn_` prefix
+
+---
+
+## 4. Error Handling
+
+### SQL Error Handling
+
+**Good:** Stored procedures use custom error codes with `THROW`:
+
+```sql
+IF @@ROWCOUNT = 0
+BEGIN
+    SET @ErrorMsg = CONCAT('Search ID ', @SearchId, ' not found');
+    THROW 50001, @ErrorMsg, 1;
+END
+```
+
+### C# Error Handling
+
+**Recommendation:** Add exception wrapping to provide better context on migration failures.
+
+---
+
+## 5. Testability
+
+**Issue:** Direct instantiation with `new DatabaseMigrator(...)` prevents unit testing.
+
+**Recommendation:**
+1. Add `IDatabaseMigrator` interface
+2. Register in DI container
+3. Allow mock injection for testing
+
+**Positive:** The test infrastructure is well-designed with automatic test data cleanup.
+
+---
+
+## 6. Code Duplication
+
+### Table Definition Duplication
+
+`_Curr` and `_Hist` table pairs have identical column definitions duplicated across multiple files.
+
+**Note:** This is typical for SQL migration files but consider documenting canonical column definitions in a single reference location.
+
+### MisData Triple Duplication
+
+Files 012 and 012a both create `MisData_Hist` with identical DDL - appears to be refactoring artifact.
+
+**Recommendation:** Clean up redundant migration script.
+
+---
+
+## 7. Null Safety
+
+**Good:** Project enables nullable reference types with proper null-coalescing throw pattern:
+
+```csharp
+_connectionString = configuration.GetConnectionString("SqlServer")
+    ?? throw new InvalidOperationException("SqlServer connection string not configured");
+```
+
+---
+
+## 8. Documentation
+
+### SQL Script Documentation
+
+**Good:** Each SQL script includes header comments with migration name and source reference.
+
+### C# XML Documentation
+
+**Needs Improvement:** `DatabaseMigrator` class lacks XML documentation.
+
+---
+
+## 9. Additional Observations
+
+### Hardcoded Status Codes
+
+Status codes are hardcoded as magic numbers in stored procedures.
+
+**Recommendation:** Document status codes centrally or add inline comments.
+
+---
+
+## Recommendations Summary
+
+### Critical
+1. Extract `IDatabaseMigrator` interface
+2. Clean up MisData duplication (012/012a scripts)
+
+### Important
+3. Add XML documentation to `DatabaseMigrator`
+4. Document status code meanings centrally
+5. Add exception wrapping in migrator
+
+### Suggestions
+6. Add interface registration in DI
+7. Document table definition canonically for `_Curr/_Hist` pairs