dohertj2/jdescopingtool
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(excelio): allow DeleteRows on protected worksheets

Browse Source 
Enable users to delete rows in protected Excel worksheets for better
data management flexibility.
This commit is contained in:
Joseph Doherty
2026-01-19 00:44:13 -05:00
parent 0c8657713b
commit 5a798b089b
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
NEW/src/JdeScoping.ExcelIO/Formatting/WorksheetProtector.cs
+1 -2
View File
@@ -18,6 +18,7 @@ public static class WorksheetProtector
// Allow these operations // Allow these operations
protection.AllowElement(XLSheetProtectionElements.DeleteColumns); protection.AllowElement(XLSheetProtectionElements.DeleteColumns);
protection.AllowElement(XLSheetProtectionElements.DeleteRows);
protection.AllowElement(XLSheetProtectionElements.AutoFilter); protection.AllowElement(XLSheetProtectionElements.AutoFilter);
protection.AllowElement(XLSheetProtectionElements.FormatCells); protection.AllowElement(XLSheetProtectionElements.FormatCells);
protection.AllowElement(XLSheetProtectionElements.FormatColumns); protection.AllowElement(XLSheetProtectionElements.FormatColumns);
@@ -26,8 +27,6 @@ public static class WorksheetProtector
protection.AllowElement(XLSheetProtectionElements.SelectUnlockedCells); protection.AllowElement(XLSheetProtectionElements.SelectUnlockedCells);
protection.AllowElement(XLSheetProtectionElements.EditObjects); protection.AllowElement(XLSheetProtectionElements.EditObjects);
protection.AllowElement(XLSheetProtectionElements.Sort); protection.AllowElement(XLSheetProtectionElements.Sort);
// Note: DeleteRows is NOT allowed (not in AllowElement call)
} }
/// <summary> /// <summary>
NEW/tests/JdeScoping.ExcelIO.Tests/WorksheetProtectorTests.cs
+4 -3
View File
@@ -28,6 +28,7 @@ public class WorksheetProtectorTests
// Check that specified operations are allowed // Check that specified operations are allowed
worksheet.Protection.AllowedElements.HasFlag(XLSheetProtectionElements.DeleteColumns).ShouldBeTrue(); worksheet.Protection.AllowedElements.HasFlag(XLSheetProtectionElements.DeleteColumns).ShouldBeTrue();
worksheet.Protection.AllowedElements.HasFlag(XLSheetProtectionElements.DeleteRows).ShouldBeTrue();
worksheet.Protection.AllowedElements.HasFlag(XLSheetProtectionElements.AutoFilter).ShouldBeTrue(); worksheet.Protection.AllowedElements.HasFlag(XLSheetProtectionElements.AutoFilter).ShouldBeTrue();
worksheet.Protection.AllowedElements.HasFlag(XLSheetProtectionElements.FormatCells).ShouldBeTrue(); worksheet.Protection.AllowedElements.HasFlag(XLSheetProtectionElements.FormatCells).ShouldBeTrue();
worksheet.Protection.AllowedElements.HasFlag(XLSheetProtectionElements.FormatColumns).ShouldBeTrue(); worksheet.Protection.AllowedElements.HasFlag(XLSheetProtectionElements.FormatColumns).ShouldBeTrue();
@@ -39,15 +40,15 @@ public class WorksheetProtectorTests
} }
[Fact] [Fact]
public void ApplyProtection_DoesNotAllowDeleteRows() public void ApplyProtection_AllowsDeleteRows()
{ {
using var workbook = new XLWorkbook(); using var workbook = new XLWorkbook();
var worksheet = workbook.Worksheets.Add("Test"); var worksheet = workbook.Worksheets.Add("Test");
WorksheetProtector.ApplyProtection(worksheet, "TestPassword"); WorksheetProtector.ApplyProtection(worksheet, "TestPassword");
// DeleteRows should NOT be allowed // DeleteRows should be allowed
worksheet.Protection.AllowedElements.HasFlag(XLSheetProtectionElements.DeleteRows).ShouldBeFalse(); worksheet.Protection.AllowedElements.HasFlag(XLSheetProtectionElements.DeleteRows).ShouldBeTrue();
} }
[Fact] [Fact]