From 3c728dd5752256272330e378c0e8e36027f8cf20 Mon Sep 17 00:00:00 2001
From: Joseph Doherty <dohertj2@Josephs-MacBook-Pro.local>
Date: Tue, 6 Jan 2026 14:22:26 -0500
Subject: [PATCH] refactor(datasync): update tests to remove FetcherTypeName

- Remove FetcherTypeName assignments from test fixtures in ScheduleCheckerTests
  and SyncOrchestratorTests
- Remove PrepurgeData and ReIndexData assignments from MassConfig in tests
- Mark FetcherTypeName, PostProcessorTypeName, PrepurgeData, and ReIndexData
  as obsolete with deprecation warnings pointing to pipelines.json
- Change FetcherTypeName from required to optional to allow tests to compile
  without providing the deprecated property
---
 .../JdeScoping.DataSync/Options/DataSourceConfig.cs    | 10 +++++++++-
 .../JdeScoping.DataSync.Tests/ScheduleCheckerTests.cs  |  5 +----
 .../JdeScoping.DataSync.Tests/SyncOrchestratorTests.cs |  1 -
 3 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/NEW/src/JdeScoping.DataSync/Options/DataSourceConfig.cs b/NEW/src/JdeScoping.DataSync/Options/DataSourceConfig.cs
index 1b10e26..973655d 100644
--- a/NEW/src/JdeScoping.DataSync/Options/DataSourceConfig.cs
+++ b/NEW/src/JdeScoping.DataSync/Options/DataSourceConfig.cs
@@ -22,12 +22,16 @@ public class DataSourceConfig
 
     /// <summary>
     /// Name of IDataFetcher implementation type (without generic suffix).
+    /// Deprecated: Will be removed in a future release.
     /// </summary>
-    public required string FetcherTypeName { get; set; }
+    [Obsolete("FetcherTypeName is deprecated and will be removed. Use pipelines.json configuration instead.")]
+    public string? FetcherTypeName { get; set; }
 
     /// <summary>
     /// Optional IPostProcessor implementation type name.
+    /// Deprecated: Will be removed in a future release.
     /// </summary>
+    [Obsolete("PostProcessorTypeName is deprecated and will be removed. Use pipelines.json postScripts instead.")]
     public string? PostProcessorTypeName { get; set; }
 
     /// <summary>
@@ -68,11 +72,15 @@ public class ScheduleConfig
 
     /// <summary>
     /// Whether to truncate the table before syncing (mass updates only).
+    /// Deprecated: Will be removed in a future release.
     /// </summary>
+    [Obsolete("PrepurgeData is deprecated and will be removed. Use pipelines.json syncModes.prePurge instead.")]
     public bool PrepurgeData { get; set; } = false;
 
     /// <summary>
     /// Whether to rebuild indexes after syncing (mass updates only).
+    /// Deprecated: Will be removed in a future release.
     /// </summary>
+    [Obsolete("ReIndexData is deprecated and will be removed. Use pipelines.json syncModes.reIndex instead.")]
     public bool ReIndexData { get; set; } = false;
 }
diff --git a/NEW/tests/JdeScoping.DataSync.Tests/ScheduleCheckerTests.cs b/NEW/tests/JdeScoping.DataSync.Tests/ScheduleCheckerTests.cs
index 2dce024..5d5c2f2 100644
--- a/NEW/tests/JdeScoping.DataSync.Tests/ScheduleCheckerTests.cs
+++ b/NEW/tests/JdeScoping.DataSync.Tests/ScheduleCheckerTests.cs
@@ -662,14 +662,11 @@ public class ScheduleCheckerTests
             TableName = tableName,
             SourceSystem = "JDE",
             SourceData = tableName.ToUpper(),
-            FetcherTypeName = $"Jde{tableName}Fetcher",
             IsEnabled = true,
             MassConfig = new ScheduleConfig
             {
                 Enabled = massEnabled,
-                IntervalMinutes = massInterval,
-                PrepurgeData = true,
-                ReIndexData = true
+                IntervalMinutes = massInterval
             },
             DailyConfig = new ScheduleConfig
             {
diff --git a/NEW/tests/JdeScoping.DataSync.Tests/SyncOrchestratorTests.cs b/NEW/tests/JdeScoping.DataSync.Tests/SyncOrchestratorTests.cs
index 9ef5481..90253dd 100644
--- a/NEW/tests/JdeScoping.DataSync.Tests/SyncOrchestratorTests.cs
+++ b/NEW/tests/JdeScoping.DataSync.Tests/SyncOrchestratorTests.cs
@@ -545,7 +545,6 @@ public class SyncOrchestratorTests
                 TableName = tableName,
                 SourceSystem = "JDE",
                 SourceData = tableName.ToUpper(),
-                FetcherTypeName = $"Jde{tableName}Fetcher",
                 IsEnabled = true,
                 MassConfig = new ScheduleConfig { Enabled = true, IntervalMinutes = 10080 },
                 DailyConfig = new ScheduleConfig { Enabled = true, IntervalMinutes = 1440 },