refactor(tests): migrate Database.Tests from FluentAssertions to Shouldly

Replace FluentAssertions with Shouldly across all 6 test files (94 tests).
Add ShouldlyExtensions for BeCloseTo and BeEquivalentTo patterns.
This commit is contained in:
Joseph Doherty
2026-01-29 14:40:18 -05:00
parent 04383d672c
commit 1e23616638
9 changed files with 223 additions and 152 deletions
@@ -1,7 +1,7 @@
using Dapper;
using FluentAssertions;
using JdeScoping.Core.Models.Search;
using JdeScoping.Database.Tests.Infrastructure;
using Shouldly;
namespace JdeScoping.Database.Tests.Functions;
@@ -27,7 +27,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert
results.Should().BeEquivalentTo([12345L, 67890L, 11111L]);
results.ShouldBeEquivalentTo([12345L, 67890L, 11111L]);
}
[Fact]
@@ -43,7 +43,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert
results.Should().BeEmpty();
results.ShouldBeEmpty();
}
[Fact]
@@ -58,7 +58,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert
results.Should().BeEmpty();
results.ShouldBeEmpty();
}
[Fact]
@@ -70,7 +70,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = 99999 });
// Assert
results.Should().BeEmpty();
results.ShouldBeEmpty();
}
[Fact]
@@ -85,7 +85,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert
results.Should().BeEmpty();
results.ShouldBeEmpty();
}
[Fact]
@@ -100,7 +100,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert
results.Should().BeEmpty();
results.ShouldBeEmpty();
}
[Fact]
@@ -119,7 +119,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert - null values should be filtered out
results.Should().BeEquivalentTo([12345L, 67890L]);
results.ShouldBeEquivalentTo([12345L, 67890L]);
}
#endregion
@@ -139,7 +139,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert
results.Should().BeEquivalentTo(["ITEM001", "ITEM002", "ITEM003"]);
results.ShouldBeEquivalentTo(["ITEM001", "ITEM002", "ITEM003"]);
}
[Fact]
@@ -155,7 +155,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert
results.Should().BeEmpty();
results.ShouldBeEmpty();
}
[Fact]
@@ -170,7 +170,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert
results.Should().BeEmpty();
results.ShouldBeEmpty();
}
[Fact]
@@ -182,7 +182,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = 99999 });
// Assert
results.Should().BeEmpty();
results.ShouldBeEmpty();
}
[Fact]
@@ -197,7 +197,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert
results.Should().BeEmpty();
results.ShouldBeEmpty();
}
[Fact]
@@ -212,7 +212,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert
results.Should().BeEmpty();
results.ShouldBeEmpty();
}
[Fact]
@@ -228,7 +228,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert - null values should be filtered out
results.Should().BeEquivalentTo(["ITEM001", "ITEM002"]);
results.ShouldBeEquivalentTo(["ITEM001", "ITEM002"]);
}
[Fact]
@@ -244,7 +244,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert
results.Should().BeEquivalentTo(["ITEM-001", "ITEM_002", "ITEM.003"]);
results.ShouldBeEquivalentTo(["ITEM-001", "ITEM_002", "ITEM.003"]);
}
#endregion
@@ -264,7 +264,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert
results.Should().BeEquivalentTo(["PC01", "PC02", "PC03"]);
results.ShouldBeEquivalentTo(["PC01", "PC02", "PC03"]);
}
[Fact]
@@ -280,7 +280,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert
results.Should().BeEmpty();
results.ShouldBeEmpty();
}
[Fact]
@@ -295,7 +295,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert
results.Should().BeEmpty();
results.ShouldBeEmpty();
}
[Fact]
@@ -307,7 +307,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = 99999 });
// Assert
results.Should().BeEmpty();
results.ShouldBeEmpty();
}
[Fact]
@@ -322,7 +322,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert
results.Should().BeEmpty();
results.ShouldBeEmpty();
}
[Fact]
@@ -337,7 +337,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert
results.Should().BeEmpty();
results.ShouldBeEmpty();
}
[Fact]
@@ -353,7 +353,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert - null values should be filtered out
results.Should().BeEquivalentTo(["PC01", "PC02"]);
results.ShouldBeEquivalentTo(["PC01", "PC02"]);
}
#endregion
@@ -373,7 +373,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert
results.Should().BeEquivalentTo(["WC001", "WC002", "WC003"]);
results.ShouldBeEquivalentTo(["WC001", "WC002", "WC003"]);
}
[Fact]
@@ -389,7 +389,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert
results.Should().BeEmpty();
results.ShouldBeEmpty();
}
[Fact]
@@ -404,7 +404,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert
results.Should().BeEmpty();
results.ShouldBeEmpty();
}
[Fact]
@@ -416,7 +416,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = 99999 });
// Assert
results.Should().BeEmpty();
results.ShouldBeEmpty();
}
[Fact]
@@ -431,7 +431,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert
results.Should().BeEmpty();
results.ShouldBeEmpty();
}
[Fact]
@@ -446,7 +446,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert
results.Should().BeEmpty();
results.ShouldBeEmpty();
}
[Fact]
@@ -462,7 +462,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert - null values should be filtered out
results.Should().BeEquivalentTo(["WC001", "WC002"]);
results.ShouldBeEquivalentTo(["WC001", "WC002"]);
}
#endregion
@@ -482,7 +482,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert
results.Should().BeEquivalentTo(["OP001", "OP002", "OP003"]);
results.ShouldBeEquivalentTo(["OP001", "OP002", "OP003"]);
}
[Fact]
@@ -498,7 +498,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert
results.Should().BeEmpty();
results.ShouldBeEmpty();
}
[Fact]
@@ -513,7 +513,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert
results.Should().BeEmpty();
results.ShouldBeEmpty();
}
[Fact]
@@ -525,7 +525,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = 99999 });
// Assert
results.Should().BeEmpty();
results.ShouldBeEmpty();
}
[Fact]
@@ -540,7 +540,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert
results.Should().BeEmpty();
results.ShouldBeEmpty();
}
[Fact]
@@ -555,7 +555,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert
results.Should().BeEmpty();
results.ShouldBeEmpty();
}
[Fact]
@@ -571,7 +571,7 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert - null values should be filtered out
results.Should().BeEquivalentTo(["OP001", "OP002"]);
results.ShouldBeEquivalentTo(["OP001", "OP002"]);
}
#endregion
@@ -592,8 +592,8 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert
results.Should().HaveCount(1000);
results.Should().BeEquivalentTo(workOrders);
results.Count().ShouldBe(1000);
results.ShouldBeEquivalentTo(workOrders);
}
[Fact]
@@ -610,8 +610,8 @@ public class SimpleTableFunctionTests : DatabaseTestBase
new { SearchId = searchId });
// Assert - value should be truncated to 128 characters
results.Should().HaveCount(1);
results.First().Should().HaveLength(128);
results.Count().ShouldBe(1);
results.First().Length.ShouldBe(128);
}
#endregion