Two cleanups from the post-EnsureTagAsync punch list — both isolated, no
protocol discovery required.
#89 dead code in Historian2020ProtocolDialect:
- BrowseTagNamesAsync and GetTagMetadataAsync on the dialect both threw
ProtocolEvidenceMissingException, but HistorianClient routes those calls
directly to HistorianWcfTagClient — the dialect overrides were never
reached. Removed both methods. ReadBlocksAsync stays (it's a deliberate
guardrailed entry on the public surface).
#90 explicit-creds tag-metadata path:
- HistorianWcfTagClient.WcfRetrievalSession.ValidateSupportedAuth threw
ProtocolEvidenceMissingException whenever IntegratedSecurity=false AND
UserName/Password were supplied. But the surrounding code already wires
those creds through ApplyWindowsCredential ->
factory.Credentials.Windows.ClientCredential — the validator was just
being conservative about an untested combination.
- Inverted the check: now only rejects the no-auth-at-all combination
(IntegratedSecurity=false + no UserName + no Password). The other three
valid auth shapes pass through to WCF.
Tests: 161 -> 163 (+2). New unit test verifies the no-auth case still
throws; new gated live integration test
GetTagMetadataAsync_ExplicitCredentials_AgainstLocalHistorian exercises the
explicit-creds path when HISTORIAN_USER+HISTORIAN_PASSWORD are set, skips
cleanly otherwise.
CLAUDE.md updated: removed the two now-resolved entries from "Remaining
gaps"; explicit-creds line refined to note the live-verification env-var
requirement.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Joseph Doherty
f32fd57874