fix(grpc): extended-property read parser + GetConnectionStatus over gRPC

- HistorianTagExtendedPropertyProtocol.ParseResponse: fix the multi-property/ multi-group response shape captured live from the 2023 R2 server. The server returns one group per property (the tag name repeats), each propertyCount=1, and a uint16 searchability-flags trailer per property (0x0003 built-in, 0x0001 user- added) — NOT the single-byte group trailer the old model assumed, which drifted one byte per group and threw "expected 0x09 found 0x01" on any buffer with more than one property. Now reads the per-property uint16 trailer (tolerates a legacy 1-byte tail). Fixes read-back on both WCF and gRPC. Adds GetTagExtendedPropertiesRaw for future captures. - HistorianGrpcStatusClient.GetConnectionStatusAsync (plan #5): synthesize connection status from a measured gRPC handshake (OpenConnection yielding a storage-session GUID => connected), mirroring the WCF synthesize-from-probe approach. Routed in Historian2020ProtocolDialect on UseGrpc (the WCF path used the MDAS binding, which can't reach the gRPC port). - HistorianGrpcSqlClient: record the negative plan-#4 result — a HistoryService. RegisterTags prime does NOT clear the server-side CSrvDbConnection fault (tried live on both 0x402/0x401); the op stays bounded behind ProtocolEvidenceMissingException. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B6mcaT2PjRFKcogzp9UkfC
2026-06-22 06:03:38 -04:00
parent 000f4120d5
commit 3525653c2b
5 changed files with 121 additions and 14 deletions
@@ -111,6 +111,57 @@ internal static class HistorianGrpcStatusClient
        }
    }

+    /// <summary>
+    /// Returns a <em>measured</em> connection status over the 2023 R2 gRPC transport (plan #5). Mirrors
+    /// <see cref="Wcf.HistorianWcfStatusClient"/>'s synthesize-from-handshake approach: it opens an
+    /// authenticated session and reports <see cref="HistorianConnectionStatus.ConnectedToServer"/> /
+    /// <see cref="HistorianConnectionStatus.ConnectedToServerStorage"/> from whether the handshake
+    /// (GetInterfaceVersion → ValidateClientCredential token loop → OpenConnection, which yields the
+    /// storage-session GUID) succeeds. There is no dedicated connection-status RPC on either transport.
+    /// Store-forward connectivity is not observable here (D2-gated) and stays false.
+    /// </summary>
+    public static Task<HistorianConnectionStatus> GetConnectionStatusAsync(
+        HistorianClientOptions options,
+        CancellationToken cancellationToken)
+        => Task.Run(() => GetConnectionStatus(options, cancellationToken), cancellationToken);
+
+    private static HistorianConnectionStatus GetConnectionStatus(HistorianClientOptions options, CancellationToken cancellationToken)
+    {
+        bool connected;
+        string? error = null;
+        try
+        {
+            using HistorianGrpcConnection connection = HistorianGrpcChannelFactory.Create(options);
+            // A successful OpenConnection yields a non-empty storage-session GUID — proof the server and
+            // its storage session are reachable, the gRPC analog of the WCF handshake probe.
+            HistorianGrpcHandshake.Session session = HistorianGrpcHandshake.OpenSession(connection, options, cancellationToken);
+            connected = session.StorageSessionId != Guid.Empty;
+            if (!connected)
+            {
+                error = "OpenConnection returned an empty storage-session handle.";
+            }
+        }
+        catch (OperationCanceledException)
+        {
+            throw;
+        }
+        catch (Exception ex)
+        {
+            connected = false;
+            error = $"{ex.GetType().Name}: {ex.Message}";
+        }
+
+        return new HistorianConnectionStatus(
+            ServerName: options.Host,
+            Pending: false,
+            ErrorOccurred: !connected,
+            Error: error,
+            ConnectedToServer: connected,
+            ConnectedToServerStorage: connected,
+            ConnectedToStoreForward: false,
+            ConnectionKind: HistorianConnectionKind.Process);
+    }
+
    /// <summary>
    /// Reads the Historian server's system time-zone name (roadmap item R1.3,
    /// <c>StatusService.GetSystemTimeZoneName</c>). Unlike the 2020 WCF surface — where the native