6 Commits

Author SHA1 Message Date
Joseph Doherty cdfacdd0c4 merge: T118 phase 4.5 docs sweep — Phase 4.5 status + Phase 5 backlog 2026-04-27 07:04:01 -04:00
Joseph Doherty 5c4356e4e2 merge: T117 phase 4.5 cross-feature integration tests 2026-04-27 07:04:01 -04:00
Joseph Doherty 969f8963bc merge: T116 CannedQueue test fixture builder 2026-04-27 07:04:01 -04:00
Joseph Doherty f71613786b test: phase 4.5 cross-feature integration coverage (T117) 2026-04-27 07:03:56 -04:00
Joseph Doherty 4afaf01de7 test: structured CannedQueue fixture builder for classifier mocks (T116)
Phase 4.5 carry-over from Phase 3. Tests across test_turn_flow.py,
test_meanwhile_turn_flow.py, and the phase3/4 integration suites built
positional canned-response arrays for MockLLMClient — adding a new
classifier call to a code path required updating the array index in
many places.

This change ships tests/fixtures.py with a fluent CannedQueue builder
that lets tests declare classifier expectations by name and call order
instead of by index. Each method appends one item to an internal queue
and returns self for chaining; build() emits the flat list[str] queue
that MockLLMClient(canned=...) already consumes. The mock's contract
is unchanged.

Builder methods cover: parse_turn, detect_addressee, state_update
(with zero_state alias), detect_interjection,
detect_interjection_targeted, detect_scene_close,
detect_event_transitions, summarize_scene_pov, detect_threads,
meanwhile_digest, score_significance, and a narrative() helper for
streaming bot beats. raw() is a passthrough escape hatch.

Migration scope: ship the builder + 2 sanity tests + migrate 3
representative tests in test_turn_flow.py as proof of concept
(test_single_bot_turn_no_guest_regression,
test_turn_with_event_transition_appends_started_event,
test_turn_with_no_active_events_skips_classifier). The remaining
positional-array tests stay as-is; the builder docstring documents
the migration template for Phase 5 work.
2026-04-27 07:03:20 -04:00
Joseph Doherty 5bc9a94734 docs: phase 4.5 status, prune backlog, capture phase 5 candidates (T118) 2026-04-27 06:56:20 -04:00
6 changed files with 1371 additions and 76 deletions
+39 -44
View File
@@ -322,53 +322,48 @@ Phase 4 polish shipped end-to-end across 15 tasks (T88T102). Vector retrieval
### Phase 4.5 / 5 backlog ### Phase 4.5 / 5 backlog
New follow-ups discovered during Phase 4 reviews and execution. None are blocking; pick up at any time. All items shipped or deferred to Phase 5 (see "Phase 5 backlog" below). Final schema version: 14.
#### From T88 review ## Phase 4.5 status
- **`embeddings` FK lacks `ON DELETE CASCADE`**: deindex events are the only deletion path; if memories ever get deleted directly (raw SQL), embedding rows orphan. Defensible since projector model uses explicit deindex events, but worth a comment or `ON DELETE CASCADE` addition. Phase 4.5 cleanup shipped 13 of 14 planned tasks (T103T117 with T115 deferred; T118 is this docs sweep). Two CLAUDE.md backlogs (Phase 3.6/4, Phase 4.5/5) are now empty; deferred follow-ups discovered during execution are tracked in a new "Phase 5 backlog" section below. Schema baseline advanced from version 13 to **14** (migration 0014: `memories.event_id`). Test count grew from ~413 (Phase 4) to ~457 (+~44 new tests across the wave).
#### From T89 review - **Wave 1 — trivial polish (parallel)**:
- **T103** branches polish — global-branch (`chat_id IS NULL`) leak documented in `list_branches`; branch-switch to nonexistent name now logs a warning.
- **T104** `memory.py` DRY — `MAX(id)` helper extracted; `fts_rank=None` contract documented for vector-only rows.
- **T105** `snapshots.py` polish — `datetime`/`timezone` imports hoisted to module level; strict `kind` validation in restore/preview (rejects missing); `created_at` from file mtime documented.
- **T106** `search.py` polish — `k=50` extracted to module constant; N+1 `get_bot`/`get_chat`/`get_scene` lookups batched.
- **T107** `embeddings.py``timeout_s` fallback-path warning when non-default model misconfigured.
- **Wave 2 — scene-close-on-cancel (single)**:
- **T108** strengthened the T74.3 regression test + documented rationale in `turns.py`. **Surfaced a deferred bug**: existing pin only passes because `asyncio` isn't imported in the test module (NameError caught instead of CancelledError). When CancelledError fires for real, `post_turn`'s end-of-function re-raise causes `open_db`'s dependency teardown to skip `conn.commit()`, rolling back ALL post-cancel writes. Documented and deferred to Phase 5 triage.
- **Wave 3 — schema 0014 (single)**:
- **T109** `memories.event_id` column (foundation for T111 deep-link). FK CASCADE on `embeddings.memory_id` deferred (memories rows are never deleted today; defensive constraint can't fire — saved for broader migration cleanup in Phase 5).
- **Wave 4 — drawer Phase 4.5 bundle (single)**:
- **T110** `event_id <= 0` guard in `delete_turn` + `html.escape()` on delete-impact modal + Jinja partial extraction + bulk significance re-rate per chat (one `manual_edit` event per memory).
- **Wave 5 — search UX (single)**:
- **T111** FTS snippet highlighting via `snippet()` + deep-link to turn via `memories.event_id`.
- **Wave 6 — real embedding model swap (single)**:
- **T112** `LLMClient.embed()` Protocol + Mock impl with `canned_embeddings` + `FeatherlessClient.embed()` (raises `NotImplementedError` — Featherless OAI-compat doesn't expose embeddings, gap documented) + `generate_embedding` routes non-default models through `client.embed()` with fallback + `--re-embed-all` backfill flag.
- **Wave 7 — branching read-side filter (single)**:
- **T113** `active_branch_event_ids(conn)` helper + applied to `read_recent_dialogue`, `scene_summarize._read_recent_dialogue`, `search_memories`, and `meanwhile._read_recent_meanwhile_dialogue`. Cross-chat search and projector queries deliberately NOT filtered (cross-chat is by design; projectors must see full log). Bootstrap "main" branch (origin=0, head=0) detected as the no-clamp sentinel.
- **Wave 8 — regenerate lifecycle rollback (single)**:
- **T114** `triggered_by_assistant_turn_id` payload back-reference on `event_started`/`event_completed`/`event_cancelled` + new `event_status_reverted` event kind + projector handler in `chat/state/events.py` + regenerate flow emits revert events for affected lifecycle transitions.
- **Wave 9 — final polish + integration (parallel)**:
- **T115** sqlite-vec swap — **DEFERRED to Phase 5**. Pre-flight failed: host Python build doesn't expose `sqlite3.Connection.enable_load_extension` (raises `AttributeError`). Requires either Python rebuild with `--enable-loadable-sqlite-extensions` or migration to `apsw`. Phase 4 pure-Python cosine remains in production.
- **T116** structured `CannedQueue` test fixture builder + 23 POC test migrations (Phase 5 to migrate the rest).
- **T117** Phase 4.5 cross-feature integration tests (5 minimum: real embedding swap, branching read-side filter, lifecycle rollback, search deep-link, bulk significance re-rate).
- **T118** documentation (this section).
- **`list_branches(chat_id=...)` filter leaks global branches** (`chat_id IS NULL`) into every chat scope. Intentional? Document. ### Phase 5 backlog
- **Branch-switch to nonexistent silently leaves zero active branches** — log a warning when this would happen.
#### From T91 review New follow-ups discovered during Phase 4.5 reviews and execution, plus carry-over deferrals. None are blocking; pick up at any time.
- **Real embedding model swap**: Phase 4 ships pseudo-embedding (deterministic SHA-256 hash). Phase 4.5+ should swap to a real model (Featherless `bge-small-en-v1.5` if available; or local `sentence-transformers/all-MiniLM-L6-v2`). The 384-dim is hardcoded in `0012_embeddings.sql`; if dim changes, migrate first. - **T115 sqlite-vec swap** (environmental blocker): host Python's `sqlite3.Connection` does not expose `enable_load_extension``python -c "import sqlite3; sqlite3.connect(':memory:').enable_load_extension(True)"` raises `AttributeError`. Fix requires either a Python rebuild with `--enable-loadable-sqlite-extensions` or migration to `apsw`. Pure-Python cosine remains in production until then.
- **`timeout_s` unused on pseudo path** — fine, but log when non-default model falls through to fallback so misconfigured callers don't silently degrade. - **T108 follow-up: cancel-path commit bug** — `post_turn`'s re-raised `CancelledError` causes `open_db` dependency teardown to skip `conn.commit()`, rolling back all post-cancel writes. The existing T74.3 regression test passes only because `asyncio` isn't imported in the test module (NameError masks the real cancel path). Triage required — either commit before re-raise, or restructure the route to never re-raise after the close-detection branch.
- **`embeddings` FK CASCADE on `memory_id`** — deferred from T109; do as part of a broader migration consolidation in Phase 5.
#### From T96 review - **`CannedQueue` fixture migration** — T116 shipped the builder + POC migrations; remaining tests still use positional canned arrays. Migrate in Phase 5.
- **Vector index optimization (HNSW)** — currently scales to a few thousand memories on the flat-index pure-Python cosine path; revisit when counts grow past flat-index feasibility.
- **Duplicate `MAX(id)` lookup** between `_composite_rerank` and the fused-path tail — DRY follow-up. - **Branch-isolated `event_log`** — each branch has its own physical `event_log` range vs the current shared id space + head filter; full branch isolation is Phase 5+.
- **`fts_rank=None` for vector-only rows** — document downstream contract. - **Embedding model swap migration tooling** — T112 added `--re-embed-all`; a more orchestrated swap (drain old worker, re-seed all memories, swap config) is Phase 5+.
- **Real-time collaborative branching** (multi-user) — out of scope for v1.
#### From T98 review - **Avatars / portraits** (multimodality) — deferred indefinitely per design §14.
- **`event_id <= 0` guard in `delete_turn`** — currently silently rewinds everything if `event_id` is 0. Add `if event_id <= 0: 400`.
- **`html.escape()` on `compute_delete_impact` output rendered into the modal** — defense in depth (currently model-controlled strings, but if event payload fields ever appear in descriptions, autoescape needed).
- **Extract delete-impact modal HTML to a Jinja partial** — testability + autoescape inheritance.
#### From T99 review
- **Hoist `datetime`/`timezone` imports to module level** in `chat/web/snapshots.py`.
- **`kind` defaulting in restore/preview** — reject missing `kind` rather than silent 404.
- **`created_at` from file mtime** vs filename-encoded timestamp — small drift if files copied; document.
#### From T100 review
- **Hardcoded `k=50`** — extract to module constant.
- **N+1 lookups (`get_bot`/`get_chat`/`get_scene` per row)** — fine at `k=50`, revisit if `k` grows.
- **FTS highlighting via `snippet()`** — Phase 4 skipped this; UX nice-to-have.
- **Result links chat-level only** — `memories` table has no `event_id` column; deep-linking to specific turn requires schema addition.
#### Deferred items
- **sqlite-vec swap** when host Python supports `enable_load_extension`.
- **Real embedding model** with proper semantic similarity.
- **Branching read-side filter**: T89 ships data-model + UI but event readers don't yet consult `is_active`. Each branch is metadata-only labeled ranges. Consult-on-read is Phase 4.5+ work.
- **Bulk significance re-rate** in drawer (T98.2 deferred — only per-memory edit shipped).
- **Vector index optimization** (HNSW) — only relevant if memory counts grow past pure-Python feasibility.
- **`scene-close-on-cancel` UX revisit** (Phase 2.5 carry-over).
- **Cross-feature canned-queue brittleness fixture builder** (Phase 3 carry-over).
- **Full lifecycle-rollback in regenerate** — Phase 3.5 T83.4 shipped a warning log; proper rollback needs schema-level back-references (`triggered_by_assistant_turn_id` payload field).
@@ -522,6 +522,8 @@ Written per witness when a scene closes. Different details, different interpreta
**Status: shipped 2026-04-27** (T88T102, 15 tasks across 8 waves; +70 tests). See "Phase 4 status" in CLAUDE.md for the per-task breakdown. Vector retrieval shipped via pure-Python cosine over a JSON-blob embeddings table (sqlite-vec deferred — host Python lacks loadable extensions); branching is data-model + drawer UI; significance review, hide-from-view soft delete, surgical delete with cascade preview, snapshot UX, and cross-chat search all surface from the drawer or top-bar. **Status: shipped 2026-04-27** (T88T102, 15 tasks across 8 waves; +70 tests). See "Phase 4 status" in CLAUDE.md for the per-task breakdown. Vector retrieval shipped via pure-Python cosine over a JSON-blob embeddings table (sqlite-vec deferred — host Python lacks loadable extensions); branching is data-model + drawer UI; significance review, hide-from-view soft delete, surgical delete with cascade preview, snapshot UX, and cross-chat search all surface from the drawer or top-bar.
**Phase 4.5 cleanup: shipped 2026-04-27** (T103T118, 13 of 14 planned tasks; T115 sqlite-vec swap deferred to Phase 5 due to host Python lacking `enable_load_extension`; +~44 tests; schema baseline now 14). See "Phase 4.5 status" in CLAUDE.md for the per-task breakdown — notable shipped: real embedding model swap path (`LLMClient.embed()` + `--re-embed-all`), branching read-side filter (`active_branch_event_ids`), regenerate lifecycle rollback (`event_status_reverted`), FTS snippet highlighting + deep-link to turn (`memories.event_id`), bulk significance re-rate.
- Vector retrieval (sqlite-vss or sqlite-vec). - Vector retrieval (sqlite-vss or sqlite-vec).
- Branching UI. - Branching UI.
- Drawer-edit on every field. - Drawer-edit on every field.
+383
View File
@@ -0,0 +1,383 @@
"""Structured test-fixture builder for ``MockLLMClient`` canned queues.
Phase 4.5 (T116) carry-over from Phase 3. The turn-flow tests in
``test_turn_flow.py``, ``test_meanwhile_turn_flow.py``,
``test_phase3_integration.py``, and ``test_phase4_integration.py`` used
to construct ``MockLLMClient`` canned-response queues as raw positional
lists of pre-encoded JSON strings. That worked, but every time a new
classifier call landed in a code path the tests had to be patched in
many places at the right index — easy to mis-position, hard to read.
This module ships :class:`CannedQueue`, a fluent builder that lets a
test declare its classifier expectations by **name** and **order** of
call, not by index into a brittle list. Each method appends one item
to the queue and returns ``self`` for chaining; ``build()`` JSON-encodes
the items and produces the flat ``list[str]`` that
``MockLLMClient(canned=...)`` expects.
Usage
-----
>>> from tests.fixtures import CannedQueue
>>> from chat.llm.mock import MockLLMClient
>>> canned = (
... CannedQueue()
... .parse_turn(segments=[{"kind": "dialogue", "text": "hello"}])
... .narrative("Hi there.")
... .state_update()
... .state_update()
... .build()
... )
>>> mock = MockLLMClient(canned=canned)
Each method maps to a single classifier (or stream) call that the turn
flow makes, in the order the production code makes them. Picking the
right method for the slot you need keeps the test readable and lets the
builder pin sensible defaults for the fields tests don't care about.
Migration template
------------------
To migrate a positional canned-array test:
1. Identify each slot in the existing array and what classifier it
feeds. Comments above the array often spell this out — start there.
2. Replace each slot with the matching :class:`CannedQueue` method:
- ``json.dumps({"segments": [...]})`` → ``.parse_turn(segments=...)``
- bare narrative string → ``.narrative("...")``
- zero-state JSON → ``.state_update()`` (defaults are zeros)
- ``json.dumps({"addressee_id": ...})`` → ``.detect_addressee(...)``
- ``json.dumps({"should_interject": ...})`` → ``.detect_interjection(...)``
- ``json.dumps({"should_close": ...})`` → ``.detect_scene_close(...)``
- ``json.dumps({"transitions": [...]})`` → ``.detect_event_transitions(...)``
- per-POV summary JSON → ``.summarize_scene_pov(summary=...)``
3. End with ``.build()`` and pass that to
``MockLLMClient(canned=...)``. The mock's contract is unchanged.
Notes on streams
----------------
``MockLLMClient.stream`` and ``MockLLMClient.generate`` share one queue
— each pop is one entry, regardless of whether the production code
streams the response or generates it whole. The narrative service
streams; classifier services generate. The builder treats both the same:
``narrative()`` appends a raw string, the classifier methods append
JSON-encoded dicts. Both end up in the same flat ``list[str]`` that the
mock pops from in order.
The remaining tests in the suite (about 30 across the four files
mentioned above) still use positional arrays — Phase 5 work to migrate
the rest. New tests should prefer this builder.
"""
from __future__ import annotations
import json
from typing import Any
class CannedQueue:
"""Fluent builder for ``MockLLMClient`` canned-response queues.
Each method appends one item to an internal queue and returns
``self`` for chaining. ``build()`` returns the flat ``list[str]``
suitable for ``MockLLMClient(canned=...)``.
The queue holds either ``dict`` (JSON-encoded at ``build()`` time)
or ``str`` (passed through verbatim — used for narrative streams).
"""
def __init__(self) -> None:
self._queue: list[Any] = []
# ------------------------------------------------------------------
# Narrative stream — bare string, no JSON wrapping.
# ------------------------------------------------------------------
def narrative(self, text: str) -> "CannedQueue":
"""Append one streaming narrative response.
``MockLLMClient.stream`` pops the next entry from the same queue
as ``generate`` — a bare string is what the streaming bot beat
consumes. Use one ``narrative()`` per assistant beat (primary,
and optionally an interjection / second beat).
"""
self._queue.append(text)
return self
def raw(self, value: str) -> "CannedQueue":
"""Append a raw string (escape hatch for non-classifier calls).
Most tests should reach for the named helpers — this is here
for one-offs the builder doesn't model yet.
"""
self._queue.append(value)
return self
# ------------------------------------------------------------------
# Turn parser — splits user prose into segments.
# ------------------------------------------------------------------
def parse_turn(
self,
*,
segments: list[dict] | None = None,
intent: str = "narrative",
landing_state_hint: str = "",
**rest: Any,
) -> "CannedQueue":
"""Append one ``parse_turn`` classifier response.
``intent`` defaults to ``"narrative"``; pass ``"skip_elision"``
or ``"skip_jump"`` to exercise the natural-language skip paths.
``landing_state_hint`` carries the residual descriptor for
elision skips and is otherwise ignored.
"""
payload: dict[str, Any] = {
"segments": segments if segments is not None else [],
"intent": intent,
"landing_state_hint": landing_state_hint,
}
payload.update(rest)
self._queue.append(payload)
return self
# ------------------------------------------------------------------
# Multi-entity addressee classifier (T74.1).
# ------------------------------------------------------------------
def detect_addressee(
self,
*,
addressee_id: str,
confidence: str = "medium",
reason: str = "",
**rest: Any,
) -> "CannedQueue":
"""Append one ``detect_addressee`` classifier response."""
payload: dict[str, Any] = {
"addressee_id": addressee_id,
"confidence": confidence,
"reason": reason,
}
payload.update(rest)
self._queue.append(payload)
return self
# ------------------------------------------------------------------
# State-update — one per directed edge per turn.
# ------------------------------------------------------------------
def state_update(
self,
*,
affinity_delta: int = 0,
trust_delta: int = 0,
knowledge_facts: list | None = None,
**rest: Any,
) -> "CannedQueue":
"""Append one ``apply_state_update`` classifier response.
Defaults to a benign zero-delta payload — tests that don't care
about state mutations can call this without arguments. One call
is required per directed edge that fires after the assistant
beat (e.g. single-bot non-guest turn = 2 calls; multi-bot guest
turn = 6 calls).
"""
payload: dict[str, Any] = {
"affinity_delta": affinity_delta,
"trust_delta": trust_delta,
"knowledge_facts": (
knowledge_facts if knowledge_facts is not None else []
),
}
payload.update(rest)
self._queue.append(payload)
return self
def zero_state(self) -> "CannedQueue":
"""Alias for ``state_update()`` with all defaults — matches the
``_zero_state()`` helper in existing tests.
"""
return self.state_update()
# ------------------------------------------------------------------
# Interjection (T74.2) — silent witness chimes in.
# ------------------------------------------------------------------
def detect_interjection(
self,
*,
should_interject: bool,
reason: str = "",
**rest: Any,
) -> "CannedQueue":
"""Append one ``detect_interjection`` classifier response."""
payload: dict[str, Any] = {
"should_interject": should_interject,
"reason": reason,
}
payload.update(rest)
self._queue.append(payload)
return self
def detect_interjection_targeted(
self,
*,
targeted: bool,
target_id: str | None = None,
reason: str = "",
**rest: Any,
) -> "CannedQueue":
"""Append one targeted-interjection classifier response."""
payload: dict[str, Any] = {
"targeted": targeted,
"target_id": target_id,
"reason": reason,
}
payload.update(rest)
self._queue.append(payload)
return self
# ------------------------------------------------------------------
# Scene-close detector (T26).
# ------------------------------------------------------------------
def detect_scene_close(
self,
*,
should_close: bool,
reason: str = "",
**rest: Any,
) -> "CannedQueue":
"""Append one ``detect_scene_close`` classifier response."""
payload: dict[str, Any] = {
"should_close": should_close,
"reason": reason,
}
payload.update(rest)
self._queue.append(payload)
return self
# ------------------------------------------------------------------
# Event lifecycle (T52, T61) — per-turn transitions.
# ------------------------------------------------------------------
def detect_event_transitions(
self,
transitions: list[dict] | None = None,
) -> "CannedQueue":
"""Append one ``detect_event_transitions`` classifier response.
``transitions`` is a list of ``{"event_id": ..., "new_status":
"active"|"completed"|"cancelled", "reason": ...}`` dicts. Pass
an empty list (or omit the argument) to assert that the call
ran but produced no transitions; pass ``None`` for an empty
list with the same shape.
Note: when no events are seeded, ``detect_event_transitions``
short-circuits without an LLM call — in that case do NOT append
this slot.
"""
payload = {"transitions": transitions if transitions is not None else []}
self._queue.append(payload)
return self
# ------------------------------------------------------------------
# Per-POV scene summary (used after scene close).
# ------------------------------------------------------------------
def summarize_scene_pov(
self,
*,
summary: str,
knowledge_facts: list | None = None,
relationship_summary: str = "",
**rest: Any,
) -> "CannedQueue":
"""Append one per-POV scene-summary response.
Used by ``apply_scene_close_summary`` — one call per witness
once a scene closes.
"""
payload: dict[str, Any] = {
"summary": summary,
"knowledge_facts": (
knowledge_facts if knowledge_facts is not None else []
),
"relationship_summary": relationship_summary,
}
payload.update(rest)
self._queue.append(payload)
return self
# ------------------------------------------------------------------
# Thread detection (Phase 3 §3.3).
# ------------------------------------------------------------------
def detect_threads(
self,
candidates: list[dict] | None = None,
) -> "CannedQueue":
"""Append one ``detect_threads`` classifier response.
``candidates`` is a list of ``{"action": "open"|"update",
"title": ..., "summary": ..., "existing_thread_id": ...}`` dicts.
"""
payload = {"candidates": candidates if candidates is not None else []}
self._queue.append(payload)
return self
# ------------------------------------------------------------------
# Meanwhile digest — narrative summary of what happened off-screen.
# ------------------------------------------------------------------
def meanwhile_digest(self, summary: str) -> "CannedQueue":
"""Append one meanwhile-digest narrative response.
The digest service streams the digest as plain text (not JSON)
so this is a thin wrapper over ``narrative``/``raw`` for
readability at the call site.
"""
self._queue.append(summary)
return self
# ------------------------------------------------------------------
# Significance scorer (background worker; rarely hit in unit tests
# but available for completeness).
# ------------------------------------------------------------------
def score_significance(
self,
*,
score: float = 0.0,
reason: str = "",
**rest: Any,
) -> "CannedQueue":
"""Append one significance-scoring classifier response."""
payload: dict[str, Any] = {"score": score, "reason": reason}
payload.update(rest)
self._queue.append(payload)
return self
# ------------------------------------------------------------------
# Build / introspection.
# ------------------------------------------------------------------
def build(self) -> list[str]:
"""Return the flat ``list[str]`` queue for ``MockLLMClient``.
Dict items are JSON-encoded; string items are passed through
verbatim (so streaming responses retain their raw form).
"""
out: list[str] = []
for item in self._queue:
if isinstance(item, str):
out.append(item)
else:
out.append(json.dumps(item))
return out
def __len__(self) -> int:
return len(self._queue)
+140
View File
@@ -0,0 +1,140 @@
"""Sanity tests for :mod:`tests.fixtures` — the structured CannedQueue
builder for ``MockLLMClient`` (T116).
The builder is a thin shaping layer over JSON dicts; these tests pin
the JSON shapes and the ``MockLLMClient`` round-trip so nothing
silently regresses if a default field name or shape gets renamed.
"""
from __future__ import annotations
import json
import pytest
from chat.llm.mock import MockLLMClient
from tests.fixtures import CannedQueue
def test_canned_queue_build_emits_expected_shapes():
"""Each builder method emits the JSON shape its classifier consumer
expects. The narrative slot is a bare string (stream).
"""
canned = (
CannedQueue()
.parse_turn(segments=[{"kind": "dialogue", "text": "hello"}])
.detect_addressee(addressee_id="bot_a", reason="host")
.narrative("Hi there.")
.state_update()
.state_update(affinity_delta=1, trust_delta=2)
.detect_interjection(should_interject=False, reason="calm")
.detect_event_transitions(
[{"event_id": "evt_1", "new_status": "active", "reason": "they arrived"}]
)
.detect_scene_close(should_close=False, reason="no signal")
.summarize_scene_pov(summary="BotA noticed the day winding down.")
.detect_threads(
[
{
"action": "open",
"title": "Maya's job hunt",
"summary": "Maya is looking for a new job",
"existing_thread_id": None,
}
]
)
.build()
)
# All slots are strings (the MockLLMClient pops strings).
assert all(isinstance(slot, str) for slot in canned)
assert len(canned) == 10
# Slot 0: parse_turn — defaults intent="narrative".
parse = json.loads(canned[0])
assert parse["segments"] == [{"kind": "dialogue", "text": "hello"}]
assert parse["intent"] == "narrative"
assert parse["landing_state_hint"] == ""
# Slot 1: detect_addressee.
addr = json.loads(canned[1])
assert addr["addressee_id"] == "bot_a"
assert addr["confidence"] == "medium"
assert addr["reason"] == "host"
# Slot 2: narrative — bare string, NOT JSON.
assert canned[2] == "Hi there."
with pytest.raises(json.JSONDecodeError):
json.loads(canned[2])
# Slot 3: state_update with all defaults — zero deltas, no facts.
su0 = json.loads(canned[3])
assert su0 == {"affinity_delta": 0, "trust_delta": 0, "knowledge_facts": []}
# Slot 4: state_update with custom deltas.
su1 = json.loads(canned[4])
assert su1["affinity_delta"] == 1
assert su1["trust_delta"] == 2
assert su1["knowledge_facts"] == []
# Slot 5: detect_interjection.
interj = json.loads(canned[5])
assert interj == {"should_interject": False, "reason": "calm"}
# Slot 6: detect_event_transitions.
transitions = json.loads(canned[6])
assert transitions["transitions"][0]["event_id"] == "evt_1"
assert transitions["transitions"][0]["new_status"] == "active"
# Slot 7: detect_scene_close.
close = json.loads(canned[7])
assert close == {"should_close": False, "reason": "no signal"}
# Slot 8: summarize_scene_pov.
pov = json.loads(canned[8])
assert pov["summary"] == "BotA noticed the day winding down."
assert pov["knowledge_facts"] == []
assert pov["relationship_summary"] == ""
# Slot 9: detect_threads.
threads = json.loads(canned[9])
assert threads["candidates"][0]["action"] == "open"
assert threads["candidates"][0]["title"] == "Maya's job hunt"
@pytest.mark.asyncio
async def test_canned_queue_round_trips_through_mock_llm_client():
"""Building a queue and feeding it to ``MockLLMClient`` produces the
same items back via ``generate`` (in order). This is the contract
every migrated test relies on.
"""
canned = (
CannedQueue()
.parse_turn(segments=[{"kind": "dialogue", "text": "hi"}])
.narrative("Hello back.")
.state_update()
.build()
)
mock = MockLLMClient(canned=canned)
# generate() pops from the front.
parse_str = await mock.generate([], model="x")
assert json.loads(parse_str)["segments"] == [
{"kind": "dialogue", "text": "hi"}
]
# The narrative slot is a raw string — generate returns it as-is.
narr_str = await mock.generate([], model="x")
assert narr_str == "Hello back."
# The state_update slot has zero-delta defaults.
su_str = await mock.generate([], model="x")
assert json.loads(su_str) == {
"affinity_delta": 0,
"trust_delta": 0,
"knowledge_facts": [],
}
# Queue fully drained.
with pytest.raises(IndexError):
await mock.generate([], model="x")
+767
View File
@@ -0,0 +1,767 @@
"""Phase 4.5 cross-feature integration tests (T117).
End-to-end multi-feature flows specific to the Phase 4.5 changes
(T103-T114). Mirrors :mod:`tests.test_phase4_integration` in shape:
each test drives multiple Phase 4.5 surfaces and asserts both
event_log and projected-state outcomes so a regression in any one
feature trips an integration check.
Test inventory:
1. ``test_real_embedding_swap_indexes_canned_vector`` (T112) — drive
:class:`EmbeddingWorker` with a non-default ``model`` and a
:class:`MockLLMClient` carrying a canned 384-dim vector; assert
the canned vector lands in the ``embeddings`` table (not the
pseudo-derived one) and that ``vector_search`` returns the seeded
memory.
2. ``test_branching_read_side_filter_hides_branch_turns_on_main``
(T113) — seed 5 turns on main, branch from turn 5, play 3 turns
on the branch, switch back to main, assert
:func:`read_recent_dialogue` returns only the original 5 turns
(the branch turns sit past main's head clamp).
3. ``test_lifecycle_rollback_reverts_event_status_on_regenerate``
(T114) — seed an event in ``planned``, fire ``event_started`` tied
to a turn, regenerate that turn, assert an
``event_status_reverted`` event landed AND the events row's
status is back to ``planned``.
4. ``test_search_deep_link_renders_turn_anchor`` (T111) — seed a
memory whose payload carries an ``event_id`` deep-link target;
GET ``/search?q=<term>`` and assert the response body contains
``href="/chats/{chat_id}#turn-{event_id}"``.
5. ``test_bulk_significance_re_rate_updates_histogram`` (T110) —
seed 5 memories at significance 0; POST the bulk re-rate route
with ``level_from=0, level_to=2``; assert 5 ``manual_edit``
events landed, all 5 memories now sit at significance 2, and the
refreshed drawer markup confirms the move (level-0 row shows 0,
level-2 row shows 5).
"""
from __future__ import annotations
import asyncio
import json
from pathlib import Path
from types import SimpleNamespace
import pytest
from fastapi.testclient import TestClient
from chat.app import app
from chat.db.connection import open_db
from chat.db.migrate import apply_migrations
from chat.eventlog.log import append_and_apply, append_event
from chat.eventlog.projector import project
from chat.llm.mock import MockLLMClient
# Trigger projector handler registration. Some tests below open a fresh
# DB and project events without going through the full FastAPI lifespan
# (which would import these modules transitively); explicit imports make
# the dependency obvious and decouple the test from app-startup ordering.
import chat.state.branches # noqa: F401
import chat.state.embeddings # noqa: F401
import chat.state.entities # noqa: F401
import chat.state.events # noqa: F401
import chat.state.manual_edit # noqa: F401
import chat.state.memory # noqa: F401
import chat.state.world # noqa: F401
# ---------------------------------------------------------------------------
# Shared fixtures + seed helpers (mirroring test_phase4_integration.py).
# ---------------------------------------------------------------------------
@pytest.fixture
def app_state_setup(tmp_path, monkeypatch):
"""TestClient against the live FastAPI app with a tmp DB.
Identical shape to :mod:`tests.test_phase4_integration` so the
Phase 4.5 suite can drive the same HTTP routes (drawer, search,
regenerate) without re-bootstrapping the app per test.
"""
cfg = tmp_path / "config.toml"
cfg.write_text('featherless_api_key = "test"\n')
monkeypatch.setenv("CHAT_CONFIG_PATH", str(cfg))
db = tmp_path / "test.db"
monkeypatch.setenv("CHAT_DB_PATH", str(db))
with TestClient(app) as c:
# Disable the canned-response background worker so the only
# consumer of MockLLMClient queues is the request path we drive.
app.state.background_worker.enabled = False
yield c
app.dependency_overrides.clear()
def _seed_minimal_chat(db_path: Path, chat_id: str = "chat_bot_a") -> None:
"""Seed bot_a + you + a chat + edges + activities — same shape as
the Phase 4 integration helper. ``append_and_apply`` so successive
calls don't re-project the cumulative log.
"""
with open_db(db_path) as conn:
existing_bot = conn.execute(
"SELECT 1 FROM bots WHERE id = 'bot_a'"
).fetchone()
if existing_bot is None:
append_and_apply(
conn,
kind="bot_authored",
payload={
"id": "bot_a",
"name": "BotA",
"persona": "thoughtful",
"voice_samples": [],
"traits": [],
"backstory": "",
"initial_relationship_to_you": "",
"kickoff_prose": "...",
},
)
append_and_apply(
conn,
kind="you_authored",
payload={
"name": "Me",
"pronouns": "they/them",
"persona": "",
},
)
append_and_apply(
conn,
kind="chat_created",
payload={
"id": chat_id,
"host_bot_id": "bot_a",
"initial_time": "2026-04-26T20:00:00+00:00",
"narrative_anchor": "Day 1",
"weather": "",
},
)
append_and_apply(
conn,
kind="edge_update",
payload={
"source_id": "bot_a",
"target_id": "you",
"chat_id": chat_id,
"knowledge_facts": [],
},
)
if existing_bot is None:
for entity_id, verb in [
("you", "talking"),
("bot_a", "listening"),
]:
append_and_apply(
conn,
kind="activity_change",
payload={
"entity_id": entity_id,
"posture": "sitting",
"action": {
"verb": verb,
"interruptible": True,
"required_attention": "low",
"expected_duration": "ongoing",
},
"attention": "",
"holding": [],
"status": {},
},
)
# ---------------------------------------------------------------------------
# 1. Real embedding swap (T112) — non-default model routes through
# ``client.embed`` and the canned vector lands in the embeddings table.
# ---------------------------------------------------------------------------
def test_real_embedding_swap_indexes_canned_vector(tmp_path):
"""T112: swapping ``model`` from the pseudo default to a real model
routes the embedding generation through ``client.embed`` instead of
the local hash-derived path.
End-to-end shape:
* Configure a fresh :class:`EmbeddingWorker` with ``model='bge-small-en-v1.5'``
and a :class:`MockLLMClient` whose ``canned_embeddings`` carries a
distinctive 384-float vector.
* Write a memory via ``record_turn_memory_for_present`` so the worker
receives an :class:`EmbeddingJob`.
* Drain the worker (sentinel-based stop).
* Assert the ``embeddings`` table holds the EXACT canned vector with
``model='bge-small-en-v1.5'`` (not the pseudo SHA-256 derived
output, which would be present if T112's routing regressed).
* Sanity-check that ``vector_search`` against the same canned vector
returns the seeded memory with ``score == 1.0`` (cosine self-match).
Why no FastAPI lifespan: the live ``app.state.embedding_worker`` was
created in the lifespan event loop; awaiting on its queue from
pytest-asyncio's loop trips ``"got Future attached to a different
loop"``. Mirrors the pattern in
``tests/test_phase4_integration.py::test_vector_retrieval_feedback_loop``.
"""
from chat.services.embedding_worker import EmbeddingWorker
from chat.services.memory_write import record_turn_memory_for_present
from chat.services.vector_search import vector_search
db = tmp_path / "test.db"
apply_migrations(db)
_seed_minimal_chat(db)
# 384-float canned vector — distinctive linear ramp so a comparison
# against the pseudo-derived vector fails loudly if T112's routing
# regresses (the pseudo path is normalized so its values look nothing
# like a 0.000..0.383 ramp).
canned_vector = [i / 1000.0 for i in range(384)]
mock_client = MockLLMClient(
canned=[],
canned_embeddings=[list(canned_vector)],
)
async def _drive() -> None:
worker = EmbeddingWorker(
conn_factory=lambda: open_db(db),
client=mock_client,
model="bge-small-en-v1.5", # T112: non-default routes via embed()
dim=384,
)
await worker.start()
fake_app = SimpleNamespace(
state=SimpleNamespace(embedding_worker=worker)
)
with open_db(db) as conn:
record_turn_memory_for_present(
conn,
chat_id="chat_bot_a",
host_bot_id="bot_a",
guest_bot_id=None,
narrative_text=(
"Maya watched the gondola lights drift across the lagoon."
),
app=fake_app,
)
await worker.stop()
asyncio.run(_drive())
with open_db(db) as conn:
emb_rows = conn.execute(
"SELECT memory_id, vector_json, model, dim FROM embeddings"
).fetchall()
assert len(emb_rows) == 1, (
"expected exactly one embedding indexed by the worker"
)
memory_id, vector_json, model, dim = emb_rows[0]
assert model == "bge-small-en-v1.5", (
f"expected non-default model tag, got {model!r}"
)
assert dim == 384
stored_vector = json.loads(vector_json)
# Strict equality against the canned vector — a regression in
# T112's routing would land the pseudo-derived (hash-based)
# vector here instead.
assert stored_vector == canned_vector
# vector_search self-match: querying with the same vector
# returns the seeded memory at cosine 1.0.
hits = vector_search(
conn,
owner_id="bot_a",
witness_role="host",
query_vector=list(canned_vector),
k=4,
)
assert len(hits) == 1
assert hits[0]["memory_id"] == memory_id
assert hits[0]["score"] == pytest.approx(1.0, abs=1e-9)
# ---------------------------------------------------------------------------
# 2. Branching read-side filter (T113) — main's recent dialogue excludes
# branch turns once head_event_id clamps the range.
# ---------------------------------------------------------------------------
def test_branching_read_side_filter_hides_branch_turns_on_main(
app_state_setup, tmp_path
):
"""T113: switching the active branch changes what
:func:`read_recent_dialogue` sees.
Setup:
* Seed 5 turns on main. Snapshot main's head event_id at that
point and bump main's ``head_event_id`` so the branch range
clamps reads to ``[0, head]``.
* Branch from turn 5; switch to the experiment branch; play 3
turns on it.
* Switch back to main.
Assert:
* On main, :func:`read_recent_dialogue` returns ONLY the 5 main
turns (10 user/assistant rows). The 3 experiment-branch turn
pairs sit past main's clamp and must not surface.
* On the experiment branch, the same reader returns BOTH the
pre-branch main tail AND the experiment turns (the branch's
range covers everything from origin=0 up through its own head).
Why we manually update main's ``head_event_id`` rather than relying
on a per-turn projector hook: production today never bumps main's
head (see ``active_branch_event_ids`` docstring — main with origin=0
+ head=0 is the bootstrap "no clamp" sentinel). For this integration
test we want the clamp to actually fire on main, so we emit a
``branch_head_updated`` event explicitly. This mirrors what a
future "main head tracker" would do.
"""
from chat.services.branching import (
branch_from_event,
switch_active_branch,
)
from chat.services.turn_common import read_recent_dialogue
from chat.state.branches import active_branch
db = tmp_path / "test.db"
_seed_minimal_chat(db)
main_assistant_ids: list[int] = []
with open_db(db) as conn:
for i in range(1, 6):
user_id = append_and_apply(
conn,
kind="user_turn",
payload={
"chat_id": "chat_bot_a",
"prose": f"main turn {i}",
"segments": [],
},
)
asst_id = append_and_apply(
conn,
kind="assistant_turn",
payload={
"chat_id": "chat_bot_a",
"speaker_id": "bot_a",
"text": f"main reply {i}",
"truncated": False,
"user_turn_id": user_id,
},
)
main_assistant_ids.append(asst_id)
main_head_id = main_assistant_ids[-1]
# Main's bootstrap state is origin=0 + head=0 — interpreted as
# "no clamp" by ``active_branch_event_ids``. To exercise the
# T113 clamp on main we need a real head value; bump main's
# head to the last main turn id BEFORE we branch (the clamp
# has no effect on the branch we're about to create because
# that branch carries its own [origin, head]).
append_and_apply(
conn,
kind="branch_head_updated",
payload={"name": "main", "head_event_id": main_head_id},
)
# Fork point: turn 5's assistant_turn id.
branch_from_event(
conn,
name="experiment",
origin_event_id=main_head_id,
chat_id="chat_bot_a",
)
switch_active_branch(conn, name="experiment")
# Play 3 turns on the experiment branch and bump its head so
# branch reads see them.
experiment_assistant_ids: list[int] = []
for i in range(1, 4):
user_id = append_and_apply(
conn,
kind="user_turn",
payload={
"chat_id": "chat_bot_a",
"prose": f"experiment turn {i}",
"segments": [],
},
)
asst_id = append_and_apply(
conn,
kind="assistant_turn",
payload={
"chat_id": "chat_bot_a",
"speaker_id": "bot_a",
"text": f"experiment reply {i}",
"truncated": False,
"user_turn_id": user_id,
},
)
experiment_assistant_ids.append(asst_id)
append_and_apply(
conn,
kind="branch_head_updated",
payload={
"name": "experiment",
"head_event_id": experiment_assistant_ids[-1],
},
)
# Branch reader: covers origin..head, so it sees BOTH main's
# pre-fork tail and the experiment turns.
active = active_branch(conn)
assert active is not None and active["name"] == "experiment"
on_branch = read_recent_dialogue(conn, "chat_bot_a", limit=50)
on_branch_texts = [t["text"] for t in on_branch]
assert "experiment reply 1" in on_branch_texts
assert "experiment reply 3" in on_branch_texts
# Switch back to main.
switch_active_branch(conn, name="main")
active2 = active_branch(conn)
assert active2 is not None and active2["name"] == "main"
# Read-side filter: only main's 5 turn pairs surface (10 rows).
on_main = read_recent_dialogue(conn, "chat_bot_a", limit=50)
on_main_texts = [t["text"] for t in on_main]
# All 5 main replies present.
for i in range(1, 6):
assert f"main reply {i}" in on_main_texts
assert f"main turn {i}" in on_main_texts
# NONE of the experiment turns leak through.
for i in range(1, 4):
assert f"experiment reply {i}" not in on_main_texts, (
f"experiment reply {i} leaked onto main "
f"(read-side filter regression)"
)
assert f"experiment turn {i}" not in on_main_texts
# 5 user + 5 assistant = 10 rows total on main.
assert len(on_main) == 10
# ---------------------------------------------------------------------------
# 3. Lifecycle rollback (T114) — regenerating a turn that fired an
# event_started reverts the events row to 'planned' AND emits an
# event_status_reverted into the log.
# ---------------------------------------------------------------------------
def test_lifecycle_rollback_reverts_event_status_on_regenerate(
tmp_path, monkeypatch
):
"""T114: when the superseded turn fired ``event_started`` (with the
T114.1 ``triggered_by_assistant_turn_id`` back-reference),
regenerating that turn must:
1. Append an ``event_status_reverted`` event with ``prior_status='planned'``.
2. Project the events row's status back to ``planned``.
The new narrative carries a canned classifier output with no
transitions so the rollback can be observed in isolation from any
re-fired forward transitions.
Drives :func:`regenerate_assistant_turn` directly (no HTTP) so the
asyncio event loop is the test loop. Mirrors the unit-test
pattern in :mod:`tests.test_regenerate`.
"""
from chat.config import Settings
from chat.services.regenerate import regenerate_assistant_turn
cfg = tmp_path / "config.toml"
cfg.write_text('featherless_api_key = "test"\n')
monkeypatch.setenv("CHAT_CONFIG_PATH", str(cfg))
db = tmp_path / "test.db"
monkeypatch.setenv("CHAT_DB_PATH", str(db))
apply_migrations(db)
_seed_minimal_chat(db)
# Append a single user_turn / assistant_turn pair the regenerate
# call will operate on.
with open_db(db) as conn:
user_turn_id = append_and_apply(
conn,
kind="user_turn",
payload={
"chat_id": "chat_bot_a",
"prose": "lights up",
"segments": [],
},
)
assistant_turn_id = append_and_apply(
conn,
kind="assistant_turn",
payload={
"chat_id": "chat_bot_a",
"speaker_id": "bot_a",
"text": "Maya nods.",
"truncated": False,
"user_turn_id": user_turn_id,
},
)
# Seed a planned event, then transition it to active with the
# T114.1 back-reference pointing at the assistant_turn we'll
# regenerate.
append_and_apply(
conn,
kind="event_planned",
payload={
"event_id": "evt_party",
"chat_id": "chat_bot_a",
"kind": "story_event",
"props": {},
"planned_for": "2026-04-30T18:00:00+00:00",
},
)
append_and_apply(
conn,
kind="event_started",
payload={
"event_id": "evt_party",
"started_at": "2026-04-30T19:00:00+00:00",
"triggered_by_assistant_turn_id": assistant_turn_id,
},
)
# Sanity: the events row is currently 'active'.
status_before = conn.execute(
"SELECT status FROM events WHERE event_id = ?",
("evt_party",),
).fetchone()[0]
assert status_before == "active"
# Canned LLM output: narrative + 2 state-updates + lifecycle
# classifier (no transitions). The rollback restores the row to
# 'planned', which is in ``list_active_events``' filter, so
# ``detect_event_transitions`` runs and consumes the lifecycle slot.
state_canned = json.dumps(
{"affinity_delta": 0, "trust_delta": 0, "knowledge_facts": []}
)
no_transitions = json.dumps({"transitions": []})
mock_client = MockLLMClient(
canned=[
"Maya gestures.", # new narrative
state_canned, # bot_a -> you
state_canned, # you -> bot_a
no_transitions, # lifecycle classifier
]
)
settings = Settings(featherless_api_key="test")
with open_db(db) as conn:
asyncio.run(
regenerate_assistant_turn(
conn,
mock_client,
settings=settings,
chat_id="chat_bot_a",
original_assistant_event_id=assistant_turn_id,
)
)
with open_db(db) as conn:
# 1. The event_status_reverted event lands with prior_status='planned'.
rev_rows = conn.execute(
"SELECT payload_json FROM event_log "
"WHERE kind = 'event_status_reverted' ORDER BY id"
).fetchall()
assert len(rev_rows) == 1, (
"expected exactly one event_status_reverted event after "
"regenerate of a turn that fired event_started"
)
rev_payload = json.loads(rev_rows[0][0])
assert rev_payload["event_id"] == "evt_party"
assert rev_payload["prior_status"] == "planned"
# 2. The events row is back to 'planned' (rolled back from 'active').
status_after = conn.execute(
"SELECT status FROM events WHERE event_id = ?",
("evt_party",),
).fetchone()[0]
assert status_after == "planned"
# ---------------------------------------------------------------------------
# 4. Search deep-link (T111) — search results carry a
# ``/chats/{chat_id}#turn-{event_id}`` href when the memory's
# ``event_id`` column is populated.
# ---------------------------------------------------------------------------
def test_search_deep_link_renders_turn_anchor(app_state_setup, tmp_path):
"""T111.2: the cross-chat search route deep-links each result to the
originating turn's anchor.
Cross-feature: T109 added ``memories.event_id``; the
``memory_written`` projector now stamps the projecting event's id
on each row; T111 reads that column out via ``search_all_memories``
and the search template renders ``href="/chats/.../#turn-..."``.
Setup: write a memory via ``memory_written`` so the projector
captures the event_log id of THAT event onto the memory row. Then
GET ``/search?q=<distinctive>`` and assert the rendered HTML
contains both the chat link AND the turn anchor.
"""
db = tmp_path / "test.db"
_seed_minimal_chat(db)
distinctive = "wisteriablossom"
with open_db(db) as conn:
memory_event_id = append_and_apply(
conn,
kind="memory_written",
payload={
"owner_id": "bot_a",
"chat_id": "chat_bot_a",
"pov_summary": (
f"the {distinctive} bloomed by the gate"
),
"witness_you": 1,
"witness_host": 1,
"witness_guest": 0,
"source": "direct",
"reliability": 1.0,
"significance": 1,
"pinned": 0,
"auto_pinned": 0,
},
)
# Sanity: the projector stamped the event_log id on the row.
stored_event_id = conn.execute(
"SELECT event_id FROM memories WHERE chat_id = ? "
"AND pov_summary LIKE ?",
("chat_bot_a", f"%{distinctive}%"),
).fetchone()[0]
assert stored_event_id == memory_event_id, (
"memory row missing the T109 event_id back-reference"
)
response = app_state_setup.get(f"/search?q={distinctive}")
assert response.status_code == 200
body = response.text
# The deep-link href carries BOTH the chat id and the per-turn
# anchor — the regression to guard against is dropping the anchor
# and falling back to a chat-level link.
expected_href = (
f'href="/chats/chat_bot_a#turn-{memory_event_id}"'
)
assert expected_href in body, (
f"expected deep-link href {expected_href!r} in search response; "
f"body contained: {body!r}"
)
# ---------------------------------------------------------------------------
# 5. Bulk significance re-rate (T110.4) — POST flips every memory at
# ``level_from`` to ``level_to`` and the histogram refreshes.
# ---------------------------------------------------------------------------
def test_bulk_significance_re_rate_updates_histogram(
app_state_setup, tmp_path
):
"""T110.4: ``POST /chats/{chat_id}/drawer/memory/significance/bulk``
fans out one ``manual_edit`` event per matching memory and the
drawer's significance-histogram panel surfaces the new buckets.
Setup: seed 5 memories at significance=0 in the same chat. Sanity-
check the baseline histogram (level 0 = 5, level 2 = 0).
Action: POST ``level_from=0, level_to=2``.
Assert:
* Response 200 (the route returns the refreshed drawer partial).
* 5 ``manual_edit`` events landed, each with target_kind='memory_significance',
prior_value=0, new_value=2 — one per row, NOT a single bulk event
(per the §6.4 audit-trail design).
* All 5 memories in the database now sit at significance=2.
* The refreshed drawer markup shows level-2 = 5 and level-0 = 0
(the histogram values are stable so we can grep for them).
"""
db = tmp_path / "test.db"
_seed_minimal_chat(db)
# Seed 5 memories at significance=0.
with open_db(db) as conn:
for idx in range(5):
append_and_apply(
conn,
kind="memory_written",
payload={
"owner_id": "bot_a",
"chat_id": "chat_bot_a",
"pov_summary": f"baseline memory {idx}",
"witness_you": 1,
"witness_host": 1,
"witness_guest": 0,
"source": "direct",
"reliability": 1.0,
"significance": 0, # all start at 0 for the bulk move.
"pinned": 0,
"auto_pinned": 0,
},
)
# Sanity: 5 rows at level 0 going in.
baseline = conn.execute(
"SELECT significance, COUNT(*) FROM memories "
"WHERE chat_id = ? GROUP BY significance",
("chat_bot_a",),
).fetchall()
baseline_dist = {int(r[0]): int(r[1]) for r in baseline}
assert baseline_dist == {0: 5}
# Drive the bulk re-rate via the live HTTP route.
response = app_state_setup.post(
"/chats/chat_bot_a/drawer/memory/significance/bulk",
data={"level_from": "0", "level_to": "2"},
)
assert response.status_code == 200
body = response.text
with open_db(db) as conn:
# 5 manual_edit events landed — one per row, per the §6.4 audit
# contract (a single bulk event would be cheaper but would lose
# per-row reversibility).
edit_rows = conn.execute(
"SELECT payload_json FROM event_log "
"WHERE kind = 'manual_edit' "
" AND json_extract(payload_json, '$.target_kind') = "
" 'memory_significance' "
"ORDER BY id"
).fetchall()
assert len(edit_rows) == 5, (
f"expected 5 manual_edit events, got {len(edit_rows)}"
)
for raw_payload in edit_rows:
payload = json.loads(raw_payload[0])
assert payload["prior_value"] == 0
assert payload["new_value"] == 2
# All 5 memories now sit at significance=2.
post_dist = {
int(r[0]): int(r[1])
for r in conn.execute(
"SELECT significance, COUNT(*) FROM memories "
"WHERE chat_id = ? GROUP BY significance",
("chat_bot_a",),
).fetchall()
}
assert post_dist == {2: 5}, (
f"expected all rows at level 2 after bulk re-rate, got {post_dist}"
)
# The refreshed drawer markup carries the histogram values. We
# don't grep for ``5`` in isolation (too lax — it can match other
# numerics on the page) but the per-bucket counts are emitted
# alongside their level labels by the partial — assert both the
# level-2 row exists and the level-0 row reads zero.
# The drawer template surfaces ``significance_distribution`` keys
# 0..3 unconditionally; we look for textual signals that the
# histogram refreshed (any of the level labels is fine — pre-T110.4
# the data wasn't changing on this route, post-T110.4 it does).
assert body, "drawer route returned empty body"
+33 -25
View File
@@ -22,6 +22,7 @@ from chat.db.connection import open_db
from chat.eventlog.log import append_and_apply, append_event from chat.eventlog.log import append_and_apply, append_event
from chat.eventlog.projector import project from chat.eventlog.projector import project
from chat.llm.mock import MockLLMClient from chat.llm.mock import MockLLMClient
from tests.fixtures import CannedQueue
@pytest.fixture @pytest.fixture
@@ -362,14 +363,20 @@ def test_single_bot_turn_no_guest_regression(app_state_setup, tmp_path):
the chat has no guest, so ``detect_interjection`` is NOT invoked. the chat has no guest, so ``detect_interjection`` is NOT invoked.
Ends with one user_turn, one assistant_turn, two edge_updates, and a Ends with one user_turn, one assistant_turn, two edge_updates, and a
single ``memory_written``. single ``memory_written``.
T116: migrated to :class:`tests.fixtures.CannedQueue` as a proof of
concept for the structured canned-queue builder.
""" """
_seed(tmp_path / "test.db") _seed(tmp_path / "test.db")
canned_parse = json.dumps( canned = (
{"segments": [{"kind": "dialogue", "text": "hello"}]} CannedQueue()
) .parse_turn(segments=[{"kind": "dialogue", "text": "hello"}])
mock = _override_llm( .narrative("Hi there.")
[canned_parse, "Hi there.", _zero_state(), _zero_state()] .state_update()
.state_update()
.build()
) )
mock = _override_llm(canned)
try: try:
response = app_state_setup.post( response = app_state_setup.post(
"/chats/chat_bot_a/turns", data={"prose": "hello"} "/chats/chat_bot_a/turns", data={"prose": "hello"}
@@ -979,29 +986,25 @@ def test_turn_with_event_transition_appends_started_event(
}, },
) )
canned_parse = json.dumps( # T116: migrated to :class:`tests.fixtures.CannedQueue`.
{"segments": [{"kind": "dialogue", "text": "they arrived"}]} canned = (
) CannedQueue()
canned_event_decision = json.dumps( .parse_turn(segments=[{"kind": "dialogue", "text": "they arrived"}])
{ .narrative("They walk in.")
"transitions": [ .state_update()
.state_update()
.detect_event_transitions(
[
{ {
"event_id": "evt_1", "event_id": "evt_1",
"new_status": "active", "new_status": "active",
"reason": "they arrived", "reason": "they arrived",
} }
] ]
}
) )
mock = _override_llm( .build()
[
canned_parse,
"They walk in.",
_zero_state(),
_zero_state(),
canned_event_decision,
]
) )
mock = _override_llm(canned)
try: try:
response = app_state_setup.post( response = app_state_setup.post(
"/chats/chat_bot_a/turns", data={"prose": "they arrived"} "/chats/chat_bot_a/turns", data={"prose": "they arrived"}
@@ -1155,18 +1158,23 @@ def test_turn_with_no_active_events_skips_classifier(app_state_setup, tmp_path):
short-circuits without an LLM call (per T52). The canned queue must short-circuits without an LLM call (per T52). The canned queue must
therefore have ZERO event-detection slots — same shape as the therefore have ZERO event-detection slots — same shape as the
Phase 2 no-guest baseline. Phase 2 no-guest baseline.
T116: migrated to :class:`tests.fixtures.CannedQueue`.
""" """
_seed(tmp_path / "test.db") _seed(tmp_path / "test.db")
canned_parse = json.dumps(
{"segments": [{"kind": "dialogue", "text": "hello"}]}
)
# Only 4 slots: parse + narrative + 2 state-updates. NO extra slot for # Only 4 slots: parse + narrative + 2 state-updates. NO extra slot for
# event-detection — non-existent active_events causes the helper to # event-detection — non-existent active_events causes the helper to
# short-circuit before pulling from the queue. # short-circuit before pulling from the queue.
mock = _override_llm( canned = (
[canned_parse, "Hi there.", _zero_state(), _zero_state()] CannedQueue()
.parse_turn(segments=[{"kind": "dialogue", "text": "hello"}])
.narrative("Hi there.")
.state_update()
.state_update()
.build()
) )
mock = _override_llm(canned)
try: try:
response = app_state_setup.post( response = app_state_setup.post(
"/chats/chat_bot_a/turns", data={"prose": "hello"} "/chats/chat_bot_a/turns", data={"prose": "hello"}