316153dc98
DECISION: a pager whose only two controls are permanently disabled is noise, so
the conventional behaviour ships — the bar is hidden when the result set is a
single page. NotificationReport, which raised the finding, opts in.
RATIONALE for opt-in rather than default-on. OffsetPager is shared, and its
summary span ("Page N of Y · T total") doubles as the ONLY total-count readout
on ConfigurationAuditLog — auto-hiding there would silently delete the result
count for every query returning under a page, and the existing Playwright
fixture asserts "3 total" on exactly such a query. So the behaviour lives in the
shared component (reusable for the next consumer) behind HideWhenSinglePage,
default false, which keeps every current consumer byte-identical.
The guard fires only when single-page-ness is POSITIVELY established:
PageCount <= 1 AND Page <= 1 AND !HasNextPage. A null TotalCount means the host
cannot count, so the bar renders — the controls never vanish while a further
page still exists.
NotificationReport's own Playwright pagination test seeds 51 rows (2 pages) and
is unaffected. 5 new bUnit tests cover hide-on-single-page, hide-on-empty,
show-on-multi-page, show-when-TotalCount-unknown, and the default-off path.
189 lines
6.9 KiB
C#
189 lines
6.9 KiB
C#
using Bunit;
|
|
using Microsoft.AspNetCore.Components;
|
|
using ZB.MOM.WW.ScadaBridge.CentralUI.Components.Shared;
|
|
|
|
namespace ZB.MOM.WW.ScadaBridge.CentralUI.Tests.Shared;
|
|
|
|
/// <summary>
|
|
/// bUnit tests for the <see cref="OffsetPager"/> reusable pagination bar (T35a).
|
|
/// The component is purely presentational — it emits <c>PageChanged</c> callbacks
|
|
/// and renders disabled states; the host page owns page-number and query state.
|
|
/// </summary>
|
|
public class OffsetPagerTests : BunitContext
|
|
{
|
|
// ── PrevDisabled_OnFirstPage ──────────────────────────────────────────────
|
|
|
|
[Fact]
|
|
public void PrevDisabled_OnFirstPage()
|
|
{
|
|
var cut = Render<OffsetPager>(ps => ps
|
|
.Add(p => p.Page, 1)
|
|
.Add(p => p.HasNextPage, true));
|
|
|
|
var prev = cut.Find("[data-test='pager-prev']");
|
|
|
|
Assert.NotNull(prev.GetAttribute("disabled"));
|
|
}
|
|
|
|
// ── NextDisabled_WhenNoNextPage ───────────────────────────────────────────
|
|
|
|
[Fact]
|
|
public void NextDisabled_WhenNoNextPage()
|
|
{
|
|
var cut = Render<OffsetPager>(ps => ps
|
|
.Add(p => p.Page, 3)
|
|
.Add(p => p.HasNextPage, false));
|
|
|
|
var next = cut.Find("[data-test='pager-next']");
|
|
|
|
Assert.NotNull(next.GetAttribute("disabled"));
|
|
}
|
|
|
|
// ── Next_Click_EmitsPagePlusOne ───────────────────────────────────────────
|
|
|
|
[Fact]
|
|
public void Next_Click_EmitsPagePlusOne()
|
|
{
|
|
int? emitted = null;
|
|
var cut = Render<OffsetPager>(ps => ps
|
|
.Add(p => p.Page, 2)
|
|
.Add(p => p.HasNextPage, true)
|
|
.Add(p => p.PageChanged,
|
|
EventCallback.Factory.Create<int>(this, v => emitted = v)));
|
|
|
|
cut.Find("[data-test='pager-next']").Click();
|
|
|
|
Assert.Equal(3, emitted);
|
|
}
|
|
|
|
// ── Prev_Click_EmitsPageMinusOne ─────────────────────────────────────────
|
|
|
|
[Fact]
|
|
public void Prev_Click_EmitsPageMinusOne()
|
|
{
|
|
int? emitted = null;
|
|
var cut = Render<OffsetPager>(ps => ps
|
|
.Add(p => p.Page, 2)
|
|
.Add(p => p.HasNextPage, false)
|
|
.Add(p => p.PageChanged,
|
|
EventCallback.Factory.Create<int>(this, v => emitted = v)));
|
|
|
|
cut.Find("[data-test='pager-prev']").Click();
|
|
|
|
Assert.Equal(1, emitted);
|
|
}
|
|
|
|
// ── Summary_RendersPageOfTotal ────────────────────────────────────────────
|
|
|
|
[Fact]
|
|
public void Summary_RendersPageOfTotal()
|
|
{
|
|
var cut = Render<OffsetPager>(ps => ps
|
|
.Add(p => p.Page, 2)
|
|
.Add(p => p.PageSize, 50)
|
|
.Add(p => p.TotalCount, 230)
|
|
.Add(p => p.HasNextPage, true));
|
|
|
|
var summary = cut.Find("[data-test='pager-summary']");
|
|
|
|
Assert.Contains("Page 2 of 5", summary.TextContent);
|
|
Assert.Contains("230 total", summary.TextContent);
|
|
}
|
|
|
|
// ── HideWhenSinglePage_HidesBar_OnSinglePage ──────────────────────────────
|
|
|
|
[Fact]
|
|
public void HideWhenSinglePage_HidesBar_OnSinglePage()
|
|
{
|
|
var cut = Render<OffsetPager>(ps => ps
|
|
.Add(p => p.Page, 1)
|
|
.Add(p => p.PageSize, 50)
|
|
.Add(p => p.TotalCount, 12)
|
|
.Add(p => p.HasNextPage, false)
|
|
.Add(p => p.HideWhenSinglePage, true));
|
|
|
|
Assert.Empty(cut.FindAll("[data-test='pager-prev']"));
|
|
Assert.Empty(cut.FindAll("[data-test='pager-next']"));
|
|
Assert.Empty(cut.FindAll("[data-test='pager-summary']"));
|
|
}
|
|
|
|
// ── HideWhenSinglePage_HidesBar_OnEmptyResult ─────────────────────────────
|
|
|
|
[Fact]
|
|
public void HideWhenSinglePage_HidesBar_OnEmptyResult()
|
|
{
|
|
var cut = Render<OffsetPager>(ps => ps
|
|
.Add(p => p.Page, 1)
|
|
.Add(p => p.PageSize, 50)
|
|
.Add(p => p.TotalCount, 0)
|
|
.Add(p => p.HasNextPage, false)
|
|
.Add(p => p.HideWhenSinglePage, true));
|
|
|
|
Assert.Empty(cut.FindAll("[data-test='pager-summary']"));
|
|
}
|
|
|
|
// ── HideWhenSinglePage_ShowsBar_WhenMultiplePages ─────────────────────────
|
|
|
|
[Fact]
|
|
public void HideWhenSinglePage_ShowsBar_WhenMultiplePages()
|
|
{
|
|
var cut = Render<OffsetPager>(ps => ps
|
|
.Add(p => p.Page, 1)
|
|
.Add(p => p.PageSize, 50)
|
|
.Add(p => p.TotalCount, 120)
|
|
.Add(p => p.HasNextPage, true)
|
|
.Add(p => p.HideWhenSinglePage, true));
|
|
|
|
Assert.Contains("Page 1 of 3", cut.Find("[data-test='pager-summary']").TextContent);
|
|
}
|
|
|
|
// ── HideWhenSinglePage_ShowsBar_WhenTotalCountUnknown ─────────────────────
|
|
// TotalCount is null (the host cannot count), so single-page-ness is not
|
|
// provable — the bar must stay so the user can still reach a further page.
|
|
|
|
[Fact]
|
|
public void HideWhenSinglePage_ShowsBar_WhenTotalCountUnknown()
|
|
{
|
|
var cut = Render<OffsetPager>(ps => ps
|
|
.Add(p => p.Page, 1)
|
|
.Add(p => p.PageSize, 50)
|
|
.Add(p => p.HasNextPage, false)
|
|
.Add(p => p.HideWhenSinglePage, true));
|
|
|
|
Assert.NotNull(cut.Find("[data-test='pager-summary']"));
|
|
}
|
|
|
|
// ── HideWhenSinglePage_Off_KeepsBarVisible_OnSinglePage ───────────────────
|
|
// Default (opt-out) behaviour: consumers that use the summary as their only
|
|
// "N total" readout keep the bar on a single page.
|
|
|
|
[Fact]
|
|
public void HideWhenSinglePage_Off_KeepsBarVisible_OnSinglePage()
|
|
{
|
|
var cut = Render<OffsetPager>(ps => ps
|
|
.Add(p => p.Page, 1)
|
|
.Add(p => p.PageSize, 50)
|
|
.Add(p => p.TotalCount, 3)
|
|
.Add(p => p.HasNextPage, false));
|
|
|
|
Assert.Contains("3 total", cut.Find("[data-test='pager-summary']").TextContent);
|
|
}
|
|
|
|
// ── BothDisabled_WhenDisabled ─────────────────────────────────────────────
|
|
|
|
[Fact]
|
|
public void BothDisabled_WhenDisabled()
|
|
{
|
|
var cut = Render<OffsetPager>(ps => ps
|
|
.Add(p => p.Page, 3)
|
|
.Add(p => p.HasNextPage, true)
|
|
.Add(p => p.Disabled, true));
|
|
|
|
var prev = cut.Find("[data-test='pager-prev']");
|
|
var next = cut.Find("[data-test='pager-next']");
|
|
|
|
Assert.NotNull(prev.GetAttribute("disabled"));
|
|
Assert.NotNull(next.GetAttribute("disabled"));
|
|
}
|
|
}
|