Joseph Doherty
635461c0fd
Perf re-baseline (HotPathLatencyTests): empirical p95 on Apple M-series Release build: 4KB DetailsJson slow path ≈14 µs, small-DetailsJson no-redactors ≈2 µs, true no-op fast path ≈0 µs. Thresholds updated: 200 µs / 30 µs / 5 µs (≈15× headroom for contested CI runners). Old thresholds (50 µs / 10 µs) were set for the pre-C3 typed-field path; canonical JSON parse+rewrite is empirically faster. Adds a third test (Filter_Apply_NoDetailsJson_FastPath) that asserts same-instance return on the DetailsJson-null + within-cap fast path. Env-var overrides retained. CollapseAuditLogToCanonicalMigrationTests (new): three MSSQL-gated [SkippableFact] tests verifying Action/Category/Outcome projection, NULL Actor, DetailsJson codec round-trip, and all six persisted computed columns (Kind/Status/SourceSiteId/ ExecutionId/ParentExecutionId) for ApiOutbound, InboundAuthFailure, and Failed- status rows. AddAuditLogTableMigrationTests: rename CreatesFiveNamedIndexes → CreatesNineNamedIndexes; expand coverage from 5 original indexes to all 9 named non-clustered indexes present after CollapseAuditLogToCanonical (adds IX_AuditLog_Execution, IX_AuditLog_ParentExecution, IX_AuditLog_Node_Occurred, UX_AuditLog_EventId). Dead-cref cleanup: zero references to the deleted IAuditPayloadFilter / DefaultAuditPayloadFilter / SafeDefaultAuditPayloadFilter types remain in any .cs file (source or test). 26 occurrences across 13 files replaced with correct references to IAuditRedactor / ScadaBridgeAuditRedactor / SafeDefaultAuditRedactor or reworded as plain prose. Residual sweep: no unused transitional code found beyond the acknowledged "C3 transitional shim" comments on IngestedAtUtc stamping (active code, not dead).
50 lines
1.8 KiB
C#
50 lines
1.8 KiB
C#
using NSubstitute;
|
|
using ZB.MOM.WW.ScadaBridge.AuditLog.Site;
|
|
using ZB.MOM.WW.ScadaBridge.HealthMonitoring;
|
|
|
|
namespace ZB.MOM.WW.ScadaBridge.AuditLog.Tests.Site;
|
|
|
|
/// <summary>
|
|
/// Bundle C (M5-T7) — the <see cref="HealthMetricsAuditRedactionFailureCounter"/>
|
|
/// adapter is the production binding for
|
|
/// <see cref="ZB.MOM.WW.ScadaBridge.AuditLog.Payload.IAuditRedactionFailureCounter"/> on
|
|
/// site nodes; it forwards every <see cref="ZB.MOM.WW.ScadaBridge.AuditLog.Redaction.ScadaBridgeAuditRedactor"/>
|
|
/// redactor over-redaction event into the shared
|
|
/// <see cref="ISiteHealthCollector"/> so the site health report surfaces the
|
|
/// count as <c>AuditRedactionFailure</c>. Mirrors the M2 Bundle G
|
|
/// HealthMetricsAuditWriteFailureCounter shape one-for-one.
|
|
/// </summary>
|
|
public class HealthMetricsAuditRedactionFailureCounterTests
|
|
{
|
|
[Fact]
|
|
public void Increment_Routes_To_Collector_IncrementAuditRedactionFailure()
|
|
{
|
|
var collector = Substitute.For<ISiteHealthCollector>();
|
|
var counter = new HealthMetricsAuditRedactionFailureCounter(collector);
|
|
|
|
counter.Increment();
|
|
|
|
collector.Received(1).IncrementAuditRedactionFailure();
|
|
}
|
|
|
|
[Fact]
|
|
public void Increment_Multiple_Calls_Route_To_Collector_Each_Time()
|
|
{
|
|
var collector = Substitute.For<ISiteHealthCollector>();
|
|
var counter = new HealthMetricsAuditRedactionFailureCounter(collector);
|
|
|
|
counter.Increment();
|
|
counter.Increment();
|
|
counter.Increment();
|
|
|
|
collector.Received(3).IncrementAuditRedactionFailure();
|
|
}
|
|
|
|
[Fact]
|
|
public void Construction_With_Null_Collector_Throws_ArgumentNullException()
|
|
{
|
|
Assert.Throws<ArgumentNullException>(
|
|
() => new HealthMetricsAuditRedactionFailureCounter(null!));
|
|
}
|
|
}
|