Joseph Doherty
7b0b9c7365
Solution + 23 src projects + 26 test projects renamed; folders, csproj, namespaces, and ScadaLinkDbContext/ScadaBridgeDbContext class updated. ActorSystem "scadalink" → "scadabridge", Akka seed-node URLs migrated. SQL roles/logins, LDAP domains, CLI command name, and CLI config dir (~/.scadalink → ~/.scadabridge) also renamed. Build green; 5 Host.Tests fail awaiting SQL login rename in next commit. Pre-existing StaleTagMonitor timing flakes unchanged. Rename script committed at tools/rename-to-scadabridge.sh.
1.9 KiB
1.9 KiB
Code Review —
| Field | Value |
|---|---|
| Module | src/ZB.MOM.WW.ScadaBridge.<Module> |
| Design doc | docs/requirements/Component-<Name>.md |
| Status | Not yet reviewed | In progress | Reviewed |
| Last reviewed | YYYY-MM-DD |
| Reviewer | |
| Commit reviewed | <short SHA> |
| Open findings | 0 |
Summary
One short paragraph: overall health of the module, themes across findings, and anything notable that is not a finding.
Checklist coverage
Confirm every category was examined. Record "No issues found" where applicable.
| # | Category | Examined | Notes |
|---|---|---|---|
| 1 | Correctness & logic bugs | ☐ | |
| 2 | Akka.NET conventions | ☐ | |
| 3 | Concurrency & thread safety | ☐ | |
| 4 | Error handling & resilience | ☐ | |
| 5 | Security | ☐ | |
| 6 | Performance & resource management | ☐ | |
| 7 | Design-document adherence | ☐ | |
| 8 | Code organization & conventions | ☐ | |
| 9 | Testing coverage | ☐ | |
| 10 | Documentation & comments | ☐ |
Findings
-001 —
| Severity | Critical | High | Medium | Low |
| Category | <one of the 10 checklist categories> |
| Status | Open | In Progress | Resolved | Won't Fix | Deferred |
| Location | src/ZB.MOM.WW.ScadaBridge.<Module>/<File>.cs:<line> |
Description
What is wrong and why it matters.
Recommendation
Concrete suggested fix.
Resolution
Unresolved.