ScadaBridge/tests/ScadaLink.ClusterInfrastructure.Tests/ServiceCollectionExtensionsTests.cs

using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Options;

namespace ScadaLink.ClusterInfrastructure.Tests;

/// <summary>
/// CI-002: Tests that <see cref="ServiceCollectionExtensions.AddClusterInfrastructure"/>
/// does real work rather than silently returning success — it must register
/// the <see cref="ClusterOptionsValidator"/> so misconfiguration fails fast.
/// (The companion actor-registration test was removed alongside the deleted
/// `AddClusterInfrastructureActors` extension method — see ClusterInfra-014.)
/// </summary>
public class ServiceCollectionExtensionsTests
{
    [Fact]
    public void AddClusterInfrastructure_RegistersOptionsValidator()
    {
        var services = new ServiceCollection();

        services.AddClusterInfrastructure();

        var validators = services
            .Where(d => d.ServiceType == typeof(IValidateOptions<ClusterOptions>))
            .ToList();
        Assert.NotEmpty(validators);

        using var provider = services.BuildServiceProvider();
        var validator = provider.GetService<IValidateOptions<ClusterOptions>>();
        Assert.IsType<ClusterOptionsValidator>(validator);
    }

    [Fact]
    public void AddClusterInfrastructure_ValidatorRejectsBadOptionsAtResolution()
    {
        var services = new ServiceCollection();
        services.AddClusterInfrastructure();
        // A MinNrOfMembers of 2 blocks the cluster singleton after failover.
        services.Configure<ClusterOptions>(o =>
        {
            o.SeedNodes = new List<string> { "akka.tcp://scadalink@node1:8081" };
            o.MinNrOfMembers = 2;
        });

        using var provider = services.BuildServiceProvider();

        var ex = Assert.Throws<OptionsValidationException>(
            () => provider.GetRequiredService<IOptions<ClusterOptions>>().Value);
        Assert.Contains("MinNrOfMembers", ex.Message);
    }

    // ClusterInfra-014: `AddClusterInfrastructureActors_ThrowsRatherThanSilentlySucceeding`
    // was removed alongside the now-deleted `AddClusterInfrastructureActors`
    // extension method. The Akka.NET actor wiring legitimately lives in
    // `ScadaLink.Host` (AkkaHostedService) per the
    // Component-ClusterInfrastructure.md "Implementation Note — Code Placement"
    // section; this project no longer exposes an actor-registration extension.
}