Joseph Doherty
635461c0fd
Perf re-baseline (HotPathLatencyTests): empirical p95 on Apple M-series Release build: 4KB DetailsJson slow path ≈14 µs, small-DetailsJson no-redactors ≈2 µs, true no-op fast path ≈0 µs. Thresholds updated: 200 µs / 30 µs / 5 µs (≈15× headroom for contested CI runners). Old thresholds (50 µs / 10 µs) were set for the pre-C3 typed-field path; canonical JSON parse+rewrite is empirically faster. Adds a third test (Filter_Apply_NoDetailsJson_FastPath) that asserts same-instance return on the DetailsJson-null + within-cap fast path. Env-var overrides retained. CollapseAuditLogToCanonicalMigrationTests (new): three MSSQL-gated [SkippableFact] tests verifying Action/Category/Outcome projection, NULL Actor, DetailsJson codec round-trip, and all six persisted computed columns (Kind/Status/SourceSiteId/ ExecutionId/ParentExecutionId) for ApiOutbound, InboundAuthFailure, and Failed- status rows. AddAuditLogTableMigrationTests: rename CreatesFiveNamedIndexes → CreatesNineNamedIndexes; expand coverage from 5 original indexes to all 9 named non-clustered indexes present after CollapseAuditLogToCanonical (adds IX_AuditLog_Execution, IX_AuditLog_ParentExecution, IX_AuditLog_Node_Occurred, UX_AuditLog_EventId). Dead-cref cleanup: zero references to the deleted IAuditPayloadFilter / DefaultAuditPayloadFilter / SafeDefaultAuditPayloadFilter types remain in any .cs file (source or test). 26 occurrences across 13 files replaced with correct references to IAuditRedactor / ScadaBridgeAuditRedactor / SafeDefaultAuditRedactor or reworded as plain prose. Residual sweep: no unused transitional code found beyond the acknowledged "C3 transitional shim" comments on IngestedAtUtc stamping (active code, not dead).
62 lines
3.1 KiB
C#
62 lines
3.1 KiB
C#
using ZB.MOM.WW.ScadaBridge.AuditLog.Payload;
|
|
|
|
namespace ZB.MOM.WW.ScadaBridge.AuditLog.Central;
|
|
|
|
/// <summary>
|
|
/// Audit Log (#23) M6 Bundle E (T9) — bridges
|
|
/// <see cref="IAuditRedactionFailureCounter"/> (incremented by
|
|
/// <see cref="ZB.MOM.WW.ScadaBridge.AuditLog.Redaction.ScadaBridgeAuditRedactor"/> every time
|
|
/// a header / body / SQL parameter redactor stage throws and the redactor has
|
|
/// to over-redact the offending field) into <see cref="AuditCentralHealthSnapshot"/>
|
|
/// so the failure surfaces on the central health surface as
|
|
/// <c>AuditCentralHealthSnapshot.AuditRedactionFailure</c>.
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// <para>
|
|
/// <b>Site vs central.</b> M5 Bundle C wired the SITE-side bridge
|
|
/// (<see cref="ZB.MOM.WW.ScadaBridge.AuditLog.Site.HealthMetricsAuditRedactionFailureCounter"/>),
|
|
/// which routes increments into the site health report payload's
|
|
/// <c>AuditRedactionFailure</c> field. That handles redactor failures on the
|
|
/// site SQLite hot-path (FallbackAuditWriter). M6 Bundle E (T9) adds the
|
|
/// MIRROR bridge here so the same payload filter — when it runs on the
|
|
/// central <see cref="CentralAuditWriter"/> /
|
|
/// <see cref="AuditLogIngestActor"/> paths — surfaces its failures on the
|
|
/// central dashboard rather than disappearing into a NoOp.
|
|
/// </para>
|
|
/// <para>
|
|
/// <b>Registration shape.</b> Site composition roots call
|
|
/// <see cref="ServiceCollectionExtensions.AddAuditLogHealthMetricsBridge"/>,
|
|
/// which overrides the binding with the site bridge. Central composition
|
|
/// roots call <see cref="ServiceCollectionExtensions.AddAuditLogCentralMaintenance"/>,
|
|
/// which overrides with this central bridge. A node never wears both hats —
|
|
/// site and central are distinct host roles — so the two bridges never
|
|
/// fight over the same binding at runtime.
|
|
/// </para>
|
|
/// <para>
|
|
/// <b>Why not a thin wrapper around the snapshot directly?</b> The snapshot
|
|
/// itself <i>could</i> be the bound implementation (it already implements
|
|
/// <see cref="IAuditRedactionFailureCounter"/>), but a dedicated class makes
|
|
/// the central-vs-site asymmetry explicit at the DI boundary — readers of
|
|
/// <see cref="ServiceCollectionExtensions.AddAuditLogCentralMaintenance"/>
|
|
/// see "site → site bridge, central → central bridge", matching the
|
|
/// <see cref="ZB.MOM.WW.ScadaBridge.AuditLog.Site.HealthMetricsAuditRedactionFailureCounter"/>
|
|
/// shape one-for-one.
|
|
/// </para>
|
|
/// </remarks>
|
|
public sealed class CentralAuditRedactionFailureCounter : IAuditRedactionFailureCounter
|
|
{
|
|
private readonly AuditCentralHealthSnapshot _snapshot;
|
|
|
|
/// <summary>
|
|
/// Initializes a new <see cref="CentralAuditRedactionFailureCounter"/> backed by the supplied snapshot.
|
|
/// </summary>
|
|
/// <param name="snapshot">The central health snapshot that accumulates the redaction failure count.</param>
|
|
public CentralAuditRedactionFailureCounter(AuditCentralHealthSnapshot snapshot)
|
|
{
|
|
_snapshot = snapshot ?? throw new ArgumentNullException(nameof(snapshot));
|
|
}
|
|
|
|
/// <inheritdoc/>
|
|
public void Increment() => ((IAuditRedactionFailureCounter)_snapshot).Increment();
|
|
}
|