3edef09f51
Spec promised a per-script timeout but only the global ScriptExecutionTimeoutSeconds existed. Add nullable TemplateScript.ExecutionTimeoutSeconds threaded through EF + flattening (ResolvedScript) to ScriptExecutionActor/AlarmExecutionActor, which use perScript ?? global for the execution CTS. Includes the EF migration for the new column.
151 lines
6.2 KiB
C#
151 lines
6.2 KiB
C#
using ZB.MOM.WW.ScadaBridge.Commons.Entities.Templates;
|
|
|
|
namespace ZB.MOM.WW.ScadaBridge.TemplateEngine;
|
|
|
|
/// <summary>
|
|
/// Enforces locking rules for template member overrides.
|
|
///
|
|
/// Locking rules:
|
|
/// - Locked members cannot be overridden downstream (child templates or compositions).
|
|
/// - Any level can lock an unlocked member (intermediate locking).
|
|
/// - Once locked, a member stays locked — neither <see cref="TemplateAttribute.IsLocked"/>
|
|
/// nor <see cref="TemplateAttribute.LockedInDerived"/> may be cleared after it has
|
|
/// been set. The same one-way ratchet applies to alarms and scripts. This pins
|
|
/// the design intent so a base template cannot retroactively re-allow derived
|
|
/// overrides that were previously blocked (TemplateEngine-022).
|
|
///
|
|
/// Override granularity:
|
|
/// - Attributes: Value and Description overridable; DataType and DataSourceReference fixed.
|
|
/// - Alarms: Priority, TriggerConfiguration, Description, OnTriggerScript overridable; Name and TriggerType fixed.
|
|
/// - Scripts: Code, TriggerConfiguration, MinTimeBetweenRuns, ExecutionTimeoutSeconds, params/return overridable; Name fixed.
|
|
/// - Lock flag applies to the entire member (attribute/alarm/script).
|
|
/// </summary>
|
|
public static class LockEnforcer
|
|
{
|
|
/// <summary>
|
|
/// Validates that an attribute override does not violate lock or granularity rules.
|
|
/// </summary>
|
|
/// <param name="original">The parent template's attribute definition.</param>
|
|
/// <param name="proposed">The child template's proposed override.</param>
|
|
/// <returns>An error message string if a rule is violated; <c>null</c> if the override is permitted.</returns>
|
|
public static string? ValidateAttributeOverride(
|
|
TemplateAttribute original,
|
|
TemplateAttribute proposed)
|
|
{
|
|
if (original.IsLocked)
|
|
{
|
|
return $"Attribute '{original.Name}' is locked and cannot be overridden.";
|
|
}
|
|
|
|
// DataType is fixed — cannot change
|
|
if (proposed.DataType != original.DataType)
|
|
{
|
|
return $"Attribute '{original.Name}': DataType cannot be overridden (fixed).";
|
|
}
|
|
|
|
// DataSourceReference is fixed — cannot change
|
|
if (proposed.DataSourceReference != original.DataSourceReference)
|
|
{
|
|
return $"Attribute '{original.Name}': DataSourceReference cannot be overridden (fixed).";
|
|
}
|
|
|
|
return null;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Validates that an alarm override does not violate lock or granularity rules.
|
|
/// </summary>
|
|
/// <param name="original">The parent template's alarm definition.</param>
|
|
/// <param name="proposed">The child template's proposed override.</param>
|
|
/// <returns>An error message string if a rule is violated; <c>null</c> if the override is permitted.</returns>
|
|
public static string? ValidateAlarmOverride(
|
|
TemplateAlarm original,
|
|
TemplateAlarm proposed)
|
|
{
|
|
if (original.IsLocked)
|
|
{
|
|
return $"Alarm '{original.Name}' is locked and cannot be overridden.";
|
|
}
|
|
|
|
// Name is fixed
|
|
if (proposed.Name != original.Name)
|
|
{
|
|
return $"Alarm '{original.Name}': Name cannot be overridden (fixed).";
|
|
}
|
|
|
|
// TriggerType is fixed
|
|
if (proposed.TriggerType != original.TriggerType)
|
|
{
|
|
return $"Alarm '{original.Name}': TriggerType cannot be overridden (fixed).";
|
|
}
|
|
|
|
return null;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Validates that a script override does not violate lock or granularity rules.
|
|
/// </summary>
|
|
/// <param name="original">The parent template's script definition.</param>
|
|
/// <param name="proposed">The child template's proposed override.</param>
|
|
/// <returns>An error message string if a rule is violated; <c>null</c> if the override is permitted.</returns>
|
|
public static string? ValidateScriptOverride(
|
|
TemplateScript original,
|
|
TemplateScript proposed)
|
|
{
|
|
if (original.IsLocked)
|
|
{
|
|
return $"Script '{original.Name}' is locked and cannot be overridden.";
|
|
}
|
|
|
|
// Name is fixed
|
|
if (proposed.Name != original.Name)
|
|
{
|
|
return $"Script '{original.Name}': Name cannot be overridden (fixed).";
|
|
}
|
|
|
|
return null;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Validates that a lock flag change is legal.
|
|
/// Locking is allowed on unlocked members. Unlocking is never allowed.
|
|
/// </summary>
|
|
/// <param name="originalIsLocked">The current lock state of the member.</param>
|
|
/// <param name="proposedIsLocked">The proposed lock state.</param>
|
|
/// <param name="memberName">Name of the member being changed, for error messages.</param>
|
|
/// <returns>An error message if unlocking is attempted; <c>null</c> if the lock change is valid.</returns>
|
|
public static string? ValidateLockChange(bool originalIsLocked, bool proposedIsLocked, string memberName)
|
|
{
|
|
if (originalIsLocked && !proposedIsLocked)
|
|
{
|
|
return $"Member '{memberName}' is locked and cannot be unlocked.";
|
|
}
|
|
|
|
return null;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Validates that a <see cref="TemplateAttribute.LockedInDerived"/> (or alarm/script)
|
|
/// flag change is legal. <c>LockedInDerived</c> follows the same one-way ratchet
|
|
/// as <c>IsLocked</c> — once set on a base template, it cannot be cleared,
|
|
/// otherwise derived templates that were previously blocked from overriding the
|
|
/// field would become retroactively allowed (TemplateEngine-022).
|
|
/// </summary>
|
|
/// <param name="originalLockedInDerived">Current <c>LockedInDerived</c> state.</param>
|
|
/// <param name="proposedLockedInDerived">Proposed <c>LockedInDerived</c> state.</param>
|
|
/// <param name="memberName">Name of the member being changed, for error messages.</param>
|
|
/// <returns>An error message if the locked-in-derived flag is being cleared; <c>null</c> if the change is valid.</returns>
|
|
public static string? ValidateLockedInDerivedChange(
|
|
bool originalLockedInDerived,
|
|
bool proposedLockedInDerived,
|
|
string memberName)
|
|
{
|
|
if (originalLockedInDerived && !proposedLockedInDerived)
|
|
{
|
|
return $"Member '{memberName}' is locked-in-derived and that lock cannot be cleared.";
|
|
}
|
|
|
|
return null;
|
|
}
|
|
}
|