f2efeb37b7
Tasks 5 and 6 of the Phase 2 plan, committed together because their test
fallout is entangled — several fixtures construct both stores.
StoreAndForwardStorage and SiteStorageService now take ILocalDb. Connections
come from ILocalDb.CreateConnection(), which hands out an already-open,
pragma-configured connection carrying the zb_hlc_next() UDF the capture triggers
call; a raw connection would lack the UDF and every write to a replicated table
would fail closed. Deleted with the connection strings: S&F's
EnsureDatabaseDirectoryExists and its per-open busy_timeout pragma, and the site
service's BusyTimeoutFloorSeconds normalization — LocalDb owns all of it now.
DI: AddSiteRuntime's string overload is gone (nothing left to supply), so the
Host calls the no-arg form. ScadaBridge:Database:SiteDbPath and
StoreAndForwardOptions.SqliteDbPath survive only as the migrator's source
locations in Tasks 8/9.
Two things the plan did not anticipate, both worth reading:
1. FOUND A REAL LATENT DEFECT, from Phase 1, now fixed. The plan assumed
directory creation simply moved to LocalDb along with file ownership. It did
not: the LocalDb library never creates the parent directory, and
SqliteLocalDb opens the file eagerly in its constructor — so a missing
directory is a hard boot failure ("SQLite Error 14: unable to open database
file"), not a degraded start. The default site config points at the RELATIVE
path ./data/site-localdb.db, so any site node without a pre-existing data/
directory fails to boot. The docker rig escapes only because its volume mount
happens to create /app/data — a coincidence that would have hidden this until
a bare-metal or fresh deployment. This has been latent since Phase 1 made
LocalDb:Path required; deleting S&F's EnsureDatabaseDirectoryExists here
would have widened it. Re-established the guarantee at the layer that now
owns the path (SiteLocalDbDirectory.Ensure, called before AddZbLocalDb) and
pinned it with SiteLocalDbDirectoryTests. Non-vacuity is not assumed: two
tests written against the wrong assumption failed with exactly this
SQLite Error 14 before the fix existed.
2. Test fallout was ~7x the plan's estimate. The plan named "fixtures" in one
project; the constructor change actually reaches 40 files across 7 test
projects, and most used Mode=Memory;Cache=Shared — which LocalDb has no
equivalent for, so every one had to move to a real temp file. Rather than
copy the Phase 1 TestLocalDb fixture into 7 projects, added a shared
tests/ZB.MOM.WW.ScadaBridge.TestSupport library (not a test project) so the
WAL-sidecar cleanup and the "real, not stubbed" rationale live in one place.
Retargeted rather than deleted, in both directions: the S&F WAL test now asserts
against the LocalDb-backed store (WAL genuinely is LocalDb's job), while the
directory-creation test moved to Host.Tests (that guarantee is NOT LocalDb's).
SiteStorageServiceTests.Initialize_EnablesWalJournalMode got the same treatment.
DeploymentManagerMediumFindingsTests induced a persistence failure via an
unopenable path, which no longer reaches the assertion since the fixture now
throws first; it induces the same failure shape via an uninitialized store.
Verified: full solution build 0 warnings; SiteRuntime 532, Host 318,
AuditLog 355, ExternalSystemGateway 142, HealthMonitoring 97,
StoreAndForward 153 — 1597 passed, 0 failed.
Claude-Session: https://claude.ai/code/session_01BL2Vu1ESDQ9SCN4gVKkdts
151 lines
5.7 KiB
C#
151 lines
5.7 KiB
C#
using Akka.Actor;
|
|
using Akka.TestKit.Xunit2;
|
|
using Microsoft.Extensions.Logging.Abstractions;
|
|
using ZB.MOM.WW.ScadaBridge.Commons.Types.Flattening;
|
|
using ZB.MOM.WW.ScadaBridge.SiteRuntime.Actors;
|
|
using ZB.MOM.WW.ScadaBridge.SiteRuntime.Persistence;
|
|
using ZB.MOM.WW.ScadaBridge.SiteRuntime.Scripts;
|
|
using ZB.MOM.WW.ScadaBridge.TestSupport;
|
|
using System.Text.Json;
|
|
|
|
namespace ZB.MOM.WW.ScadaBridge.SiteRuntime.Tests.Actors;
|
|
|
|
/// <summary>
|
|
/// PLAN-03 Task 18 (P2): the Instance Actor routes each attribute change only to the
|
|
/// children interested in it. A value-change / conditional script (and a monitored-attribute
|
|
/// alarm) subscribes to a single named attribute; an Expression-triggered script/alarm hears
|
|
/// every change (it keeps a full attribute snapshot). These tests pin the routing-map
|
|
/// construction directly — the behavioral gate inside each child stays as defense in depth.
|
|
/// </summary>
|
|
public class InstanceActorChildRoutingTests : TestKit, IDisposable
|
|
{
|
|
private readonly SiteStorageService _storage;
|
|
private readonly ScriptCompilationService _compilationService;
|
|
private readonly SharedScriptLibrary _sharedScriptLibrary;
|
|
private readonly SiteRuntimeOptions _options;
|
|
private readonly TestLocalDb _localDb;
|
|
|
|
public InstanceActorChildRoutingTests()
|
|
{
|
|
_localDb = TestLocalDb.CreateTemp("instance-routing-test");
|
|
_storage = new SiteStorageService(
|
|
_localDb.Db,
|
|
NullLogger<SiteStorageService>.Instance);
|
|
_storage.InitializeAsync().GetAwaiter().GetResult();
|
|
_compilationService = new ScriptCompilationService(
|
|
NullLogger<ScriptCompilationService>.Instance);
|
|
_sharedScriptLibrary = new SharedScriptLibrary(
|
|
_compilationService, NullLogger<SharedScriptLibrary>.Instance);
|
|
_options = new SiteRuntimeOptions
|
|
{
|
|
MaxScriptCallDepth = 10,
|
|
ScriptExecutionTimeoutSeconds = 30
|
|
};
|
|
}
|
|
|
|
void IDisposable.Dispose()
|
|
{
|
|
// TestKit teardown first, so no in-flight actor can reach a disposed ILocalDb;
|
|
// then dispose the database before deleting — the master connection anchors the WAL.
|
|
Shutdown();
|
|
var path = _localDb.Path;
|
|
_localDb.Dispose();
|
|
TestLocalDb.DeleteFiles(path);
|
|
}
|
|
|
|
private static FlattenedConfiguration ScriptsAB_and_Expression(string instanceName)
|
|
=> new()
|
|
{
|
|
InstanceUniqueName = instanceName,
|
|
Attributes =
|
|
[
|
|
new ResolvedAttribute { CanonicalName = "A", Value = "1", DataType = "Double" },
|
|
new ResolvedAttribute { CanonicalName = "B", Value = "2", DataType = "Double" }
|
|
],
|
|
Scripts =
|
|
[
|
|
new ResolvedScript
|
|
{
|
|
CanonicalName = "S_A", Code = "return 1;",
|
|
TriggerType = "ValueChange",
|
|
TriggerConfiguration = "{\"attributeName\":\"A\"}"
|
|
},
|
|
new ResolvedScript
|
|
{
|
|
CanonicalName = "S_B", Code = "return 2;",
|
|
TriggerType = "ValueChange",
|
|
TriggerConfiguration = "{\"attributeName\":\"B\"}"
|
|
},
|
|
new ResolvedScript
|
|
{
|
|
CanonicalName = "S_expr", Code = "return 3;",
|
|
TriggerType = "Expression",
|
|
TriggerConfiguration = "{\"expression\":\"true\"}"
|
|
}
|
|
]
|
|
};
|
|
|
|
private InstanceActor BuildInstance(FlattenedConfiguration config)
|
|
{
|
|
var testRef = ActorOfAsTestActorRef<InstanceActor>(
|
|
Props.Create(() => new InstanceActor(
|
|
config.InstanceUniqueName,
|
|
JsonSerializer.Serialize(config),
|
|
_storage,
|
|
_compilationService,
|
|
_sharedScriptLibrary,
|
|
null,
|
|
_options,
|
|
NullLogger<InstanceActor>.Instance)),
|
|
"instance-" + Guid.NewGuid().ToString("N"));
|
|
return testRef.UnderlyingActor;
|
|
}
|
|
|
|
[Fact]
|
|
public void RoutingMaps_AreBuiltFromTriggerConfigs()
|
|
{
|
|
var actor = BuildInstance(ScriptsAB_and_Expression("RoutePump"));
|
|
|
|
// Two value-change scripts route to their own attribute; the expression script
|
|
// routes to the all-changes bucket.
|
|
Assert.Single(actor.ChildrenByMonitoredAttribute["A"]);
|
|
Assert.Single(actor.ChildrenByMonitoredAttribute["B"]);
|
|
Assert.Single(actor.AllChangeChildren);
|
|
}
|
|
|
|
[Fact]
|
|
public void MonitoredAttributeAlarm_RoutesToItsAttribute_ExpressionAlarm_RoutesToAllChanges()
|
|
{
|
|
var config = new FlattenedConfiguration
|
|
{
|
|
InstanceUniqueName = "AlarmRoutePump",
|
|
Attributes =
|
|
[
|
|
new ResolvedAttribute { CanonicalName = "Temp", Value = "10", DataType = "Double" }
|
|
],
|
|
Alarms =
|
|
[
|
|
new ResolvedAlarm
|
|
{
|
|
CanonicalName = "HiTemp",
|
|
TriggerType = "RangeViolation",
|
|
TriggerConfiguration = "{\"attributeName\":\"Temp\",\"min\":0,\"max\":100}",
|
|
PriorityLevel = 1
|
|
},
|
|
new ResolvedAlarm
|
|
{
|
|
CanonicalName = "ExprAlarm",
|
|
TriggerType = "Expression",
|
|
TriggerConfiguration = "{\"expression\":\"true\"}",
|
|
PriorityLevel = 1
|
|
}
|
|
]
|
|
};
|
|
|
|
var actor = BuildInstance(config);
|
|
|
|
Assert.Single(actor.ChildrenByMonitoredAttribute["Temp"]);
|
|
Assert.Single(actor.AllChangeChildren); // the expression alarm
|
|
}
|
|
}
|