Joseph Doherty
c7dfc21b4c
`dotnet ef migrations script --idempotent` puts each migration in ONE batch behind IF NOT EXISTS guards, and SQL Server compiles the whole batch before any guard runs. AddAuditLogHashChain adds ChainSeq and then creates two filtered indexes whose WHERE clause references it in the same batch, so the script failed with Msg 207 "Invalid column name 'ChainSeq'" on any DB at migration <= 60 (the 2026-11-11 vd03 deploy hand-inserted GO separators instead). - AddAuditLogHashChain: the two CREATE INDEX statements go through EXEC(N'...') so they compile at execution time. Same indexes, same snapshot; Migrate() / database update unaffected; DBs that already ran the migration never run it again. The column-level GRANT compiles fine (checked at execution). - Audit of 58-64: no other migration hits the pattern (the idempotent script from 57 now runs clean end to end; AddConfigGraphRowVersions' plain CREATE INDEX on a new column is not compile-checked). - docs/plans/sql/AddAuditLogHashChain.sql: same EXEC wrap. It, and PrefixSearchIndexes.sql / AddConfigGraphRowVersions.sql, also carried a stray UTF-8 BOM after the prepended header comment that made sqlcmd fail with Msg 102 on line 1 of the batch; removed. - New IdempotentMigrationScriptTests: migrates the fixture DB to 57, runs the generated idempotent script batch by batch, asserts every migration applied, then re-runs it as a no-op. Fails with Msg 207 without the migration fix. Co-Authored-By: Claude <noreply@anthropic.com>
85 lines
3.6 KiB
Transact-SQL
85 lines
3.6 KiB
Transact-SQL
-- AddConfigGraphRowVersions (2026-11-10, ScadaBridge#62). A rowversion column + index on the 18 configuration
|
|
-- tables feeding the pending-updates evaluation, so PendingUpdatesEvaluator can skip the fleet flatten when
|
|
-- MAX(RowVersion)+COUNT_BIG(*) over them is unchanged. Additive: SQL Server fills every existing row as the
|
|
-- column is added; old binaries ignore the column. Apply after AddAuditLogHashChain in the coordinated
|
|
-- central-pair migration window (ScadaBridge#107 item 4).
|
|
BEGIN TRANSACTION;
|
|
ALTER TABLE [TemplateScripts] ADD [RowVersion] rowversion NOT NULL;
|
|
|
|
ALTER TABLE [Templates] ADD [RowVersion] rowversion NOT NULL;
|
|
|
|
ALTER TABLE [TemplateNativeAlarmSources] ADD [RowVersion] rowversion NOT NULL;
|
|
|
|
ALTER TABLE [TemplateCompositions] ADD [RowVersion] rowversion NOT NULL;
|
|
|
|
ALTER TABLE [TemplateAttributes] ADD [RowVersion] rowversion NOT NULL;
|
|
|
|
ALTER TABLE [TemplateAlarms] ADD [RowVersion] rowversion NOT NULL;
|
|
|
|
ALTER TABLE [Sites] ADD [RowVersion] rowversion NOT NULL;
|
|
|
|
ALTER TABLE [SharedScripts] ADD [RowVersion] rowversion NOT NULL;
|
|
|
|
ALTER TABLE [Instances] ADD [RowVersion] rowversion NOT NULL;
|
|
|
|
ALTER TABLE [InstanceNativeAlarmSourceOverrides] ADD [RowVersion] rowversion NOT NULL;
|
|
|
|
ALTER TABLE [InstanceConnectionBindings] ADD [RowVersion] rowversion NOT NULL;
|
|
|
|
ALTER TABLE [InstanceAttributeOverrides] ADD [RowVersion] rowversion NOT NULL;
|
|
|
|
ALTER TABLE [InstanceAlarmOverrides] ADD [RowVersion] rowversion NOT NULL;
|
|
|
|
ALTER TABLE [ExternalSystemMethods] ADD [RowVersion] rowversion NOT NULL;
|
|
|
|
ALTER TABLE [ExternalSystemDefinitions] ADD [RowVersion] rowversion NOT NULL;
|
|
|
|
ALTER TABLE [DeployedConfigSnapshots] ADD [RowVersion] rowversion NOT NULL;
|
|
|
|
ALTER TABLE [DataConnections] ADD [RowVersion] rowversion NOT NULL;
|
|
|
|
ALTER TABLE [DatabaseConnectionDefinitions] ADD [RowVersion] rowversion NOT NULL;
|
|
|
|
CREATE INDEX [IX_TemplateScripts_RowVersion] ON [TemplateScripts] ([RowVersion]);
|
|
|
|
CREATE INDEX [IX_Templates_RowVersion] ON [Templates] ([RowVersion]);
|
|
|
|
CREATE INDEX [IX_TemplateNativeAlarmSources_RowVersion] ON [TemplateNativeAlarmSources] ([RowVersion]);
|
|
|
|
CREATE INDEX [IX_TemplateCompositions_RowVersion] ON [TemplateCompositions] ([RowVersion]);
|
|
|
|
CREATE INDEX [IX_TemplateAttributes_RowVersion] ON [TemplateAttributes] ([RowVersion]);
|
|
|
|
CREATE INDEX [IX_TemplateAlarms_RowVersion] ON [TemplateAlarms] ([RowVersion]);
|
|
|
|
CREATE INDEX [IX_Sites_RowVersion] ON [Sites] ([RowVersion]);
|
|
|
|
CREATE INDEX [IX_SharedScripts_RowVersion] ON [SharedScripts] ([RowVersion]);
|
|
|
|
CREATE INDEX [IX_Instances_RowVersion] ON [Instances] ([RowVersion]);
|
|
|
|
CREATE INDEX [IX_InstanceNativeAlarmSourceOverrides_RowVersion] ON [InstanceNativeAlarmSourceOverrides] ([RowVersion]);
|
|
|
|
CREATE INDEX [IX_InstanceConnectionBindings_RowVersion] ON [InstanceConnectionBindings] ([RowVersion]);
|
|
|
|
CREATE INDEX [IX_InstanceAttributeOverrides_RowVersion] ON [InstanceAttributeOverrides] ([RowVersion]);
|
|
|
|
CREATE INDEX [IX_InstanceAlarmOverrides_RowVersion] ON [InstanceAlarmOverrides] ([RowVersion]);
|
|
|
|
CREATE INDEX [IX_ExternalSystemMethods_RowVersion] ON [ExternalSystemMethods] ([RowVersion]);
|
|
|
|
CREATE INDEX [IX_ExternalSystemDefinitions_RowVersion] ON [ExternalSystemDefinitions] ([RowVersion]);
|
|
|
|
CREATE INDEX [IX_DeployedConfigSnapshots_RowVersion] ON [DeployedConfigSnapshots] ([RowVersion]);
|
|
|
|
CREATE INDEX [IX_DataConnections_RowVersion] ON [DataConnections] ([RowVersion]);
|
|
|
|
CREATE INDEX [IX_DatabaseConnectionDefinitions_RowVersion] ON [DatabaseConnectionDefinitions] ([RowVersion]);
|
|
|
|
INSERT INTO [__EFMigrationsHistory] ([MigrationId], [ProductVersion])
|
|
VALUES (N'20261110032839_AddConfigGraphRowVersions', N'10.0.13');
|
|
|
|
COMMIT;
|
|
GO
|
|
|