Joseph Doherty
77cb0ad0e2
The largest themed batch — small mechanical fixes across 11 modules.
API / message hygiene:
- Comm-020: SiteAddressCacheLoaded now carries IReadOnlyDictionary /
IReadOnlyList — Akka messages must be immutable.
- Commons-016: BundleSession.MaxUnlockAttempts named constant replaces
magic 3.
- Commons-018: IOperationTrackingStore + IPartitionMaintenance moved from
Interfaces/ root to Interfaces/Services/ (namespace preserved — 9
consumers exceeded the in-prompt move threshold).
- Commons-023: TrackingStatusSnapshot.SourceNode now consistent with the
trailing-optional-with-default pattern used elsewhere.
- SR-022: AuditingDbCommand.DbConnection.set no longer uses reflection —
exposes AuditingDbConnection.Inner via internal API surface.
Dead code / config cleanup:
- ClusterInfra-011: decorative SectionName constant deleted.
- ClusterInfra-014: dead AddClusterInfrastructureActors method + its
"throws-when-called" test deleted.
- Host-021: Microsoft Logging:LogLevel block deleted from appsettings.json
(dead under Serilog).
Fail-loud over fail-silent:
- DM-021: ResolveSiteIdentifierAsync throws on missing site (was silently
substituting a DB id).
- DM-022: dropped transient Pending write — record now lands directly in
InProgress (no UI flicker, one fewer DB write).
- Host-020: LoggerConfigurationFactory emits a Console.Error warning when
both Serilog:MinimumLevel and ScadaLink:Logging:MinimumLevel are set
(ScadaLink remains truth per Host-011).
- SnF-022: NotifyCachedCallObserverAsync logs Warning on unparseable
TrackedOperationId (was silently dropping).
- SnF-023: empty siteId default replaced with $unknown-site sentinel
+ constructor normalisation.
Correctness:
- SCA-001: SupervisorStrategy XML rewritten to match actual
DefaultDecider/Restart semantics (was claiming Resume).
- SCA-003: OnUpsertAsync now restamps IngestedAtUtc on every upsert.
- SR-021: HandleDeployArtifacts now dispatches an internal
ApplyArtifactDataConnectionsToDcl message after the SQLite write so
system-wide artifact-deploy data-connection changes go live
immediately (was requiring a site restart).
- SnF-020: RetryParkedMessageAsync captures the parked row BEFORE the
local write so a concurrent delete can't skip standby replication.
Sentinels / naming collisions:
- HM-021: CentralSiteId changed from "central" to "$central"
(uncollideable — leading $ is forbidden in real SiteIdentifiers).
Doc / surface cleanups:
- SEL-018: FailedWriteCount promoted to ISiteEventLogger; XML softened
to "Available for future Health Monitoring integration".
- SnF-019: VERIFY outcome — documented parking-after-DefaultMaxRetries
in Component-StoreAndForward.md + DefaultMaxRetries XML (uniform
cap; maxRetries:0 is the unbounded escape hatch).
- SnF-021: Component-StoreAndForward.md no longer claims the tracking
table lives in SnF — it's in SiteRuntime, the interface is in Commons.
- CLI-020: bundle export response parse guarded with try/catch on
JsonException / KeyNotFoundException / FormatException — emits a
clean INVALID_RESPONSE exit instead of a stack trace.
Config:
- ClusterInfra-013: intent comment added to "catastrophic config" test.
- Host-016: appsettings.Site.json second CentralContactPoints entry
removed (was pointing at the SITE's own port); doc-key explains how
to extend.
- Host-018: NodeName added to both shipped per-role configs (was
causing SourceNode to be null on audit rows).
UI:
- CentralUI-029: replaced JS.InvokeAsync<int>("eval", …) with an ES
module import (new wwwroot/js/browser-time.js).
- CentralUI-032: AuditResultsGrid gains a Previous button backed by a
cursor stack.
10+ new regression tests across the affected projects. Build clean;
all suites green. README regenerated: 6 open (was 33).
Session-to-date: 130 of 136 originally-open Theme findings closed.
78 lines
3.2 KiB
C#
78 lines
3.2 KiB
C#
namespace ScadaLink.ClusterInfrastructure.Tests;
|
|
|
|
/// <summary>
|
|
/// Tests for ClusterOptions default values and property setters.
|
|
/// </summary>
|
|
public class ClusterOptionsTests
|
|
{
|
|
[Fact]
|
|
public void DefaultValues_AreCorrect()
|
|
{
|
|
var options = new ClusterOptions();
|
|
|
|
Assert.Equal("keep-oldest", options.SplitBrainResolverStrategy);
|
|
Assert.Equal(TimeSpan.FromSeconds(15), options.StableAfter);
|
|
Assert.Equal(TimeSpan.FromSeconds(2), options.HeartbeatInterval);
|
|
Assert.Equal(TimeSpan.FromSeconds(10), options.FailureDetectionThreshold);
|
|
Assert.Equal(1, options.MinNrOfMembers);
|
|
Assert.True(options.DownIfAlone);
|
|
}
|
|
|
|
[Fact]
|
|
public void DownIfAlone_CanBeSet()
|
|
{
|
|
var options = new ClusterOptions { DownIfAlone = false };
|
|
|
|
Assert.False(options.DownIfAlone);
|
|
}
|
|
|
|
[Fact]
|
|
public void SeedNodes_DefaultsToEmptyList()
|
|
{
|
|
var options = new ClusterOptions();
|
|
|
|
Assert.NotNull(options.SeedNodes);
|
|
Assert.Empty(options.SeedNodes);
|
|
}
|
|
|
|
// ClusterInfra-011: SectionName constant deleted — the previous test
|
|
// `SectionName_IsTheExpectedAppSettingsSection` is removed alongside it.
|
|
// The Host's SiteServiceRegistration / StartupValidator continue to
|
|
// reference the `"ScadaLink:Cluster"` literal directly; reinstating the
|
|
// constant should happen when those Host binding sites can be updated in
|
|
// the same change.
|
|
|
|
[Fact]
|
|
public void Properties_CanBeSetToCustomValues()
|
|
{
|
|
// ClusterInfra-013: this test exercises the POCO property setters only —
|
|
// `SplitBrainResolverStrategy = "keep-majority"` and `MinNrOfMembers = 2`
|
|
// are values the design doc explicitly forbids in production
|
|
// (`keep-majority` causes total shutdown on a two-node partition;
|
|
// `MinNrOfMembers = 2` blocks the cluster singleton after failover).
|
|
// The POCO accepts any value by design; rejection lives in
|
|
// `ClusterOptionsValidator` and is covered by
|
|
// `ClusterOptionsValidatorTests.UnsupportedSplitBrainStrategy_FailsValidation`
|
|
// and `ClusterOptionsValidatorTests.MinNrOfMembers_NotOne_FailsValidation`.
|
|
// Do NOT read these values as endorsed runtime configuration.
|
|
var options = new ClusterOptions
|
|
{
|
|
SeedNodes = new List<string> { "akka.tcp://system@node1:2551", "akka.tcp://system@node2:2551" },
|
|
SplitBrainResolverStrategy = "keep-majority",
|
|
StableAfter = TimeSpan.FromSeconds(30),
|
|
HeartbeatInterval = TimeSpan.FromSeconds(5),
|
|
FailureDetectionThreshold = TimeSpan.FromSeconds(20),
|
|
MinNrOfMembers = 2
|
|
};
|
|
|
|
Assert.Equal(2, options.SeedNodes.Count);
|
|
Assert.Contains("akka.tcp://system@node1:2551", options.SeedNodes);
|
|
Assert.Contains("akka.tcp://system@node2:2551", options.SeedNodes);
|
|
Assert.Equal("keep-majority", options.SplitBrainResolverStrategy);
|
|
Assert.Equal(TimeSpan.FromSeconds(30), options.StableAfter);
|
|
Assert.Equal(TimeSpan.FromSeconds(5), options.HeartbeatInterval);
|
|
Assert.Equal(TimeSpan.FromSeconds(20), options.FailureDetectionThreshold);
|
|
Assert.Equal(2, options.MinNrOfMembers);
|
|
}
|
|
}
|