Joseph Doherty
d81f747434
Add SiteHealthReport.SiteEventLogWriteFailures (trailing optional long = 0, additive-only), ISiteHealthCollector.SetSiteEventLogWriteFailures (default no-op so existing fakes compile), and SiteEventLogFailureCountReporter (hosted service in HealthMonitoring, Func<long> delegate to avoid the HealthMonitoring → StoreAndForward → SiteEventLogging cycle). Registration helper AddSiteEventLogHealthMetricsBridge added to HealthMonitoring.ServiceCollectionExtensions; wired in SiteServiceRegistration after AddSiteEventLogging. Tests: SiteEventLogWriteFailuresMetricTests (4 collector tests) + SiteEventLogFailureCountReporterTests (2 poller tests) in HealthMonitoring.Tests. 79/79 HealthMonitoring.Tests green, 59/59 SiteEventLogging.Tests green, 0 warnings.
63 lines
2.2 KiB
C#
63 lines
2.2 KiB
C#
namespace ZB.MOM.WW.ScadaBridge.HealthMonitoring.Tests;
|
|
|
|
/// <summary>
|
|
/// M2.16 (#30) regression coverage. <see cref="ISiteEventLogger.FailedWriteCount"/>
|
|
/// is a cumulative (point-in-time) counter. A periodic
|
|
/// <c>SiteEventLogFailureCountReporter</c> hosted service polls the count and
|
|
/// pushes it into the collector via
|
|
/// <see cref="ISiteHealthCollector.SetSiteEventLogWriteFailures"/> so the next
|
|
/// <see cref="ISiteHealthCollector.CollectReport"/> includes it in the report
|
|
/// payload as <c>SiteEventLogWriteFailures</c>. Unlike the per-interval
|
|
/// SiteAuditWriteFailures counter, this value is NOT reset on collect — it
|
|
/// carries forward whatever the most recent poller push delivered.
|
|
/// </summary>
|
|
public class SiteEventLogWriteFailuresMetricTests
|
|
{
|
|
private readonly SiteHealthCollector _collector = new();
|
|
|
|
[Fact]
|
|
public void Set_Then_CollectReport_IncludesCount()
|
|
{
|
|
_collector.SetSiteEventLogWriteFailures(17L);
|
|
|
|
var report = _collector.CollectReport("site-1");
|
|
|
|
Assert.Equal(17L, report.SiteEventLogWriteFailures);
|
|
}
|
|
|
|
[Fact]
|
|
public void Report_Payload_Includes_SiteEventLogWriteFailures_AsZeroByDefault()
|
|
{
|
|
var report = _collector.CollectReport("site-1");
|
|
|
|
Assert.Equal(0L, report.SiteEventLogWriteFailures);
|
|
}
|
|
|
|
[Fact]
|
|
public void CollectReport_DoesNotReset_SiteEventLogWriteFailures()
|
|
{
|
|
// This is a point-in-time cumulative count — successive CollectReport
|
|
// calls before the next poller tick MUST carry forward the same value
|
|
// rather than resetting to zero (which would falsely indicate no failures
|
|
// between the two reports).
|
|
_collector.SetSiteEventLogWriteFailures(42L);
|
|
|
|
var first = _collector.CollectReport("site-1");
|
|
var second = _collector.CollectReport("site-1");
|
|
|
|
Assert.Equal(42L, first.SiteEventLogWriteFailures);
|
|
Assert.Equal(42L, second.SiteEventLogWriteFailures);
|
|
}
|
|
|
|
[Fact]
|
|
public void Set_Overwrites_Previous_Value()
|
|
{
|
|
_collector.SetSiteEventLogWriteFailures(5L);
|
|
_collector.SetSiteEventLogWriteFailures(9L);
|
|
|
|
var report = _collector.CollectReport("site-1");
|
|
|
|
Assert.Equal(9L, report.SiteEventLogWriteFailures);
|
|
}
|
|
}
|