Joseph Doherty
7b0b9c7365
Solution + 23 src projects + 26 test projects renamed; folders, csproj, namespaces, and ScadaLinkDbContext/ScadaBridgeDbContext class updated. ActorSystem "scadalink" → "scadabridge", Akka seed-node URLs migrated. SQL roles/logins, LDAP domains, CLI command name, and CLI config dir (~/.scadalink → ~/.scadabridge) also renamed. Build green; 5 Host.Tests fail awaiting SQL login rename in next commit. Pre-existing StaleTagMonitor timing flakes unchanged. Rename script committed at tools/rename-to-scadabridge.sh.
2.0 KiB
Audit Log #23 — M4 Remaining Boundary Emission Implementation Plan
For Claude: REQUIRED SUB-SKILL: Use superpowers-extended-cc:subagent-driven-development (bundled cadence).
Goal: Close every remaining script-trust-boundary emission gap: sync DB writes/reads via Database.Connection().Execute*/ExecuteReader, Notification Outbox central dispatcher attempts + terminal, site-side Notify.Send submission, and Inbound API middleware. Audit-write failure NEVER aborts the user-facing action across all five new code paths.
Vocabulary (M3 reality-locked):
AuditKind.DbWrite(Channel=DbOutbound) for both Execute and ExecuteReader;Extracarries{"op":"write"|"read","rowsAffected":N|"rowsReturned":N}.AuditKind.NotifyDeliverfor each Notification Outbox attempt;AuditStatus.Attemptedon attempts,AuditStatus.Delivered|Failed|Parked|Discardedon terminal.AuditKind.NotifySendfor site-emit at Notify.Send;AuditStatus.Submitted.AuditKind.InboundRequestfor happy-path inbound;AuditStatus.Delivered.AuditKind.InboundAuthFailurefor 401;AuditStatus.Failed.AuditStatus.Failedreplaces "PermanentFailure" / "TransientFailure" terminal wording throughout.
Bundles:
- Bundle A — DB sync emissions (T1, T2)
- Bundle B — NotificationOutbox central emissions (T3, T4, T5)
- Bundle C — Site Notify.Send emission (T6)
- Bundle D — Inbound API audit middleware (T7, T8)
- Bundle E — Integration tests (T9, T10, T11, T12)
- Final cross-bundle review + merge
Each task follows the M2 Bundle F / M3 Bundle E emission pattern: capture timing, build AuditEvent with provenance, write via try/catch that swallows + logs, never propagate audit failure to the user-facing action. Mirror M2's ScriptRuntimeContext wrapper pattern where the emission is script-context-aware.
Integration tests go in tests/ZB.MOM.WW.ScadaBridge.AuditLog.Tests/Integration/ (component-level per M2 Bundle H + M3 Bundle G — the existing IntegrationTests factory disables Akka).