513fa1aa16
Comment/XML-doc changes only: - add summaries to ~10k test methods, fixtures, fakes and helpers (+ <param> on theories, <returns> on async Task methods, <inheritdoc/> on interface implementations the checker can resolve) - strip ~2.6k project-tracking references (WP*, P*-*, row-NN, Task N, #NN, Component-0NN) from comments, keeping the explanatory text; reword false positives in comments only - real docs on fakes implementing BCL/library interfaces (IDisposable, ILogger, IOptionsMonitor, IAsyncLifetime) - reword the last 5 src/ false positives (CWE-1236, failures-1, year-0001, M365) Only non-comment edits: four one-line nested classes split across lines so members can carry docs. Build 0 errors / 0 warnings.
126 lines
4.8 KiB
C#
126 lines
4.8 KiB
C#
using Microsoft.Extensions.Logging.Abstractions;
|
|
|
|
namespace ZB.MOM.WW.ScadaBridge.Host.Tests;
|
|
|
|
/// <summary>
|
|
/// Startup preconditions (database migration) must tolerate a database
|
|
/// that is briefly unavailable at boot — common when an app container and its DB
|
|
/// container start together — via a bounded retry with backoff.
|
|
/// </summary>
|
|
public class StartupRetryTests
|
|
{
|
|
/// <summary>Verifies that an operation that succeeds on the first try runs exactly once.</summary>
|
|
/// <returns>A task that represents the asynchronous operation.</returns>
|
|
[Fact]
|
|
public async Task ExecuteWithRetry_SucceedsFirstTry_RunsOnce()
|
|
{
|
|
var attempts = 0;
|
|
await StartupRetry.ExecuteWithRetryAsync(
|
|
"test-op",
|
|
() => { attempts++; return Task.CompletedTask; },
|
|
maxAttempts: 5,
|
|
initialDelay: TimeSpan.FromMilliseconds(1),
|
|
NullLogger.Instance);
|
|
|
|
Assert.Equal(1, attempts);
|
|
}
|
|
|
|
/// <summary>Verifies that transient failures are retried until the operation succeeds.</summary>
|
|
/// <returns>A task that represents the asynchronous operation.</returns>
|
|
[Fact]
|
|
public async Task ExecuteWithRetry_TransientFailures_RetriesUntilSuccess()
|
|
{
|
|
var attempts = 0;
|
|
await StartupRetry.ExecuteWithRetryAsync(
|
|
"test-op",
|
|
() =>
|
|
{
|
|
attempts++;
|
|
if (attempts < 3)
|
|
throw new InvalidOperationException("db not ready");
|
|
return Task.CompletedTask;
|
|
},
|
|
maxAttempts: 5,
|
|
initialDelay: TimeSpan.FromMilliseconds(1),
|
|
NullLogger.Instance);
|
|
|
|
Assert.Equal(3, attempts);
|
|
}
|
|
|
|
/// <summary>Verifies that exhausting all attempts rethrows the last exception.</summary>
|
|
/// <returns>A task that represents the asynchronous operation.</returns>
|
|
[Fact]
|
|
public async Task ExecuteWithRetry_ExhaustsAttempts_RethrowsLastException()
|
|
{
|
|
var attempts = 0;
|
|
var ex = await Assert.ThrowsAsync<InvalidOperationException>(() =>
|
|
StartupRetry.ExecuteWithRetryAsync(
|
|
"test-op",
|
|
() =>
|
|
{
|
|
attempts++;
|
|
throw new InvalidOperationException($"failure {attempts}");
|
|
},
|
|
maxAttempts: 3,
|
|
initialDelay: TimeSpan.FromMilliseconds(1),
|
|
NullLogger.Instance,
|
|
isTransient: _ => true));
|
|
|
|
Assert.Equal(3, attempts);
|
|
Assert.Equal("failure 3", ex.Message);
|
|
}
|
|
|
|
/// <summary>Verifies that a non-transient failure is rethrown after a single attempt.</summary>
|
|
/// <returns>A task that represents the asynchronous operation.</returns>
|
|
[Fact]
|
|
public async Task ExecuteWithRetry_NonTransientFailure_RethrowsAfterSingleAttempt()
|
|
{
|
|
// A permanent failure (e.g. a schema-version mismatch) must NOT be
|
|
// retried — retrying it cannot succeed and only delays the fatal exit by
|
|
// minutes. The isTransient predicate classifies it as non-retryable, so the
|
|
// operation runs exactly once before the exception propagates.
|
|
var attempts = 0;
|
|
var ex = await Assert.ThrowsAsync<InvalidOperationException>(() =>
|
|
StartupRetry.ExecuteWithRetryAsync(
|
|
"test-op",
|
|
() =>
|
|
{
|
|
attempts++;
|
|
throw new InvalidOperationException("permanent schema mismatch");
|
|
},
|
|
maxAttempts: 8,
|
|
initialDelay: TimeSpan.FromMilliseconds(1),
|
|
NullLogger.Instance,
|
|
isTransient: _ => false));
|
|
|
|
Assert.Equal(1, attempts);
|
|
Assert.Equal("permanent schema mismatch", ex.Message);
|
|
}
|
|
|
|
/// <summary>Verifies that a transient failure followed by a permanent one stops at the permanent failure.</summary>
|
|
/// <returns>A task that represents the asynchronous operation.</returns>
|
|
[Fact]
|
|
public async Task ExecuteWithRetry_TransientThenPermanent_StopsAtPermanent()
|
|
{
|
|
// A transient fault is retried; a subsequent permanent fault is not.
|
|
var attempts = 0;
|
|
await Assert.ThrowsAsync<InvalidOperationException>(() =>
|
|
StartupRetry.ExecuteWithRetryAsync(
|
|
"test-op",
|
|
() =>
|
|
{
|
|
attempts++;
|
|
if (attempts == 1)
|
|
throw new TimeoutException("transient");
|
|
throw new InvalidOperationException("permanent");
|
|
},
|
|
maxAttempts: 8,
|
|
initialDelay: TimeSpan.FromMilliseconds(1),
|
|
NullLogger.Instance,
|
|
isTransient: e => e is TimeoutException));
|
|
|
|
// 1 transient (retried) + 1 permanent (not retried) = 2.
|
|
Assert.Equal(2, attempts);
|
|
}
|
|
}
|