Joseph Doherty
513fa1aa16
Comment/XML-doc changes only: - add summaries to ~10k test methods, fixtures, fakes and helpers (+ <param> on theories, <returns> on async Task methods, <inheritdoc/> on interface implementations the checker can resolve) - strip ~2.6k project-tracking references (WP*, P*-*, row-NN, Task N, #NN, Component-0NN) from comments, keeping the explanatory text; reword false positives in comments only - real docs on fakes implementing BCL/library interfaces (IDisposable, ILogger, IOptionsMonitor, IAsyncLifetime) - reword the last 5 src/ false positives (CWE-1236, failures-1, year-0001, M365) Only non-comment edits: four one-line nested classes split across lines so members can carry docs. Build 0 errors / 0 warnings.
89 lines
3.6 KiB
C#
89 lines
3.6 KiB
C#
using System.Net;
|
|
|
|
namespace ZB.MOM.WW.ScadaBridge.ExternalSystemGateway.Tests;
|
|
|
|
/// <summary>
|
|
/// Tests for HTTP error classification.
|
|
/// Transient: connection refused, timeout, HTTP 408/429/5xx.
|
|
/// Permanent: HTTP 4xx (except 408/429).
|
|
/// </summary>
|
|
public class ErrorClassifierTests
|
|
{
|
|
/// <summary>Verifies that transient HTTP status codes are classified as transient.</summary>
|
|
/// <param name="statusCode">The test input.</param>
|
|
/// <param name="expectedTransient">The test input.</param>
|
|
[Theory]
|
|
[InlineData(HttpStatusCode.InternalServerError, true)]
|
|
[InlineData(HttpStatusCode.BadGateway, true)]
|
|
[InlineData(HttpStatusCode.ServiceUnavailable, true)]
|
|
[InlineData(HttpStatusCode.GatewayTimeout, true)]
|
|
[InlineData(HttpStatusCode.RequestTimeout, true)]
|
|
[InlineData((HttpStatusCode)429, true)] // TooManyRequests
|
|
public void TransientStatusCodes_ClassifiedCorrectly(HttpStatusCode statusCode, bool expectedTransient)
|
|
{
|
|
Assert.Equal(expectedTransient, ErrorClassifier.IsTransient(statusCode));
|
|
}
|
|
|
|
/// <summary>Verifies that permanent HTTP status codes are classified as permanent.</summary>
|
|
/// <param name="statusCode">The test input.</param>
|
|
/// <param name="expectedTransient">The test input.</param>
|
|
[Theory]
|
|
[InlineData(HttpStatusCode.BadRequest, false)]
|
|
[InlineData(HttpStatusCode.Unauthorized, false)]
|
|
[InlineData(HttpStatusCode.Forbidden, false)]
|
|
[InlineData(HttpStatusCode.NotFound, false)]
|
|
[InlineData(HttpStatusCode.MethodNotAllowed, false)]
|
|
[InlineData(HttpStatusCode.Conflict, false)]
|
|
public void PermanentStatusCodes_ClassifiedCorrectly(HttpStatusCode statusCode, bool expectedTransient)
|
|
{
|
|
Assert.Equal(expectedTransient, ErrorClassifier.IsTransient(statusCode));
|
|
}
|
|
|
|
/// <summary>Verifies that an HttpRequestException is classified as transient.</summary>
|
|
[Fact]
|
|
public void HttpRequestException_IsTransient()
|
|
{
|
|
Assert.True(ErrorClassifier.IsTransient(new HttpRequestException("Connection refused")));
|
|
}
|
|
|
|
/// <summary>Verifies that a TaskCanceledException is classified as transient.</summary>
|
|
[Fact]
|
|
public void TaskCanceledException_IsTransient()
|
|
{
|
|
Assert.True(ErrorClassifier.IsTransient(new TaskCanceledException("Timeout")));
|
|
}
|
|
|
|
/// <summary>Verifies that a TimeoutException is classified as transient.</summary>
|
|
[Fact]
|
|
public void TimeoutException_IsTransient()
|
|
{
|
|
Assert.True(ErrorClassifier.IsTransient(new TimeoutException()));
|
|
}
|
|
|
|
/// <summary>Verifies that a generic exception is not classified as transient.</summary>
|
|
[Fact]
|
|
public void GenericException_IsNotTransient()
|
|
{
|
|
Assert.False(ErrorClassifier.IsTransient(new InvalidOperationException("bad input")));
|
|
}
|
|
|
|
/// <summary>Verifies that AsTransient creates the expected exception.</summary>
|
|
[Fact]
|
|
public void AsTransient_CreatesCorrectException()
|
|
{
|
|
var ex = ErrorClassifier.AsTransient("test message");
|
|
Assert.IsType<TransientExternalSystemException>(ex);
|
|
Assert.Equal("test message", ex.Message);
|
|
}
|
|
|
|
/// <summary>Verifies that an OperationCanceledException caused by the caller's cancellation is not classified as transient.</summary>
|
|
[Fact]
|
|
public void IsTransient_CallerCancelledOce_IsNotTransient()
|
|
{
|
|
var cts = new CancellationTokenSource();
|
|
cts.Cancel();
|
|
Assert.False(ErrorClassifier.IsTransient(new OperationCanceledException(), cts.Token));
|
|
Assert.True(ErrorClassifier.IsTransient(new OperationCanceledException(), CancellationToken.None));
|
|
}
|
|
}
|