Joseph Doherty
513fa1aa16
Comment/XML-doc changes only: - add summaries to ~10k test methods, fixtures, fakes and helpers (+ <param> on theories, <returns> on async Task methods, <inheritdoc/> on interface implementations the checker can resolve) - strip ~2.6k project-tracking references (WP*, P*-*, row-NN, Task N, #NN, Component-0NN) from comments, keeping the explanatory text; reword false positives in comments only - real docs on fakes implementing BCL/library interfaces (IDisposable, ILogger, IOptionsMonitor, IAsyncLifetime) - reword the last 5 src/ false positives (CWE-1236, failures-1, year-0001, M365) Only non-comment edits: four one-line nested classes split across lines so members can carry docs. Build 0 errors / 0 warnings.
73 lines
2.9 KiB
C#
73 lines
2.9 KiB
C#
using ZB.MOM.WW.ScadaBridge.CentralUI.Components;
|
|
|
|
namespace ZB.MOM.WW.ScadaBridge.CentralUI.Tests.Monitoring;
|
|
|
|
/// <summary>
|
|
/// Regression tests for the datetime-local conversion. <c><input type="datetime-local"></c>
|
|
/// yields the value the user typed in their <i>browser-local</i> time zone. The
|
|
/// audit-log filter converted it with <c>new DateTimeOffset(value, TimeSpan.Zero)</c>
|
|
/// — relabelling the local wall-clock value as UTC, shifting the query window by
|
|
/// the user's offset. <see cref="BrowserTime.LocalInputToUtc"/> performs the
|
|
/// correct conversion: it applies the browser offset from <c>getTimezoneOffset()</c>.
|
|
/// </summary>
|
|
public class BrowserTimeTests
|
|
{
|
|
/// <summary>Verifies that local input to utc, when null, returns null.</summary>
|
|
[Fact]
|
|
public void LocalInputToUtc_Null_ReturnsNull()
|
|
{
|
|
Assert.Null(BrowserTime.LocalInputToUtc(null, 0));
|
|
}
|
|
|
|
/// <summary>Verifies that local input to utc, when utc browser, leaves time unchanged.</summary>
|
|
[Fact]
|
|
public void LocalInputToUtc_UtcBrowser_LeavesTimeUnchanged()
|
|
{
|
|
// getTimezoneOffset() == 0 for a UTC browser.
|
|
var local = new DateTime(2026, 5, 16, 9, 30, 0);
|
|
|
|
var utc = BrowserTime.LocalInputToUtc(local, 0);
|
|
|
|
Assert.Equal(new DateTimeOffset(2026, 5, 16, 9, 30, 0, TimeSpan.Zero), utc);
|
|
}
|
|
|
|
/// <summary>Verifies that local input to utc, when positive utc offset browser, subtracts offset.</summary>
|
|
[Fact]
|
|
public void LocalInputToUtc_PositiveUtcOffsetBrowser_SubtractsOffset()
|
|
{
|
|
// A browser at UTC+2 reports getTimezoneOffset() == -120.
|
|
// The user typing 09:30 local means 07:30 UTC.
|
|
var local = new DateTime(2026, 5, 16, 9, 30, 0);
|
|
|
|
var utc = BrowserTime.LocalInputToUtc(local, -120);
|
|
|
|
Assert.Equal(new DateTimeOffset(2026, 5, 16, 7, 30, 0, TimeSpan.Zero), utc);
|
|
}
|
|
|
|
/// <summary>Verifies that local input to utc, when negative utc offset browser, adds offset.</summary>
|
|
[Fact]
|
|
public void LocalInputToUtc_NegativeUtcOffsetBrowser_AddsOffset()
|
|
{
|
|
// A browser at UTC minus 5 hours (US Eastern, standard time) reports getTimezoneOffset() == 300.
|
|
// The user typing 09:30 local means 14:30 UTC.
|
|
var local = new DateTime(2026, 5, 16, 9, 30, 0);
|
|
|
|
var utc = BrowserTime.LocalInputToUtc(local, 300);
|
|
|
|
Assert.Equal(new DateTimeOffset(2026, 5, 16, 14, 30, 0, TimeSpan.Zero), utc);
|
|
}
|
|
|
|
/// <summary>Verifies that local input to utc, when non utc browser, does not equal naive relabelling.</summary>
|
|
[Fact]
|
|
public void LocalInputToUtc_NonUtcBrowser_DoesNotEqualNaiveRelabelling()
|
|
{
|
|
// The pre-fix bug: naive new DateTimeOffset(value, TimeSpan.Zero).
|
|
var local = new DateTime(2026, 5, 16, 9, 30, 0);
|
|
var naive = new DateTimeOffset(local, TimeSpan.Zero);
|
|
|
|
var correct = BrowserTime.LocalInputToUtc(local, 300);
|
|
|
|
Assert.NotEqual(naive, correct);
|
|
}
|
|
}
|