Joseph Doherty
9a87d7a328
Second slice of the 2026-09-09 whole-system review remediation
(docs/plans/2026-09-09-arch-review.md §10), on top of the High slice 146a1323.
Runtime/devices: SR-2 alarm on-trigger integration scope; SR-3 correlated NativeAlarmActor
subscribe retry; SR-4 immutable audited DB target; SR-5 ordered InstanceActor stop/flush;
SR-12 rehydration fence; SR-13 S&F gate recheck per delivery; DC-4 no OPC UA security
downgrade; DC-5 alarm snapshot for every new subscriber; ORCH-1 sync-dispose joins the pump.
Management/UI: MG-2 site scope on audit tree + Flow Debugger Replay; MG-3 stale-probe memo
removed; MG-4 server-owned bulk-deploy deadline; UI-5 sandbox runs in a killable child
process (new CentralUI.SandboxWorker project); UI-14 bounded sandbox output/IPC.
Edge/audit: EI-1 relay audit ownership; EI-2 SkipBodyCapture suppresses error text; EI-3/EI-11
error-field redaction + caps; EI-4 single relay deadline, pre-execution-only retry; EI-5
authenticated relay provenance; EI-10 body cap before audit read.
Persistence/contracts: DL-1 global Instance.UniqueName unique index + conflict translation;
DL-2 DataConnection protocol config encrypted at rest (migration
20260909203046_EnforceGlobalInstanceNamesAndProtectProtocolConfiguration — coordinated
central upgrade, old binaries cannot read protected rows); DL-3 bounded Replay paging;
DL-6 cross-site Overwrite of a deployed instance rejected; XC-4 proto descriptor contract test.
Config/hygiene: XC-1 central listener isolation by local port; XC-2/XC-3 inert SMTP + cron
keys removed from rig settings; CM-2 env2 bootstrap guard enabled; DC-6 deploy site exit code;
DC-7 notifier retries only explicit standby rejection; XC-5 ClusterClient purged from docs.
Gates recorded in the report: build 0/0, 9 397 passed / 0 failed, rig redeployed on all
eight nodes with the migration applied. 46 Low findings remain open.
42 lines
2.1 KiB
C#
42 lines
2.1 KiB
C#
using System.Text.Json;
|
|
|
|
namespace ZB.MOM.WW.ScadaBridge.CentralUI.PlaywrightTests;
|
|
|
|
/// <summary>Verifies worker publication and termination in the deployed Linux runtime image.</summary>
|
|
[Collection("Playwright")]
|
|
public class SandboxWorkerDeploymentTests(PlaywrightFixture fixture)
|
|
{
|
|
[Fact]
|
|
public async Task Medium_WorkerRunsBoundsOutputAndRecoversAfterNoncooperativeScript()
|
|
{
|
|
var page = await fixture.NewAuthenticatedPageAsync();
|
|
try
|
|
{
|
|
async Task<JsonElement> Run(string code) => await page.EvaluateAsync<JsonElement>("""
|
|
async code => {
|
|
const response = await fetch('/api/script-analysis/run', {
|
|
method: 'POST', headers: { 'Content-Type': 'application/json' },
|
|
body: JSON.stringify({ code, timeoutSeconds: 10 })
|
|
});
|
|
if (!response.ok) throw new Error(`Test Run HTTP ${response.status}`);
|
|
return await response.json();
|
|
}
|
|
""", code);
|
|
var first = await Run("return 42;");
|
|
Assert.True(first.GetProperty("success").GetBoolean(), first.ToString());
|
|
Assert.Equal("42", first.GetProperty("returnValueJson").GetString());
|
|
var bounded = await Run("Console.Write(new string('x', 100000)); return new string('y', 100000);");
|
|
Assert.True(bounded.GetProperty("consoleOutput").GetString()!.Length <= 32768 + "\n… (truncated)".Length);
|
|
Assert.Contains("truncated", bounded.GetProperty("consoleOutput").GetString());
|
|
Assert.True(bounded.GetRawText().Length < 100000);
|
|
var timeout = await Run("while (true) { }");
|
|
Assert.False(timeout.GetProperty("success").GetBoolean());
|
|
Assert.Equal(4, timeout.GetProperty("errorKind").GetInt32());
|
|
var recovered = await Run("return 43;");
|
|
Assert.True(recovered.GetProperty("success").GetBoolean(), recovered.ToString());
|
|
Assert.Equal("43", recovered.GetProperty("returnValueJson").GetString());
|
|
}
|
|
finally { await page.CloseAsync(); }
|
|
}
|
|
}
|