Joseph Doherty
a212283104
WP2.6 (arch-review remediation, cross-cutting misc): - SiteExternalSystemRepository: name/ID-indexed ExternalSystemDefinitionCache replaces the fetch-all + reverse-map scan on every by-ID/method lookup; loaded once per redeploy, invalidated by DeploymentManagerActor after HandleDeployArtifacts applies external-system changes. Static JsonSerializerOptions for method-list parsing. - Inbound API: short-TTL ApiMethodCache fronts the per-request ApiMethod repository fetch; invalidated by name via the existing ScriptArtifactChangeSubscriber/ IScriptArtifactChangeBus pipeline, self-healing via TTL for changes the bus doesn't cover (e.g. Management API edits). - StoreAndForward: the cached-call audit-observer queue — the one unbounded channel left in the system — is now bounded (ObserverQueueCapacity, default 10,000) with DropOldest overflow and a dropped-notification counter. - SiteStreamManager: alarm state changes now travel a dedicated publish source/broadcast hub, isolated from the (far higher-volume) attribute path, so an attribute storm can no longer evict a pending alarm transition; the alarm hand-off queue is bounded with a drop counter surfaced on the site health report (SiteStreamAlarmDropCount via the new SiteStreamAlarmDropReporter), and publishing is skipped entirely at zero subscribers on either path. - CLI ManagementHttpClient: explicit 30s HttpClient.Timeout on the shared construction (was the 100s framework default), overridable via SCADABRIDGE_HTTP_TIMEOUT_SECONDS. Deviation: the failback-probe heartbeat item is NOT included — its only viable surface (CentralChannelProvider.cs / heartbeat consumers) lives entirely in the Communication project, explicitly off-limits to this work package this phase. Tests: SiteRuntime.Tests (550), InboundAPI.Tests (278), StoreAndForward.Tests (133), CLI.Tests (390), HealthMonitoring.Tests (97) — all green after full solution build.
88 lines
2.8 KiB
C#
88 lines
2.8 KiB
C#
using Microsoft.Extensions.Options;
|
|
|
|
namespace ZB.MOM.WW.ScadaBridge.SiteRuntime.Tests;
|
|
|
|
/// <summary>
|
|
/// <see cref="SiteRuntimeOptions"/> values size the staggered Instance-Actor
|
|
/// startup batches, the dedicated script-execution thread scheduler, and the
|
|
/// site-wide stream buffer. A zero/negative count crashes actor construction with
|
|
/// an opaque <see cref="ArgumentOutOfRangeException"/>; these tests assert the
|
|
/// <see cref="SiteRuntimeOptionsValidator"/> rejects a bad
|
|
/// <c>ScadaBridge:SiteRuntime</c> section with a clear, key-naming message.
|
|
/// </summary>
|
|
public class SiteRuntimeOptionsValidatorTests
|
|
{
|
|
private static ValidateOptionsResult Validate(SiteRuntimeOptions options) =>
|
|
new SiteRuntimeOptionsValidator().Validate(Options.DefaultName, options);
|
|
|
|
[Fact]
|
|
public void DefaultOptions_AreValid()
|
|
{
|
|
var result = Validate(new SiteRuntimeOptions());
|
|
Assert.True(result.Succeeded, result.FailureMessage);
|
|
}
|
|
|
|
[Fact]
|
|
public void ZeroStartupBatchSize_IsRejected()
|
|
{
|
|
var result = Validate(new SiteRuntimeOptions { StartupBatchSize = 0 });
|
|
|
|
Assert.True(result.Failed);
|
|
Assert.Contains("StartupBatchSize", result.FailureMessage);
|
|
}
|
|
|
|
[Fact]
|
|
public void ZeroScriptExecutionThreadCount_IsRejected()
|
|
{
|
|
var result = Validate(new SiteRuntimeOptions { ScriptExecutionThreadCount = 0 });
|
|
|
|
Assert.True(result.Failed);
|
|
Assert.Contains("ScriptExecutionThreadCount", result.FailureMessage);
|
|
}
|
|
|
|
[Fact]
|
|
public void ZeroTagSubscribeRetryIntervalMs_IsRejected()
|
|
{
|
|
var result = Validate(new SiteRuntimeOptions { TagSubscribeRetryIntervalMs = 0 });
|
|
|
|
Assert.True(result.Failed);
|
|
Assert.Contains("TagSubscribeRetryIntervalMs", result.FailureMessage);
|
|
}
|
|
|
|
[Fact]
|
|
public void NegativeStuckScriptGraceMs_IsRejected()
|
|
{
|
|
var result = Validate(new SiteRuntimeOptions { StuckScriptGraceMs = -1 });
|
|
|
|
Assert.True(result.Failed);
|
|
Assert.Contains("StuckScriptGraceMs", result.FailureMessage);
|
|
}
|
|
|
|
[Fact]
|
|
public void ZeroStreamBufferSize_IsRejected()
|
|
{
|
|
var result = Validate(new SiteRuntimeOptions { StreamBufferSize = 0 });
|
|
|
|
Assert.True(result.Failed);
|
|
Assert.Contains("StreamBufferSize", result.FailureMessage);
|
|
}
|
|
|
|
[Fact]
|
|
public void NegativeStartupBatchDelayMs_IsRejected()
|
|
{
|
|
var result = Validate(new SiteRuntimeOptions { StartupBatchDelayMs = -1 });
|
|
|
|
Assert.True(result.Failed);
|
|
Assert.Contains("StartupBatchDelayMs", result.FailureMessage);
|
|
}
|
|
|
|
[Fact]
|
|
public void ZeroAlarmPublishQueueCapacity_IsRejected()
|
|
{
|
|
var result = Validate(new SiteRuntimeOptions { AlarmPublishQueueCapacity = 0 });
|
|
|
|
Assert.True(result.Failed);
|
|
Assert.Contains("AlarmPublishQueueCapacity", result.FailureMessage);
|
|
}
|
|
}
|