ScadaBridge/tests/ZB.MOM.WW.ScadaBridge.NotificationOutbox.Tests/NotificationOutboxActorAuditInjectionTests.cs

using Akka.Actor;
using Akka.TestKit.Xunit2;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Logging.Abstractions;
using NSubstitute;
using ZB.MOM.WW.ScadaBridge.Commons.Entities.Audit;
using ZB.MOM.WW.ScadaBridge.Commons.Entities.Notifications;
using ZB.MOM.WW.ScadaBridge.Commons.Interfaces.Repositories;
using ZB.MOM.WW.ScadaBridge.Commons.Interfaces.Services;

namespace ZB.MOM.WW.ScadaBridge.NotificationOutbox.Tests;

/// <summary>
/// M4 Bundle B (B1) — verifies <see cref="NotificationOutboxActor"/> accepts an
/// <see cref="ICentralAuditWriter"/> at construction so subsequent bundle tasks
/// (B2/B3) can route attempt + terminal lifecycle events through the central
/// direct-write audit path.
/// </summary>
public class NotificationOutboxActorAuditInjectionTests : TestKit
{
    private static IServiceProvider BuildEmptyProvider()
    {
        var services = new ServiceCollection();
        services.AddScoped(_ => Substitute.For<INotificationOutboxRepository>());
        services.AddScoped(_ => Substitute.For<INotificationRepository>());
        return services.BuildServiceProvider();
    }

    /// <summary>
    /// Inline NoOp writer that records calls — used to assert later tasks emit
    /// events without depending on a concrete CentralAuditWriter.
    /// </summary>
    private sealed class RecordingCentralAuditWriter : ICentralAuditWriter
    {
        public List<AuditEvent> Events { get; } = new();

        public Task WriteAsync(AuditEvent evt, CancellationToken ct = default)
        {
            lock (Events)
            {
                Events.Add(evt);
            }
            return Task.CompletedTask;
        }
    }

    [Fact]
    public void Actor_ConstructedWith_ICentralAuditWriter_NoException()
    {
        var writer = new RecordingCentralAuditWriter();
        // Long dispatch interval so PreStart's timer never fires during the test.
        var options = new NotificationOutboxOptions { DispatchInterval = TimeSpan.FromHours(1) };

        var actor = Sys.ActorOf(Props.Create(() => new NotificationOutboxActor(
            BuildEmptyProvider(),
            options,
            writer,
            NullLogger<NotificationOutboxActor>.Instance)));

        Assert.NotNull(actor);
        // No event has been emitted yet — the writer is purely injected at this stage.
        lock (writer.Events)
        {
            Assert.Empty(writer.Events);
        }
    }

    [Fact]
    public void Actor_NullAuditWriter_Throws()
    {
        var options = new NotificationOutboxOptions { DispatchInterval = TimeSpan.FromHours(1) };

        Assert.Throws<ArgumentNullException>(() => new NotificationOutboxActor(
            BuildEmptyProvider(),
            options,
            auditWriter: null!,
            NullLogger<NotificationOutboxActor>.Instance));
    }
}