Files

T

Joseph Doherty 2ed5c6c379 fix(concurrency/lifetime): close Theme 5 — 10 concurrency / DI / scope findings

Concurrency hazards, DI lifetime hygiene, and one verify-only confirmation
across 8 modules. Highlights:

Concurrency:
- CentralUI-030: SandboxConsoleCapture writes routed through WriteSynchronized
  locking on the captured StringWriter — intra-script Task fan-out can no
  longer corrupt the per-call buffer.
- Commons-021: ExternalCallResult.Response now backed by Lazy<dynamic?>
  (ExecutionAndPublication) — no more benign double-parse race.
- CD-017: DeploymentManagerRepository.DeleteDeploymentRecordAsync now takes
  an expected RowVersion and seeds entry.OriginalValues so EF emits
  DELETE ... WHERE Id=@id AND RowVersion=@prior; stale RowVersion now
  throws DbUpdateConcurrencyException instead of silent overwrite.
- Transport-009: AuditCorrelationContext.BundleImportId backed by
  AsyncLocal<Guid?> so concurrent imports get per-logical-call isolation
  (was a scoped instance shared via AuditService across runs).

DI / lifetime:
- AuditLog-003: All 3 AuditLog actor handlers switched to CreateAsyncScope
  + await using — async EF disposal no longer swallowed.
- AuditLog-007: INodeIdentityProvider resolution standardised on
  GetRequiredService<>() (was mixed with GetService<>()).
- AuditLog-011: AddAuditLogHealthMetricsBridge guarded by sentinel
  descriptor check — calling twice no longer double-registers the hosted
  service.

Shutdown / supervision:
- SiteCallAudit-002: AkkaHostedService adds a CoordinatedShutdown
  cluster-leave task (drain-site-call-audit-singleton) that issues a
  bounded GracefulStop(10s) so failover waits for in-flight upserts.

Registration safety:
- NS-020: AkkaHostedService now guards NotificationForwarder S&F
  registration with _notificationDeliveryHandlerRegistered + throws
  InvalidOperationException on double-register to make the regression loud.

VERIFY-only closures:
- NotifOutbox-005: Confirmed already closed by CD-015 fix (ac96b83) —
  NotificationOutboxRepository.InsertIfNotExistsAsync uses the same
  raw-SQL IF NOT EXISTS + 2601/2627 swallow pattern; race eliminated.

5+ new regression tests (CentralUI sandbox WhenAll, ExternalCallResult
64-reader Barrier, AuditLog DI idempotency, RowVersion stale-throw,
SiteCallAudit-002 shutdown drain). Build clean; affected suites all green.
README regenerated: 65 open (was 75).

2026-05-28 07:29:41 -04:00

15 KiB

Raw Blame History

Code Reviews

Comprehensive, per-module code reviews of the ScadaLink codebase. Each module (one buildable project under src/) has its own folder containing a findings.md. This README is the aggregated index — the single place to see all outstanding work.

Generated by regen-readme.py from the per-module findings.md files. Do not edit by hand — edit the findings files and re-run the script.

How it works

Reviews are performed one module at a time against a fixed checklist.
Every finding is recorded in the module's findings.md with a severity and status.
Findings are never deleted — they are closed by changing their status, keeping a full audit trail.
This README aggregates every pending finding (Open / In Progress) across all modules.

See REVIEW-PROCESS.md for the full procedure: the review checklist, severity definitions, finding format, and how to mark items resolved.

Layout

code-reviews/
├── README.md            # this file — process overview + pending findings
├── REVIEW-PROCESS.md     # how to perform a review and track findings
├── regen-readme.py       # regenerates this README from the findings files
├── _template/findings.md # copy-this template for a module review
└── <Module>/findings.md  # one folder per src/ project

Baseline review — 2026-05-16

All 19 modules were reviewed at commit 9c60592 (241 findings: 6 Critical, 46 High, 100 Medium, 89 Low). The tables below track what remains open as findings are resolved and re-triaged; findings discovered after the baseline are appended to their module file and counted in Total.

Severity	Open findings
Critical	0
High	0
Medium	22
Low	43
Total	65

Module Status

Module	Last reviewed	Commit	Open (C/H/M/L)	Open	Total
AuditLog	2026-05-28	`1eb6e97`	0/0/2/1	3	11
CLI	2026-05-28	`1eb6e97`	0/0/1/2	3	23
CentralUI	2026-05-28	`1eb6e97`	0/0/0/4	4	33
ClusterInfrastructure	2026-05-28	`1eb6e97`	0/0/0/3	3	14
Commons	2026-05-28	`1eb6e97`	0/0/0/4	4	23
Communication	2026-05-28	`1eb6e97`	0/0/1/1	2	22
ConfigurationDatabase	2026-05-28	`1eb6e97`	0/0/1/2	3	24
DataConnectionLayer	2026-05-28	`1eb6e97`	0/0/0/0	0	22
DeploymentManager	2026-05-28	`1eb6e97`	0/0/0/4	4	24
ExternalSystemGateway	2026-05-28	`1eb6e97`	0/0/1/1	2	23
HealthMonitoring	2026-05-28	`1eb6e97`	0/0/0/2	2	23
Host	2026-05-28	`1eb6e97`	0/0/1/3	4	22
InboundAPI	2026-05-28	`1eb6e97`	0/0/1/2	3	25
ManagementService	2026-05-28	`1eb6e97`	0/0/2/1	3	23
NotificationOutbox	2026-05-28	`1eb6e97`	0/0/0/2	2	10
NotificationService	2026-05-28	`1eb6e97`	0/0/1/2	3	25
Security	2026-05-28	`1eb6e97`	0/0/0/1	1	21
SiteCallAudit	2026-05-28	`1eb6e97`	0/0/2/1	3	6
SiteEventLogging	2026-05-28	`1eb6e97`	0/0/0/3	3	23
SiteRuntime	2026-05-28	`1eb6e97`	0/0/2/0	2	26
StoreAndForward	2026-05-28	`1eb6e97`	0/0/3/2	5	24
TemplateEngine	2026-05-28	`1eb6e97`	0/0/3/0	3	22
Transport	2026-05-28	`1eb6e97`	0/0/1/2	3	12

Pending Findings

Every Open / In Progress finding across all modules, highest severity first. Resolved findings drop off this list but remain recorded in their module's findings.md (see REVIEW-PROCESS.md §4–§5). Full detail — description, location, recommendation — lives in the module's findings.md.

Critical (0)

None open.

High (0)