f2efeb37b7
Tasks 5 and 6 of the Phase 2 plan, committed together because their test
fallout is entangled — several fixtures construct both stores.
StoreAndForwardStorage and SiteStorageService now take ILocalDb. Connections
come from ILocalDb.CreateConnection(), which hands out an already-open,
pragma-configured connection carrying the zb_hlc_next() UDF the capture triggers
call; a raw connection would lack the UDF and every write to a replicated table
would fail closed. Deleted with the connection strings: S&F's
EnsureDatabaseDirectoryExists and its per-open busy_timeout pragma, and the site
service's BusyTimeoutFloorSeconds normalization — LocalDb owns all of it now.
DI: AddSiteRuntime's string overload is gone (nothing left to supply), so the
Host calls the no-arg form. ScadaBridge:Database:SiteDbPath and
StoreAndForwardOptions.SqliteDbPath survive only as the migrator's source
locations in Tasks 8/9.
Two things the plan did not anticipate, both worth reading:
1. FOUND A REAL LATENT DEFECT, from Phase 1, now fixed. The plan assumed
directory creation simply moved to LocalDb along with file ownership. It did
not: the LocalDb library never creates the parent directory, and
SqliteLocalDb opens the file eagerly in its constructor — so a missing
directory is a hard boot failure ("SQLite Error 14: unable to open database
file"), not a degraded start. The default site config points at the RELATIVE
path ./data/site-localdb.db, so any site node without a pre-existing data/
directory fails to boot. The docker rig escapes only because its volume mount
happens to create /app/data — a coincidence that would have hidden this until
a bare-metal or fresh deployment. This has been latent since Phase 1 made
LocalDb:Path required; deleting S&F's EnsureDatabaseDirectoryExists here
would have widened it. Re-established the guarantee at the layer that now
owns the path (SiteLocalDbDirectory.Ensure, called before AddZbLocalDb) and
pinned it with SiteLocalDbDirectoryTests. Non-vacuity is not assumed: two
tests written against the wrong assumption failed with exactly this
SQLite Error 14 before the fix existed.
2. Test fallout was ~7x the plan's estimate. The plan named "fixtures" in one
project; the constructor change actually reaches 40 files across 7 test
projects, and most used Mode=Memory;Cache=Shared — which LocalDb has no
equivalent for, so every one had to move to a real temp file. Rather than
copy the Phase 1 TestLocalDb fixture into 7 projects, added a shared
tests/ZB.MOM.WW.ScadaBridge.TestSupport library (not a test project) so the
WAL-sidecar cleanup and the "real, not stubbed" rationale live in one place.
Retargeted rather than deleted, in both directions: the S&F WAL test now asserts
against the LocalDb-backed store (WAL genuinely is LocalDb's job), while the
directory-creation test moved to Host.Tests (that guarantee is NOT LocalDb's).
SiteStorageServiceTests.Initialize_EnablesWalJournalMode got the same treatment.
DeploymentManagerMediumFindingsTests induced a persistence failure via an
unopenable path, which no longer reaches the assertion since the fixture now
throws first; it induces the same failure shape via an uninitialized store.
Verified: full solution build 0 warnings; SiteRuntime 532, Host 318,
AuditLog 355, ExternalSystemGateway 142, HealthMonitoring 97,
StoreAndForward 153 — 1597 passed, 0 failed.
Claude-Session: https://claude.ai/code/session_01BL2Vu1ESDQ9SCN4gVKkdts
124 lines
5.3 KiB
C#
124 lines
5.3 KiB
C#
using Microsoft.Data.Sqlite;
|
|
using Microsoft.Extensions.Logging.Abstractions;
|
|
using ZB.MOM.WW.ScadaBridge.SiteRuntime.Persistence;
|
|
using ZB.MOM.WW.ScadaBridge.TestSupport;
|
|
|
|
namespace ZB.MOM.WW.ScadaBridge.SiteRuntime.Tests;
|
|
|
|
/// <summary>
|
|
/// Negative tests verifying design constraints.
|
|
/// </summary>
|
|
public class NegativeTests
|
|
{
|
|
[Fact]
|
|
public async Task Schema_NoAlarmStateTable()
|
|
{
|
|
// Per design decision: no alarm state table in site SQLite schema.
|
|
// The site SQLite stores only deployed configs and static attribute overrides.
|
|
//
|
|
// SiteStorageService takes an ILocalDb now, and LocalDb has no in-memory mode
|
|
// (its Path is a filesystem path), so the service is initialized over a real
|
|
// temp file instead of the "Data Source=:memory:" it used before. The manually
|
|
// built schema subset below is still a plain in-memory SqliteConnection — it is
|
|
// not a LocalDb store, just a scratch database this test asserts against.
|
|
var localDb = TestLocalDb.CreateTemp("negative-schema");
|
|
try
|
|
{
|
|
var storage = new SiteStorageService(
|
|
localDb.Db,
|
|
NullLogger<SiteStorageService>.Instance);
|
|
await storage.InitializeAsync();
|
|
|
|
// Try querying a non-existent alarm_states table — should throw
|
|
await using var connection = new SqliteConnection("Data Source=:memory:");
|
|
await connection.OpenAsync();
|
|
|
|
// Re-initialize on this connection to get the schema
|
|
await using var initCmd = connection.CreateCommand();
|
|
initCmd.CommandText = @"
|
|
CREATE TABLE IF NOT EXISTS deployed_configurations (
|
|
instance_unique_name TEXT PRIMARY KEY,
|
|
config_json TEXT NOT NULL,
|
|
deployment_id TEXT NOT NULL,
|
|
revision_hash TEXT NOT NULL,
|
|
is_enabled INTEGER NOT NULL DEFAULT 1,
|
|
deployed_at TEXT NOT NULL
|
|
);
|
|
CREATE TABLE IF NOT EXISTS static_attribute_overrides (
|
|
instance_unique_name TEXT NOT NULL,
|
|
attribute_name TEXT NOT NULL,
|
|
override_value TEXT NOT NULL,
|
|
updated_at TEXT NOT NULL,
|
|
PRIMARY KEY (instance_unique_name, attribute_name)
|
|
);";
|
|
await initCmd.ExecuteNonQueryAsync();
|
|
|
|
// Verify alarm_states does NOT exist
|
|
await using var checkCmd = connection.CreateCommand();
|
|
checkCmd.CommandText = "SELECT name FROM sqlite_master WHERE type='table' AND name='alarm_states'";
|
|
var result = await checkCmd.ExecuteScalarAsync();
|
|
Assert.Null(result);
|
|
}
|
|
finally
|
|
{
|
|
// Dispose first — the master connection anchors the WAL, so the sidecars
|
|
// cannot be removed while it is open.
|
|
var path = localDb.Path;
|
|
localDb.Dispose();
|
|
TestLocalDb.DeleteFiles(path);
|
|
}
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Schema_NoLocalConfigAuthoring()
|
|
{
|
|
// Per design: sites cannot author/modify template configurations locally.
|
|
// The SQLite schema has no template tables or editing tables.
|
|
await using var connection = new SqliteConnection("Data Source=:memory:");
|
|
await connection.OpenAsync();
|
|
|
|
await using var initCmd = connection.CreateCommand();
|
|
initCmd.CommandText = @"
|
|
CREATE TABLE IF NOT EXISTS deployed_configurations (
|
|
instance_unique_name TEXT PRIMARY KEY,
|
|
config_json TEXT NOT NULL,
|
|
deployment_id TEXT NOT NULL,
|
|
revision_hash TEXT NOT NULL,
|
|
is_enabled INTEGER NOT NULL DEFAULT 1,
|
|
deployed_at TEXT NOT NULL
|
|
);
|
|
CREATE TABLE IF NOT EXISTS static_attribute_overrides (
|
|
instance_unique_name TEXT NOT NULL,
|
|
attribute_name TEXT NOT NULL,
|
|
override_value TEXT NOT NULL,
|
|
updated_at TEXT NOT NULL,
|
|
PRIMARY KEY (instance_unique_name, attribute_name)
|
|
);";
|
|
await initCmd.ExecuteNonQueryAsync();
|
|
|
|
// Verify no template editing tables exist
|
|
await using var checkCmd = connection.CreateCommand();
|
|
checkCmd.CommandText = "SELECT COUNT(*) FROM sqlite_master WHERE type='table'";
|
|
var tableCount = (long)(await checkCmd.ExecuteScalarAsync())!;
|
|
|
|
// Only 2 tables in this manually-created schema (tests the constraint that
|
|
// no template editing tables exist in the manually-created subset)
|
|
Assert.Equal(2, tableCount);
|
|
}
|
|
|
|
[Fact]
|
|
public void SiteNode_DoesNotBindHttpPorts()
|
|
{
|
|
// Per design: site nodes use Host.CreateDefaultBuilder (not WebApplication.CreateBuilder).
|
|
// This is verified structurally — the site path in Program.cs does not configure Kestrel.
|
|
// This test documents the constraint; the actual verification is in the Program.cs code.
|
|
|
|
// The SiteRuntime project does not reference ASP.NET Core packages
|
|
var siteRuntimeAssembly = typeof(SiteRuntimeOptions).Assembly;
|
|
var referencedAssemblies = siteRuntimeAssembly.GetReferencedAssemblies();
|
|
|
|
Assert.DoesNotContain(referencedAssemblies,
|
|
a => a.Name != null && a.Name.Contains("AspNetCore"));
|
|
}
|
|
}
|