Joseph Doherty
7b0b9c7365
Solution + 23 src projects + 26 test projects renamed; folders, csproj, namespaces, and ScadaLinkDbContext/ScadaBridgeDbContext class updated. ActorSystem "scadalink" → "scadabridge", Akka seed-node URLs migrated. SQL roles/logins, LDAP domains, CLI command name, and CLI config dir (~/.scadalink → ~/.scadabridge) also renamed. Build green; 5 Host.Tests fail awaiting SQL login rename in next commit. Pre-existing StaleTagMonitor timing flakes unchanged. Rename script committed at tools/rename-to-scadabridge.sh.
106 lines
4.0 KiB
C#
106 lines
4.0 KiB
C#
using System.Security.Claims;
|
|
using Bunit;
|
|
using Microsoft.AspNetCore.Components.Authorization;
|
|
using Microsoft.Extensions.DependencyInjection;
|
|
using Microsoft.Extensions.Logging.Abstractions;
|
|
using Microsoft.Extensions.Options;
|
|
using NSubstitute;
|
|
using ZB.MOM.WW.ScadaBridge.CentralUI.Components.Shared;
|
|
using ZB.MOM.WW.ScadaBridge.Commons.Entities.Sites;
|
|
using ZB.MOM.WW.ScadaBridge.Commons.Interfaces.Repositories;
|
|
using ZB.MOM.WW.ScadaBridge.Commons.Interfaces.Services;
|
|
using ZB.MOM.WW.ScadaBridge.Communication;
|
|
using ZB.MOM.WW.ScadaBridge.DeploymentManager;
|
|
using SitesPage = ZB.MOM.WW.ScadaBridge.CentralUI.Components.Pages.Admin.Sites;
|
|
|
|
namespace ZB.MOM.WW.ScadaBridge.CentralUI.Tests.Admin;
|
|
|
|
/// <summary>
|
|
/// Regression tests for CentralUI-012. The Sites page loaded all sites and then
|
|
/// issued <c>GetDataConnectionsBySiteIdAsync</c> once per site (N+1 database
|
|
/// round-trips on every load and post-delete refresh). The fix fetches all
|
|
/// data connections in a single <c>GetAllDataConnectionsAsync</c> call and
|
|
/// groups them client-side.
|
|
/// </summary>
|
|
public class SitesPageTests : BunitContext
|
|
{
|
|
private readonly ISiteRepository _siteRepo = Substitute.For<ISiteRepository>();
|
|
|
|
private void RegisterServices()
|
|
{
|
|
Services.AddSingleton(_siteRepo);
|
|
|
|
var comms = new CommunicationService(
|
|
Options.Create(new CommunicationOptions()),
|
|
NullLogger<CommunicationService>.Instance);
|
|
Services.AddSingleton(comms);
|
|
|
|
var artifactSvc = new ArtifactDeploymentService(
|
|
_siteRepo,
|
|
Substitute.For<IDeploymentManagerRepository>(),
|
|
Substitute.For<ITemplateEngineRepository>(),
|
|
Substitute.For<IExternalSystemRepository>(),
|
|
Substitute.For<INotificationRepository>(),
|
|
comms,
|
|
Substitute.For<IAuditService>(),
|
|
Options.Create(new DeploymentManagerOptions()),
|
|
NullLogger<ArtifactDeploymentService>.Instance);
|
|
Services.AddSingleton(artifactSvc);
|
|
|
|
Services.AddSingleton<IDialogService>(Substitute.For<IDialogService>());
|
|
|
|
var identity = new ClaimsIdentity(
|
|
new[] { new Claim(ClaimTypes.Name, "admin") }, "TestCookie");
|
|
var authState = new AuthenticationState(new ClaimsPrincipal(identity));
|
|
Services.AddSingleton<AuthenticationStateProvider>(
|
|
new StubAuthStateProvider(authState));
|
|
}
|
|
|
|
private sealed class StubAuthStateProvider : AuthenticationStateProvider
|
|
{
|
|
private readonly AuthenticationState _state;
|
|
public StubAuthStateProvider(AuthenticationState state) => _state = state;
|
|
public override Task<AuthenticationState> GetAuthenticationStateAsync()
|
|
=> Task.FromResult(_state);
|
|
}
|
|
|
|
private static List<Site> Sites(params int[] ids)
|
|
=> ids.Select(id => new Site($"Site{id}", $"SITE-{id}") { Id = id }).ToList();
|
|
|
|
private static DataConnection Conn(int siteId, string name)
|
|
=> new(name, "OpcUa", siteId);
|
|
|
|
[Fact]
|
|
public void LoadData_FetchesAllConnectionsInOneQuery_NoPerSiteQueries()
|
|
{
|
|
RegisterServices();
|
|
_siteRepo.GetAllSitesAsync().Returns(Sites(1, 2, 3));
|
|
_siteRepo.GetAllDataConnectionsAsync().Returns(new List<DataConnection>
|
|
{
|
|
Conn(1, "c1"), Conn(2, "c2"), Conn(3, "c3"),
|
|
});
|
|
|
|
Render<SitesPage>();
|
|
|
|
// Regression: exactly one bulk query, and zero per-site queries.
|
|
_siteRepo.Received(1).GetAllDataConnectionsAsync();
|
|
_siteRepo.DidNotReceive().GetDataConnectionsBySiteIdAsync(Arg.Any<int>());
|
|
}
|
|
|
|
[Fact]
|
|
public void LoadData_GroupsConnectionsBySite_AndRendersThem()
|
|
{
|
|
RegisterServices();
|
|
_siteRepo.GetAllSitesAsync().Returns(Sites(1, 2));
|
|
_siteRepo.GetAllDataConnectionsAsync().Returns(new List<DataConnection>
|
|
{
|
|
Conn(1, "alpha-conn"), Conn(2, "beta-conn"),
|
|
});
|
|
|
|
var cut = Render<SitesPage>();
|
|
|
|
Assert.Contains("alpha-conn", cut.Markup);
|
|
Assert.Contains("beta-conn", cut.Markup);
|
|
}
|
|
}
|