Joseph Doherty
7b0b9c7365
Solution + 23 src projects + 26 test projects renamed; folders, csproj, namespaces, and ScadaLinkDbContext/ScadaBridgeDbContext class updated. ActorSystem "scadalink" → "scadabridge", Akka seed-node URLs migrated. SQL roles/logins, LDAP domains, CLI command name, and CLI config dir (~/.scadalink → ~/.scadabridge) also renamed. Build green; 5 Host.Tests fail awaiting SQL login rename in next commit. Pre-existing StaleTagMonitor timing flakes unchanged. Rename script committed at tools/rename-to-scadabridge.sh.
4.5 KiB
Code Reviews
Comprehensive, per-module code reviews of the ScadaBridge codebase. Each module (one
buildable project under src/) has its own folder containing a findings.md. This
README is the aggregated index — the single place to see all outstanding work.
Generated by
regen-readme.pyfrom the per-modulefindings.mdfiles. Do not edit by hand — edit the findings files and re-run the script.
How it works
- Reviews are performed one module at a time against a fixed checklist.
- Every finding is recorded in the module's
findings.mdwith a severity and status. - Findings are never deleted — they are closed by changing their status, keeping a full audit trail.
- This README aggregates every pending finding (
Open/In Progress) across all modules.
See REVIEW-PROCESS.md for the full procedure: the review checklist, severity definitions, finding format, and how to mark items resolved.
Layout
code-reviews/
├── README.md # this file — process overview + pending findings
├── REVIEW-PROCESS.md # how to perform a review and track findings
├── regen-readme.py # regenerates this README from the findings files
├── _template/findings.md # copy-this template for a module review
└── <Module>/findings.md # one folder per src/ project
Baseline review — 2026-05-16
All 19 modules were reviewed at commit 9c60592 (241 findings: 6 Critical, 46 High,
100 Medium, 89 Low). The tables below track what remains open as findings are
resolved and re-triaged; findings discovered after the baseline are appended to their
module file and counted in Total.
| Severity | Open findings |
|---|---|
| Critical | 0 |
| High | 0 |
| Medium | 0 |
| Low | 0 |
| Total | 0 |
Module Status
| Module | Last reviewed | Commit | Open (C/H/M/L) | Open | Total |
|---|---|---|---|---|---|
| AuditLog | 2026-05-28 | 1eb6e97 |
0/0/0/0 | 0 | 11 |
| CLI | 2026-05-28 | 1eb6e97 |
0/0/0/0 | 0 | 23 |
| CentralUI | 2026-05-28 | 1eb6e97 |
0/0/0/0 | 0 | 33 |
| ClusterInfrastructure | 2026-05-28 | 1eb6e97 |
0/0/0/0 | 0 | 14 |
| Commons | 2026-05-28 | 1eb6e97 |
0/0/0/0 | 0 | 23 |
| Communication | 2026-05-28 | 1eb6e97 |
0/0/0/0 | 0 | 22 |
| ConfigurationDatabase | 2026-05-28 | 1eb6e97 |
0/0/0/0 | 0 | 24 |
| DataConnectionLayer | 2026-05-28 | 1eb6e97 |
0/0/0/0 | 0 | 22 |
| DeploymentManager | 2026-05-28 | 1eb6e97 |
0/0/0/0 | 0 | 24 |
| ExternalSystemGateway | 2026-05-28 | 1eb6e97 |
0/0/0/0 | 0 | 23 |
| HealthMonitoring | 2026-05-28 | 1eb6e97 |
0/0/0/0 | 0 | 23 |
| Host | 2026-05-28 | 1eb6e97 |
0/0/0/0 | 0 | 22 |
| InboundAPI | 2026-05-28 | 1eb6e97 |
0/0/0/0 | 0 | 25 |
| ManagementService | 2026-05-28 | 1eb6e97 |
0/0/0/0 | 0 | 23 |
| NotificationOutbox | 2026-05-28 | 1eb6e97 |
0/0/0/0 | 0 | 10 |
| NotificationService | 2026-05-28 | 1eb6e97 |
0/0/0/0 | 0 | 25 |
| Security | 2026-05-28 | 1eb6e97 |
0/0/0/0 | 0 | 21 |
| SiteCallAudit | 2026-05-28 | 1eb6e97 |
0/0/0/0 | 0 | 6 |
| SiteEventLogging | 2026-05-28 | 1eb6e97 |
0/0/0/0 | 0 | 23 |
| SiteRuntime | 2026-05-28 | 1eb6e97 |
0/0/0/0 | 0 | 26 |
| StoreAndForward | 2026-05-28 | 1eb6e97 |
0/0/0/0 | 0 | 24 |
| TemplateEngine | 2026-05-28 | 1eb6e97 |
0/0/0/0 | 0 | 22 |
| Transport | 2026-05-28 | 1eb6e97 |
0/0/0/0 | 0 | 12 |
Pending Findings
Every Open / In Progress finding across all modules, highest severity first.
Resolved findings drop off this list but remain recorded in their module's
findings.md (see REVIEW-PROCESS.md §4–§5). Full detail —
description, location, recommendation — lives in the module's findings.md.
Critical (0)
None open.
High (0)
None open.
Medium (0)
None open.
Low (0)
None open.