using Microsoft.AspNetCore.Antiforgery; using Microsoft.AspNetCore.Authentication.Cookies; using Microsoft.AspNetCore.Builder; using Microsoft.AspNetCore.Http; using Microsoft.AspNetCore.Routing; using Microsoft.Extensions.DependencyInjection; using Microsoft.Extensions.Logging; using Microsoft.Extensions.Options; using NSubstitute; using NSubstitute.ExceptionExtensions; using ZB.MOM.WW.Auth.Abstractions.Ldap; using ZB.MOM.WW.Auth.Abstractions.Roles; using ZB.MOM.WW.ScadaBridge.CentralUI.Auth; using ZB.MOM.WW.ScadaBridge.Security; namespace ZB.MOM.WW.ScadaBridge.CentralUI.Tests.Auth; /// /// ScadaBridge#144 — POST /auth/login refuses a successful LDAP bind whose groups map to no /// ScadaBridge role, and one whose role mapping throws. The refusal must be indistinguishable from a /// bad password: the same redirect and message, no session cookie, and a login-throttle failure. The /// reason is logged server-side with the username. /// public class AuthLoginRoleRefusalTests { private const string Category = AuthEndpoints.LoggerCategory; private sealed record Outcome(int Status, string Location, IReadOnlyList SetCookies); private static RequestDelegate LoginDelegate() { var builder = WebApplication.CreateBuilder(); builder.Services.AddRouting(); builder.Services.AddAntiforgery(); builder.Services.AddSingleton(); builder.Services.AddSingleton(TimeProvider.System); using var app = builder.Build(); app.MapAuthEndpoints(); return ((IEndpointRouteBuilder)app).DataSources .SelectMany(ds => ds.Endpoints) .OfType() .Single(e => e.RoutePattern.RawText == "/auth/login" && (e.Metadata.GetMetadata()?.HttpMethods.Contains("POST") ?? false)) .RequestDelegate!; } /// Builds the service rig: LDAP accepts alice/password (groups ["G"]) and rejects alice/wrong. private static ServiceProvider Services( IGroupRoleMapper mapper, LoginThrottle throttle, CapturingLoggerProvider logs) { var services = new ServiceCollection(); services.AddLogging(b => b.AddProvider(logs)); services.AddAntiforgery(); services.AddAuthentication(CookieAuthenticationDefaults.AuthenticationScheme).AddCookie(); services.AddSingleton(throttle); var ldap = Substitute.For(); ldap.AuthenticateAsync("alice", "password", Arg.Any()) .Returns(LdapAuthResult.Success("alice", "Alice", ["Domain Users"])); ldap.AuthenticateAsync("alice", "wrong", Arg.Any()) .Returns(LdapAuthResult.Fail(LdapAuthFailure.BadCredentials)); services.AddSingleton(ldap); services.AddSingleton(mapper); return services.BuildServiceProvider(); } private static async Task PostLogin(ServiceProvider provider, string password) { var tokenContext = new DefaultHttpContext { RequestServices = provider }; var tokens = provider.GetRequiredService().GetAndStoreTokens(tokenContext); var antiforgeryCookie = tokenContext.Response.Headers.SetCookie.Single()!.Split(';')[0]; var context = new DefaultHttpContext { RequestServices = provider }; context.Connection.RemoteIpAddress = System.Net.IPAddress.Loopback; context.Request.Headers.Cookie = antiforgeryCookie; context.Request.Method = "POST"; context.Request.ContentType = "application/x-www-form-urlencoded"; var form = $"username=alice&password={password}&{tokens.FormFieldName}={Uri.EscapeDataString(tokens.RequestToken!)}"; context.Request.Body = new MemoryStream(System.Text.Encoding.UTF8.GetBytes(form)); await LoginDelegate()(context); return new Outcome( context.Response.StatusCode, context.Response.Headers.Location.ToString(), context.Response.Headers.SetCookie.Select(v => v!).ToList()); } private static IGroupRoleMapper MapperReturning(params string[] roles) { var mapper = Substitute.For>(); mapper.MapAsync(Arg.Any>(), Arg.Any()) .Returns(new GroupRoleMapping(roles, Scope: new RoleMappingResult(roles, [], true))); return mapper; } private static IGroupRoleMapper MapperThrowing() { var mapper = Substitute.For>(); mapper.MapAsync(Arg.Any>(), Arg.Any()) .ThrowsAsync(new InvalidOperationException("configuration database unreachable")); return mapper; } private static LoginThrottle Throttle(int maxFailures = 5) => new(TimeProvider.System, Options.Create(new SecurityOptions { MaxLoginFailuresPerWindow = maxFailures, PerIpMaxFailures = 25, })); private static bool HasSessionCookie(Outcome o) => o.SetCookies.Any(v => v.StartsWith(".AspNetCore.Cookies=", StringComparison.Ordinal)); /// The bad-password response every refusal must match exactly. private static async Task BadPasswordOutcome() { using var provider = Services(MapperReturning(Roles.Viewer), Throttle(), new CapturingLoggerProvider()); return await PostLogin(provider, "wrong"); } /// A bind whose groups map to zero roles is refused exactly like a bad password, and logged. /// A task that represents the asynchronous operation. [Fact] public async Task Login_ZeroRoles_IsRefusedLikeABadPassword_NoCookie_Logged() { var logs = new CapturingLoggerProvider(); using var provider = Services(MapperReturning(), Throttle(), logs); var outcome = await PostLogin(provider, "password"); var badPassword = await BadPasswordOutcome(); Assert.Equal(StatusCodes.Status302Found, outcome.Status); Assert.Equal(badPassword.Status, outcome.Status); Assert.Equal(badPassword.Location, outcome.Location); Assert.Equal("/login?error=" + Uri.EscapeDataString(LdapAuthFailureMessages.InvalidCredentials), outcome.Location); Assert.False(HasSessionCookie(outcome)); var entry = Assert.Single(logs.Entries, e => e.Category == Category && e.Level == LogLevel.Warning); Assert.Contains("alice", entry.Message); Assert.Contains("maps to a ScadaBridge role", entry.Message); } /// A bind whose role mapping throws is refused exactly like a bad password, and logged with the exception. /// A task that represents the asynchronous operation. [Fact] public async Task Login_MapperThrows_IsRefusedLikeABadPassword_NoCookie_Logged() { var logs = new CapturingLoggerProvider(); using var provider = Services(MapperThrowing(), Throttle(), logs); var outcome = await PostLogin(provider, "password"); var badPassword = await BadPasswordOutcome(); Assert.Equal(badPassword.Status, outcome.Status); Assert.Equal(badPassword.Location, outcome.Location); Assert.False(HasSessionCookie(outcome)); var entry = Assert.Single(logs.Entries, e => e.Category == Category && e.Level == LogLevel.Warning); Assert.Contains("alice", entry.Message); Assert.Contains("role mapping failed", entry.Message); Assert.IsType(entry.Exception); } /// /// A zero-role refusal counts against the login throttle like a bad password, so the throttle /// cannot be used to tell "right password, no role" apart from "wrong password". /// /// A task that represents the asynchronous operation. [Fact] public async Task Login_ZeroRoles_CountsAsAThrottleFailure() { var throttle = Throttle(maxFailures: 2); using var provider = Services(MapperReturning(), throttle, new CapturingLoggerProvider()); await PostLogin(provider, "password"); await PostLogin(provider, "password"); Assert.True(throttle.IsLockedOut("alice", System.Net.IPAddress.Loopback.ToString())); } /// One mapped role still signs in and sets the session cookie, with no refusal logged. /// A task that represents the asynchronous operation. [Fact] public async Task Login_OneRole_SignsIn() { var logs = new CapturingLoggerProvider(); using var provider = Services(MapperReturning(Roles.Viewer), Throttle(), logs); var outcome = await PostLogin(provider, "password"); Assert.Equal(StatusCodes.Status302Found, outcome.Status); Assert.Equal("/", outcome.Location); Assert.True(HasSessionCookie(outcome)); Assert.DoesNotContain(logs.Entries, e => e.Category == Category && e.Level >= LogLevel.Warning); } }