using ZB.MOM.WW.ScadaBridge.Commons.Messages.Management; using ZB.MOM.WW.ScadaBridge.ManagementService; namespace ZB.MOM.WW.ScadaBridge.ManagementService.Tests; /// /// Tests for request-body parsing /// (findings ManagementService-006 / -013). /// public class ManagementEndpointsTests { [Fact] public void ParseCommand_WithExplicitPayload_DeserializesIntoCommandType() { var json = """{ "command": "CreateSite", "payload": { "name": "Site1", "siteIdentifier": "SITE1", "description": "Desc" } }"""; var result = ManagementEndpoints.ParseCommand(json); Assert.True(result.Success); var command = Assert.IsType(result.Command); Assert.Equal("Site1", command.Name); Assert.Equal("SITE1", command.SiteIdentifier); Assert.Equal("Desc", command.Description); } /// /// P7-6: MgmtDeploySiteCommand.Force is an ADDITIVE field, so a client /// that predates it — every CLI older than this change, and every scripted /// HTTP caller — must keep working and must land on the SAFE default. Absent /// means false means "skip instances whose config is unchanged", which /// is the non-destructive behaviour; only an explicit true restores the /// unconditional redeploy. /// [Theory] [InlineData("""{ "command": "MgmtDeploySite", "payload": { "siteId": 7 } }""", false)] [InlineData("""{ "command": "MgmtDeploySite", "payload": { "siteId": 7, "force": false } }""", false)] [InlineData("""{ "command": "MgmtDeploySite", "payload": { "siteId": 7, "force": true } }""", true)] public void ParseCommand_DeploySite_ForceDefaultsToTheNonDestructiveBehaviour(string json, bool expectedForce) { var result = ManagementEndpoints.ParseCommand(json); Assert.True(result.Success); var command = Assert.IsType(result.Command); Assert.Equal(7, command.SiteId); Assert.Equal(expectedForce, command.Force); } [Fact] public void ParseCommand_WithMissingPayload_DeserializesParameterlessCommand() { // No "payload" field at all -- the fallback must not allocate a throwaway // JsonDocument and must still produce a valid parameterless command. var json = """{ "command": "ListTemplates" }"""; var result = ManagementEndpoints.ParseCommand(json); Assert.True(result.Success); Assert.IsType(result.Command); } [Fact] public void ParseCommand_WithInvalidJson_ReturnsFailure() { var result = ManagementEndpoints.ParseCommand("{ not json"); Assert.False(result.Success); Assert.Equal("BAD_REQUEST", result.ErrorCode); } [Fact] public void ParseCommand_WithMissingCommandField_ReturnsFailure() { var result = ManagementEndpoints.ParseCommand("""{ "payload": {} }"""); Assert.False(result.Success); Assert.Equal("BAD_REQUEST", result.ErrorCode); } [Fact] public void ParseCommand_WithUnknownCommand_ReturnsFailure() { var result = ManagementEndpoints.ParseCommand("""{ "command": "NoSuchCommand" }"""); Assert.False(result.Success); Assert.Equal("BAD_REQUEST", result.ErrorCode); } // ======================================================================== // Command-timeout configuration (finding ManagementService-010) // // ManagementServiceOptions.CommandTimeout must actually drive the Ask // timeout instead of a hard-coded 30s constant. // ======================================================================== [Fact] public void ResolveAskTimeout_UsesConfiguredCommandTimeout() { var options = new ManagementServiceOptions { CommandTimeout = TimeSpan.FromSeconds(75) }; var timeout = ManagementEndpoints.ResolveAskTimeout(options); Assert.Equal(TimeSpan.FromSeconds(75), timeout); } [Fact] public void ResolveAskTimeout_WithNullOptions_FallsBackToDefault() { var timeout = ManagementEndpoints.ResolveAskTimeout(null); Assert.Equal(TimeSpan.FromSeconds(30), timeout); } [Fact] public void ResolveAskTimeout_WithNonPositiveTimeout_FallsBackToDefault() { // A misconfigured zero/negative timeout would make every Ask fail // immediately; fall back to the safe default instead. var options = new ManagementServiceOptions { CommandTimeout = TimeSpan.Zero }; var timeout = ManagementEndpoints.ResolveAskTimeout(options); Assert.Equal(TimeSpan.FromSeconds(30), timeout); } // ======================================================================== // Per-command long-running Ask timeout (arch-review S1) // // Transport/deploy commands legitimately run for minutes; they must use the // LongRunningCommandTimeout (default 5 min) instead of the 30 s default. // ======================================================================== [Theory] [InlineData(typeof(ImportBundleCommand))] [InlineData(typeof(ExportBundleCommand))] [InlineData(typeof(PreviewBundleCommand))] [InlineData(typeof(MgmtDeployArtifactsCommand))] [InlineData(typeof(MgmtDeployInstanceCommand))] public void ResolveAskTimeout_LongRunningCommand_UsesLongTimeout(Type cmd) => Assert.Equal(TimeSpan.FromMinutes(5), ManagementEndpoints.ResolveAskTimeout(null, cmd)); [Fact] public void ResolveAskTimeout_OrdinaryCommand_UsesDefault() => Assert.Equal(TimeSpan.FromSeconds(30), ManagementEndpoints.ResolveAskTimeout(null, typeof(ListTemplatesCommand))); [Fact] public void ResolveAskTimeout_ConfiguredLongTimeout_Honored() => Assert.Equal(TimeSpan.FromMinutes(10), ManagementEndpoints.ResolveAskTimeout( new ManagementServiceOptions { LongRunningCommandTimeout = TimeSpan.FromMinutes(10) }, typeof(ImportBundleCommand))); }