LocalDb adoption Phase 1 + 2: consolidate the site database, delete the bespoke replicators #23
+11
-13
@@ -146,20 +146,18 @@
|
||||
</ItemGroup>
|
||||
|
||||
<!--
|
||||
GHSA-pgww-w46g-26qg (NU1902, moderate) is on AngleSharp 1.1.1, pulled in TRANSITIVELY by
|
||||
bunit into ZB.MOM.WW.ScadaBridge.CentralUI.Tests. With TreatWarningsAsErrors this made the
|
||||
WHOLE SOLUTION BUILD RED — `dotnet build ZB.MOM.WW.ScadaBridge.slnx` failed on clean main,
|
||||
so no test suite could run and every "0 warnings / suite green" gate was unverifiable.
|
||||
GHSA-pgww-w46g-26qg (NU1902, moderate) on AngleSharp, reached only transitively via bunit
|
||||
in ZB.MOM.WW.ScadaBridge.CentralUI.Tests. With TreatWarningsAsErrors it made the WHOLE
|
||||
SOLUTION BUILD RED, so no suite could run and every "0 warnings / green" gate was
|
||||
unverifiable.
|
||||
|
||||
Fixed the same way HistorianGateway fixed the identical break (historiangw @ 6bc005d):
|
||||
an explicit test-only pin to a patched AngleSharp. TEST-ONLY — AngleSharp is a bunit
|
||||
(HTML-parsing) dependency and reaches no production project, so this cannot affect runtime.
|
||||
|
||||
Do not "fix" this by bumping bunit: 2.0.33-preview is the current preview line and still
|
||||
resolves the vulnerable AngleSharp transitively. Pinning the leaf is the fix.
|
||||
Resolved with a scoped NuGetAuditSuppress in that ONE test project (see its csproj for the
|
||||
full rationale) — deliberately NOT a version pin here. A pin was tried first and reverted:
|
||||
AngleSharp >= 1.5.0 is the only patched line, and it changes IHtmlCollection<T>'s indexer,
|
||||
which makes every bunit build throw MissingMethodException at runtime (33 render tests
|
||||
failed). Bumping bunit does not help either — even 2.7.2 resolves AngleSharp 1.4.0, which
|
||||
is still vulnerable. There is no working patched combination upstream today.
|
||||
-->
|
||||
<ItemGroup>
|
||||
<PackageVersion Include="AngleSharp" Version="1.5.2" />
|
||||
</ItemGroup>
|
||||
|
||||
|
||||
</Project>
|
||||
|
||||
+24
-3
@@ -10,9 +10,6 @@
|
||||
|
||||
<ItemGroup>
|
||||
<PackageReference Include="bunit" />
|
||||
<!-- Security pin: GHSA-pgww-w46g-26qg. bunit pulls the vulnerable AngleSharp
|
||||
1.1.1 transitively; 1.5.2 patches it. Test-only, no production reach. -->
|
||||
<PackageReference Include="AngleSharp" />
|
||||
<PackageReference Include="coverlet.collector" />
|
||||
<PackageReference Include="Microsoft.AspNetCore.TestHost" />
|
||||
<PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" />
|
||||
@@ -43,4 +40,28 @@
|
||||
<ProjectReference Include="../../src/ZB.MOM.WW.ScadaBridge.ConfigurationDatabase/ZB.MOM.WW.ScadaBridge.ConfigurationDatabase.csproj" />
|
||||
</ItemGroup>
|
||||
|
||||
<!--
|
||||
GHSA-pgww-w46g-26qg (NU1902, moderate) on AngleSharp, reached ONLY transitively via
|
||||
bunit. Suppressed here, scoped to this one test project, because there is verifiably
|
||||
no version combination that resolves it:
|
||||
|
||||
- AngleSharp < 1.5.0 is vulnerable (1.4.0 is what even the newest bunit resolves).
|
||||
- AngleSharp >= 1.5.0 changed IHtmlCollection<T>'s indexer, so every bunit build
|
||||
throws MissingMethodException at runtime - 33 CentralUI render tests fail.
|
||||
- Bumping bunit does not help: checked up to 2.7.2, still AngleSharp 1.4.0.
|
||||
|
||||
So the choice is a suppressed advisory or an unbuildable/failing test suite. Scoped
|
||||
suppression wins because the reach is genuinely nil: AngleSharp is an HTML parser used
|
||||
by bunit to assert on rendered markup in unit tests. It ships in no production project
|
||||
and processes no untrusted input - the "documents" it parses are our own components'
|
||||
output. Revisit when bunit ships against AngleSharp 1.5+.
|
||||
|
||||
NOT the same call as GHSA-2m69-gcr7-jv3q (SQLitePCLRaw): that suppression was removed
|
||||
in 2026-07 precisely because it was masking a vulnerability in PRODUCTION code paths.
|
||||
This one is test-only, and a patched-but-working version does not exist upstream.
|
||||
-->
|
||||
<ItemGroup>
|
||||
<NuGetAuditSuppress Include="https://github.com/advisories/GHSA-pgww-w46g-26qg" />
|
||||
</ItemGroup>
|
||||
|
||||
</Project>
|
||||
Reference in New Issue
Block a user