dohertj2/ScadaBridge
1
0
Fork 0
Code Issues 15 Pull Requests Actions Packages Projects Releases Wiki Activity

DebugAlarmStateDto lacks AckTime; snapshot-seeded alarm rows show a null ack time #84

New Issue
Closed
opened 2026-11-09 12:43:21 -05:00 by dohertj2 · 1 comment
dohertj2 commented 2026-11-09 12:43:21 -05:00
Owner
Copy Link
Copy Source

The live alarm stream (AlarmStateUpdate) carries the ack time (field 24) but the snapshot DTO DebugAlarmStateDto does not, so rows seeded from a debug snapshot show a null ack time until the next live update. The golden sample test does not cover it. Found while adding IsMesReportable (#60). Add an additive field + mapping + golden coverage.

The live alarm stream (`AlarmStateUpdate`) carries the ack time (field 24) but the snapshot DTO `DebugAlarmStateDto` does not, so rows seeded from a debug snapshot show a null ack time until the next live update. The golden sample test does not cover it. Found while adding IsMesReportable (#60). Add an additive field + mapping + golden coverage.
dohertj2 added the type:bugpriority:p3 labels 2026-11-09 12:43:21 -05:00
dohertj2 commented 2026-11-09 12:55:14 -05:00
Author
Owner
Copy Link
Copy Source

Fixed on main d3682563: DebugAlarmStateDto gains google.protobuf.Timestamp ack_time = 21 (additive; absent → null, incl. from an older site), C# regenerated via docker/regen-proto.sh sitecommand, mapped both ways in SiteCommandDtoMapper. Golden: native sample sets AckTime, computed leaves it null. Evidence: Communication.Tests 816/816; 3 golden tests fail with the mapper change reverted. Component-SiteRuntime.md refreshed in the same push (it still claimed IsMesReportable was not on the wire).

Fixed on main d3682563: DebugAlarmStateDto gains `google.protobuf.Timestamp ack_time = 21` (additive; absent → null, incl. from an older site), C# regenerated via docker/regen-proto.sh sitecommand, mapped both ways in SiteCommandDtoMapper. Golden: native sample sets AckTime, computed leaves it null. Evidence: Communication.Tests 816/816; 3 golden tests fail with the mapper change reverted. Component-SiteRuntime.md refreshed in the same push (it still claimed IsMesReportable was not on the wire).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
blocked
Blocked by dependency or external hold
 cross-repo
Needs coordinated change in another family repo (wire contract etc.)
 migrated
Migrated from a markdown backlog (2026-11 standardization)
 priority:p0
Must-have / blocking
 priority:p1
High priority
 priority:p2
Normal priority
 priority:p3
Low priority / nice to have
 type:bug
Defect in shipped behaviour
 type:debt
Technical debt / hygiene
 type:deploy-gate
Rollout/deploy/migration step not yet done on an environment
 type:docs
Documentation work
 type:feature
Feature implementation
 type:followup
Follow-up deferred from a plan, PR or gate
 type:infra
Infrastructure and scaffolding
 type:review-finding
Unfixed finding from an architecture/code review
 type:test
Test work
No Label priority:p3 type:bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/ScadaBridge#84
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?