dohertj2/ScadaBridge
1
0
Fork 0
Code Issues 42 Pull Requests Actions Packages Projects Releases Wiki Activity

Unify the InboundAPI IActiveNodeGate with the shared ZB.MOM.WW.Health IActiveNodeGate #80

New Issue
Open
opened 2026-11-06 15:26:20 -05:00 by dohertj2 · 0 comments
dohertj2 commented 2026-11-06 15:26:20 -05:00
Owner
Copy Link
Copy Source

ScadaBridge has its own ZB.MOM.WW.ScadaBridge.InboundAPI.IActiveNodeGate, implemented by src/ZB.MOM.WW.ScadaBridge.Host/Health/ActiveNodeGate.cs and used by InboundApiEndpointFilter to return 503 on a standby. Its logic matches the shared ZB.MOM.WW.Health IActiveNodeGate/AkkaActiveNodeGate (both route to oldest-Up via ClusterActiveNode/ClusterActivityEvaluator), but it is a separate interface. Health gap L2 / backlog item #3 was deferred because unifying it touches the inbound-API path.

Current state: still separate (verified 2026-11-06). Fix: register the shared gate and have the inbound filter consume ZB.MOM.WW.Health.IActiveNodeGate, then delete the local interface and implementation. Keep the warm-up behaviour (not active until the ActorSystem exists and the member is Up).

Source: scadaproj components/health/GAPS.md (Gap L2; "#3 IActiveNodeGate seam unification (ScadaBridge) — DEFERRED")

ScadaBridge has its own `ZB.MOM.WW.ScadaBridge.InboundAPI.IActiveNodeGate`, implemented by `src/ZB.MOM.WW.ScadaBridge.Host/Health/ActiveNodeGate.cs` and used by `InboundApiEndpointFilter` to return 503 on a standby. Its logic matches the shared `ZB.MOM.WW.Health` `IActiveNodeGate`/`AkkaActiveNodeGate` (both route to oldest-Up via `ClusterActiveNode`/`ClusterActivityEvaluator`), but it is a separate interface. Health gap L2 / backlog item #3 was deferred because unifying it touches the inbound-API path. **Current state:** still separate (verified 2026-11-06). Fix: register the shared gate and have the inbound filter consume `ZB.MOM.WW.Health.IActiveNodeGate`, then delete the local interface and implementation. Keep the warm-up behaviour (not active until the ActorSystem exists and the member is Up). Source: scadaproj `components/health/GAPS.md` (Gap L2; "#3 IActiveNodeGate seam unification (ScadaBridge) — DEFERRED")
dohertj2 added the type:debtpriority:p3cross-repomigrated labels 2026-11-06 15:26:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
blocked
Blocked by dependency or external hold
 cross-repo
Needs coordinated change in another family repo (wire contract etc.)
 migrated
Migrated from a markdown backlog (2026-11 standardization)
 priority:p0
Must-have / blocking
 priority:p1
High priority
 priority:p2
Normal priority
 priority:p3
Low priority / nice to have
 type:bug
Defect in shipped behaviour
 type:debt
Technical debt / hygiene
 type:deploy-gate
Rollout/deploy/migration step not yet done on an environment
 type:docs
Documentation work
 type:feature
Feature implementation
 type:followup
Follow-up deferred from a plan, PR or gate
 type:infra
Infrastructure and scaffolding
 type:review-finding
Unfixed finding from an architecture/code review
 type:test
Test work
No Label cross-repo migrated priority:p3 type:debt
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/ScadaBridge#80
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?