dohertj2/ScadaBridge
1
0
Fork 0
Code Issues 42 Pull Requests Actions Packages Projects Releases Wiki Activity

Move ICentralHealthAggregator and SiteHealthState to Commons (Communication → HealthMonitoring layering) #71

New Issue
Open
opened 2026-11-06 15:24:45 -05:00 by dohertj2 · 0 comments
dohertj2 commented 2026-11-06 15:24:45 -05:00
Owner
Copy Link
Copy Source

Deferred from architecture review 08: CentralCommunicationActor consumes ICentralHealthAggregator (HealthMonitoring), an inverted layering. Moving the interface + SiteHealthState to Commons ripples across 5 projects for a cosmetic fix, so it was deferred.

Current state: still inverted — src/ZB.MOM.WW.ScadaBridge.Communication/Actors/CentralCommunicationActor.cs resolves ICentralHealthAggregator.

Source: docs/plans/2026-07-08-deferred-work-register.md § New deferrals from review 08

Deferred from architecture review 08: `CentralCommunicationActor` consumes `ICentralHealthAggregator` (HealthMonitoring), an inverted layering. Moving the interface + `SiteHealthState` to Commons ripples across 5 projects for a cosmetic fix, so it was deferred. **Current state:** still inverted — `src/ZB.MOM.WW.ScadaBridge.Communication/Actors/CentralCommunicationActor.cs` resolves `ICentralHealthAggregator`. Source: `docs/plans/2026-07-08-deferred-work-register.md` § New deferrals from review 08
dohertj2 added the type:debtpriority:p3migrated labels 2026-11-06 15:24:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
blocked
Blocked by dependency or external hold
 cross-repo
Needs coordinated change in another family repo (wire contract etc.)
 migrated
Migrated from a markdown backlog (2026-11 standardization)
 priority:p0
Must-have / blocking
 priority:p1
High priority
 priority:p2
Normal priority
 priority:p3
Low priority / nice to have
 type:bug
Defect in shipped behaviour
 type:debt
Technical debt / hygiene
 type:deploy-gate
Rollout/deploy/migration step not yet done on an environment
 type:docs
Documentation work
 type:feature
Feature implementation
 type:followup
Follow-up deferred from a plan, PR or gate
 type:infra
Infrastructure and scaffolding
 type:review-finding
Unfixed finding from an architecture/code review
 type:test
Test work
No Label migrated priority:p3 type:debt
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/ScadaBridge#71
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?