dohertj2/ScadaBridge
1
0
Fork 0
Code Issues 42 Pull Requests Actions Packages Projects Releases Wiki Activity

CompileSurfaceParityTests: add a per-member exclusion seam so the ScriptLogger/CompileLog pair is guarded #57

New Issue
Open
opened 2026-11-06 15:24:40 -05:00 by dohertj2 · 0 comments
dohertj2 commented 2026-11-06 15:24:40 -05:00
Owner
Copy Link
Copy Source

Register row 116 (deferred-work register).

AccessorMirrorPairs asserts the compile mirror has at least as many overloads as the runtime accessor for every public method; ScriptLogger.FlushDropped() must be absent from the mirror, so the pair is left out entirely. Fix: an optional ignoredRuntimeMethods set per row (or a [NotScriptReachable] attribute on FlushDropped), then add the pair.

Revisit trigger (from register): The next public method added to ScriptLogger (or any accessor whose mirror must omit a member).

Current state: Not done; Log methods guarded only by the name-superset check + hand-written surface tests.
Test: tests/ZB.MOM.WW.ScadaBridge.SiteRuntime.Tests/Scripts/CompileSurfaceParityTests.cs.

Source: docs/plans/2026-07-08-deferred-work-register.md row 116

Register row 116 (deferred-work register). `AccessorMirrorPairs` asserts the compile mirror has at least as many overloads as the runtime accessor for every public method; `ScriptLogger.FlushDropped()` must be absent from the mirror, so the pair is left out entirely. Fix: an optional `ignoredRuntimeMethods` set per row (or a `[NotScriptReachable]` attribute on `FlushDropped`), then add the pair. **Revisit trigger (from register):** The next public method added to `ScriptLogger` (or any accessor whose mirror must omit a member). **Current state:** Not done; `Log` methods guarded only by the name-superset check + hand-written surface tests. Test: `tests/ZB.MOM.WW.ScadaBridge.SiteRuntime.Tests/Scripts/CompileSurfaceParityTests.cs`. Source: `docs/plans/2026-07-08-deferred-work-register.md` row 116
dohertj2 added the type:testpriority:p3migrated labels 2026-11-06 15:24:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
blocked
Blocked by dependency or external hold
 cross-repo
Needs coordinated change in another family repo (wire contract etc.)
 migrated
Migrated from a markdown backlog (2026-11 standardization)
 priority:p0
Must-have / blocking
 priority:p1
High priority
 priority:p2
Normal priority
 priority:p3
Low priority / nice to have
 type:bug
Defect in shipped behaviour
 type:debt
Technical debt / hygiene
 type:deploy-gate
Rollout/deploy/migration step not yet done on an environment
 type:docs
Documentation work
 type:feature
Feature implementation
 type:followup
Follow-up deferred from a plan, PR or gate
 type:infra
Infrastructure and scaffolding
 type:review-finding
Unfixed finding from an architecture/code review
 type:test
Test work
No Label migrated priority:p3 type:test
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/ScadaBridge#57
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?