dohertj2/ScadaBridge
1
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases Wiki Activity

docs(known-issues): template-inheritance UI gaps + CLI/validation footguns #5

Open
dohertj2 wants to merge 0 commits from docs/known-issues-2026-06-24 into main
pull from: docs/known-issues-2026-06-24
merge into: dohertj2:main
Conversation 0 Commits - Files Changed -
dohertj2 commented 2026-06-24 12:18:09 -04:00
Owner
Copy Link
Copy Source

Tracks 7 issues found during the 2026-06-24 CvdReactor live-ops session (template rename, LeakTest module, MoveInType, inline MES move-in/out scripts):

  1. Template editor omits inherited-but-unmaterialized base attributes (e.g. LeftMESReceiver doesn't list MoveInType).
  2. Derived templates carry incomplete/stale IsInherited row sets (root cause of #1).
  3. Collision detector blocks adding attributes/compositions to derived templates.
  4. CLI instance set-bindings can't set DataSourceReferenceOverride (and would wipe existing).
  5. CLI template update full-replaces description (nulls it when omitted).
  6. (Minor) CLI template list/get table dumps every attribute.
  7. Central UI script editor false-flags WriteBatchAndWaitAsync/WaitAsync/WaitForAsync — sandbox compile surface out of sync with runtime + deploy gate.

Each entry has severity, components, symptom, root cause with file:line, workaround, and suggested fix. Docs-only; no code changes.

Tracks 7 issues found during the 2026-06-24 CvdReactor live-ops session (template rename, LeakTest module, MoveInType, inline MES move-in/out scripts): 1. Template editor omits inherited-but-unmaterialized base attributes (e.g. LeftMESReceiver doesn't list MoveInType). 2. Derived templates carry incomplete/stale IsInherited row sets (root cause of #1). 3. Collision detector blocks adding attributes/compositions to derived templates. 4. CLI `instance set-bindings` can't set DataSourceReferenceOverride (and would wipe existing). 5. CLI `template update` full-replaces description (nulls it when omitted). 6. (Minor) CLI `template list`/`get` table dumps every attribute. 7. Central UI script editor false-flags WriteBatchAndWaitAsync/WaitAsync/WaitForAsync — sandbox compile surface out of sync with runtime + deploy gate. Each entry has severity, components, symptom, root cause with file:line, workaround, and suggested fix. Docs-only; no code changes.
dohertj2 added 1 commit 2026-06-24 12:18:10 -04:00
docs(known-issues): track template-inheritance UI gaps + CLI/validation footguns 1a647cf1c4 
Records 7 issues found during the 2026-06-24 CvdReactor live-ops session:
- template editor omits inherited-but-unmaterialized base attrs (MoveInType etc.)
- derived templates carry incomplete/stale IsInherited row sets
- collision detector blocks adding attrs/compositions to derived templates
- CLI instance set-bindings can't set DataSourceReferenceOverride
- CLI template update full-replaces description (nulls it if omitted)
- CLI template list/get table dumps every attribute
- Central UI script editor false-flags WriteBatchAndWaitAsync/WaitAsync/WaitForAsync
  (sandbox compile surface out of sync with runtime + deploy gate)
dohertj2 added 1 commit 2026-06-24 15:04:06 -04:00
fix(templateengine+centralui): resolve follow-ups #3 (derived-template collisions) and #7 (sandbox batch/wait surface) b3f6833b36 
#3 — CollisionDetector counted a derived template's IsInherited placeholder
rows as a distinct origin from the parent members the inheritance walk
re-adds, reporting a spurious "Naming collision" for every inherited row and
blocking any attribute/composition add to a derived template. CollectDirectMembers
now skips IsInherited rows on the direct-template and inherited-parent walks;
it keeps them for the composed-module walk, where placeholders are the sole
representation of a derived module's inherited members (that walk does not
climb the composed template's parent chain).

#7 — SandboxAttributeAccessor (Central UI Test-Run host) omitted
WriteBatchAndWaitAsync / WaitAsync / WaitForAsync, so the editor false-flagged
valid instance scripts with CS1061 even though `template validate` and the
deploy gate accept them. Added the five overloads mirroring the runtime
AttributeAccessor; they throw a labelled ScriptSandboxException if run in
Test Run (the central sandbox has no device-batch / event-waiter transport).

Tests: +3 CollisionDetector unit + 1 end-to-end TemplateService (derived add
now succeeds); +2 ScriptAnalysisService diagnose-clean. Each new test verified
to fail without its fix with the exact user-facing symptom. Full suites green
(TemplateEngine.Tests 438, CentralUI.Tests 866).

Docs: Component-TemplateEngine.md (inherited-placeholder collision rule),
Component-ScriptAnalysis.md (third sandbox surface + its compile-clean guard),
known-issues tracker #3/#7 marked resolved and the minor note promoted to #8.
This branch is already included in the target branch. There is nothing to merge.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin docs/known-issues-2026-06-24:docs/known-issues-2026-06-24
git checkout docs/known-issues-2026-06-24
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/ScadaBridge#5
Delete Branch "docs/known-issues-2026-06-24"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?