Commit Graph

2 Commits

Author SHA1 Message Date
Joseph Doherty b3f6833b36 fix(templateengine+centralui): resolve follow-ups #3 (derived-template collisions) and #7 (sandbox batch/wait surface)
#3 — CollisionDetector counted a derived template's IsInherited placeholder
rows as a distinct origin from the parent members the inheritance walk
re-adds, reporting a spurious "Naming collision" for every inherited row and
blocking any attribute/composition add to a derived template. CollectDirectMembers
now skips IsInherited rows on the direct-template and inherited-parent walks;
it keeps them for the composed-module walk, where placeholders are the sole
representation of a derived module's inherited members (that walk does not
climb the composed template's parent chain).

#7 — SandboxAttributeAccessor (Central UI Test-Run host) omitted
WriteBatchAndWaitAsync / WaitAsync / WaitForAsync, so the editor false-flagged
valid instance scripts with CS1061 even though `template validate` and the
deploy gate accept them. Added the five overloads mirroring the runtime
AttributeAccessor; they throw a labelled ScriptSandboxException if run in
Test Run (the central sandbox has no device-batch / event-waiter transport).

Tests: +3 CollisionDetector unit + 1 end-to-end TemplateService (derived add
now succeeds); +2 ScriptAnalysisService diagnose-clean. Each new test verified
to fail without its fix with the exact user-facing symptom. Full suites green
(TemplateEngine.Tests 438, CentralUI.Tests 866).

Docs: Component-TemplateEngine.md (inherited-placeholder collision rule),
Component-ScriptAnalysis.md (third sandbox surface + its compile-clean guard),
known-issues tracker #3/#7 marked resolved and the minor note promoted to #8.
2026-06-24 15:03:27 -04:00
Joseph Doherty 1a647cf1c4 docs(known-issues): track template-inheritance UI gaps + CLI/validation footguns
Records 7 issues found during the 2026-06-24 CvdReactor live-ops session:
- template editor omits inherited-but-unmaterialized base attrs (MoveInType etc.)
- derived templates carry incomplete/stale IsInherited row sets
- collision detector blocks adding attrs/compositions to derived templates
- CLI instance set-bindings can't set DataSourceReferenceOverride
- CLI template update full-replaces description (nulls it if omitted)
- CLI template list/get table dumps every attribute
- Central UI script editor false-flags WriteBatchAndWaitAsync/WaitAsync/WaitForAsync
  (sandbox compile surface out of sync with runtime + deploy gate)
2026-06-24 12:16:38 -04:00