Joseph Doherty
adfb4d385c
feat(audit): ScadaBridge C2 — ScadaBridgeAuditRedactor/SafeDefaultAuditRedactor : IAuditRedactor on canonical record (Task 2.5)
2026-06-02 11:00:36 -04:00
Joseph Doherty
3d77dc003c
feat(audit): ScadaBridge C1 — AuditDetails codec (deterministic) + AuditOutcome projection + canonical field builders + ZB.MOM.WW.Audit ref (Task 2.5)
...
Additive foundation only — no existing type/interface/emitter changed.
Commons now references ZB.MOM.WW.Audit 0.1.0 (Gitea feed, central PM pin).
Adds four pure new types in Commons/Types/Audit/:
AuditDetails (sealed record, 17 domain fields, declaration-order = JSON key order)
AuditDetailsCodec (static; single cached JsonSerializerOptions: camelCase, no-indent,
WhenWritingNull, UnsafeRelaxedJsonEscaping — byte-deterministic across calls)
AuditOutcomeProjector (static; InboundAuthFailure→Denied first, then Delivered→Success,
Failed/Parked/Discarded→Failure, all others→Success)
AuditFieldBuilders (static; BuildAction="{channel}.{kind}", BuildCategory=channel.ToString())
56 new tests in Commons.Tests/Types/Audit/ covering codec round-trip, byte-determinism
(hand-pinned expected JSON string), null/empty sentinel, full projection table,
InboundAuthFailure-Denied precedence, and Action/Category builders. All pass.
2026-06-02 10:42:51 -04:00
Joseph Doherty
4118452e72
docs(auth): ScadaBridge Task 1.7 review — correct stale role-name prose in NavMenu comments (Admin/Design/Deployment/Audit→canonical)
2026-06-02 08:13:38 -04:00
Joseph Doherty
b104760b3a
feat(auth)!: ScadaBridge canonical roles + SoD collapse (Audit→Administrator, AuditReadOnly→Viewer) + config-DB migration (Task 1.7)
...
Standardize role string VALUES on the canonical vocabulary
(Administrator/Designer/Deployer/Viewer; Operator/Engineer unused here):
Admin -> Administrator
Design -> Designer
Deployment -> Deployer
Audit -> Administrator (COLLAPSE; accepted privilege escalation)
AuditReadOnly-> Viewer (COLLAPSE; keeps audit-read, no export)
SoD: OperationalAuditRoles = { Administrator, Viewer },
AuditExportRoles = { Administrator }
so Viewer reads the audit log + nav but cannot bulk-export, while
Administrator does both + holds the full admin surface (the documented,
accepted auditor/admin SoD collapse).
Atomic move across every enforcement site:
- Roles constants; AuthorizationPolicies (RequireClaim values + SoD arrays +
honest XML-doc); RoleMapper Deployer check.
- ManagementActor.GetRequiredRole switch + the hard-coded site-scope
admin-bypass (now Roles.Administrator at all 6 sites). Site-scoping logic
is otherwise unchanged.
- DebugStreamHub Administrator/Deployer gates (Deployer kept case-sensitive).
- CentralUI BrowseService/BindingTester Designer guards; LdapMappingForm
dropdown now offers canonical values (incl. Viewer).
- Config-DB seed (LdapGroupMappings Id 1-4) + EF migration CanonicalizeRoles:
Id-keyed UpdateData for seed rows + idempotent raw catch-all UPDATEs for
operator-added rows. Down is lossy on the collapse (documented in-file).
No pending model changes.
Tests reworked to the collapsed model across Security/CentralUI/
ManagementService/ConfigurationDatabase/Integration suites, incl. explicit
Viewer-reads-not-exports and former-Audit-now-Administrator-escalation cases.
CHANGELOG: BREAKING security note documenting the canonicalization + SoD
collapse.
2026-06-02 08:00:47 -04:00
Joseph Doherty
6ae605160c
chore(auth): ScadaBridge unify dev LDAP base DN to dc=zb,dc=local (Task 1.6)
...
Replace dc=scadabridge,dc=local with dc=zb,dc=local in all dev/test LDAP
references — app config, docker test-cluster node configs (docker/ and
docker-env2/), GLAuth fixture, dev tooling, Host.Tests fixtures,
IntegrationTests factory, and operational test_infra docs. OU structure
(ou=SCADA-Admins,ou=users,etc.) preserved throughout. Email domains
(@scadabridge.local), hostnames, and container names are untouched.
Historical plan docs (2026-05-24-second-environment.md,
2026-05-31-folder-repo-rename-scadabridge-design.md) excluded as
point-in-time records. No synthetic dc=example,dc=com placeholders touched.
2026-06-02 06:54:14 -04:00
Joseph Doherty
a0938f708b
feat(auth): ScadaBridge full canonical claims (ZbClaimTypes role/scope) + ZbCookieDefaults, keep cookie name (Task 1.5)
2026-06-02 06:23:15 -04:00
Joseph Doherty
afa55981d5
feat(auth)!: ScadaBridge retire SQL Server ApiKey entity + ApprovedApiKeyIds + legacy hashing; EF migration RetireInboundApiKeyStore; re-issue runbook + CHANGELOG (re-arch C5/E) — BREAKING: X-API-Key -> Bearer sbk_, keys re-issued
2026-06-02 05:39:59 -04:00
Joseph Doherty
b13d7b3d28
fix(auth): C4 review polish — document backward-compat JSON tolerance, shared BundleJsonOptions, PreviewAsync legacy-bundle test, doc fix (review I-2/I-3/M-1/M-2; I-1 intentionally skipped)
2026-06-02 05:15:50 -04:00
Joseph Doherty
731cfd3bfc
feat(auth): ScadaBridge TransportExport excludes inbound API keys (re-arch C4; methods-only, import ignores legacy key sections); keys re-issued per environment
2026-06-02 05:06:40 -04:00
Joseph Doherty
d1191fddf9
fix(auth): C3 review — surface seam not-found (no silent success), partial-reconcile-failure guidance, create validation order, concurrent-edit reconciler test
2026-06-02 04:46:32 -04:00
Joseph Doherty
107e524914
feat(auth): ScadaBridge CentralUI pages onto IInboundApiKeyAdmin seam (re-arch C3; string keyId, method-scopes replace ApprovedApiKeyIds, token-once display, approved-keys<->scopes inversion)
2026-06-02 04:36:50 -04:00
Joseph Doherty
8219b8ee18
fix(auth): C2 review — not-found throws (no spurious audit) on update/delete/set-methods, reject empty methods (unusable-key/stealth-disable), richer set-methods response, token advisory to stderr
2026-06-02 04:21:28 -04:00
Joseph Doherty
6518e93424
feat(auth): ScadaBridge ManagementActor + CLI + Commons messages onto IInboundApiKeyAdmin seam (re-arch C2; int->string keyId, +Methods, +SetApiKeyMethods)
2026-06-02 04:11:44 -04:00
Joseph Doherty
7f7ea3f3c9
fix(auth): C1 review polish — guard name at seam, document seam contract (throws/O(n)), explicit cookie test (review #1/#2/#3/#5/#8)
2026-06-02 04:01:43 -04:00
Joseph Doherty
55099b19f6
fix(auth): move AddZbLdapAuth to Host composition root so component-lib AddSecurity() drops IConfiguration param (satisfy OptionsTests arch rule; fix pre-existing ac34dac red); behaviour-preserving
2026-06-02 03:50:16 -04:00
Joseph Doherty
d09def2be0
feat(auth): ScadaBridge re-pin Auth 0.1.3 + add IInboundApiKeyAdmin seam over library admin facade (re-arch C1, additive)
2026-06-02 03:32:25 -04:00
Joseph Doherty
1fcc4f5c2b
fix(auth): ScadaBridge inbound auth review fixes — scope-before-DB, pinned 403 body, pepper fail-fast, log category
2026-06-02 02:50:10 -04:00
Joseph Doherty
a94558c289
feat(auth): ScadaBridge inbound API — adopt ZB.MOM.WW.Auth.ApiKeys verifier + Bearer + scope=method (re-arch A+B); additive, old path retired later
2026-06-02 02:40:18 -04:00
Joseph Doherty
4db8c373af
fix(auth): ScadaBridge 1.2 review fixes — secret-test repoint, checklist, Scope guard, 0.1.1 pin
2026-06-02 01:23:52 -04:00
Joseph Doherty
ac34dac479
feat(auth): cut ScadaBridge over to ZB.MOM.WW.Auth.Ldap; nest+rename Ldap config; roles+sitescope via IGroupRoleMapper (Task 1.2/1.4)
2026-06-02 01:04:34 -04:00
Joseph Doherty
9230afa25f
feat(auth): add IGroupRoleMapper<string> seam (Task 1.1)
2026-06-02 00:30:42 -04:00
Joseph Doherty
145d2668e2
fix: wire ValidateOnStart for ScadaBridge HealthMonitoring + Cluster options (fail-fast at startup)
2026-06-01 23:07:46 -04:00
Joseph Doherty
9668a4e84a
refactor: ScadaBridge module options registration -> AddValidatedOptions; clarify De Morgan predicates
2026-06-01 22:49:41 -04:00
Joseph Doherty
6dbbc7ad04
refactor: ScadaBridge StartupValidator -> ConfigPreflight (byte-compatible)
2026-06-01 19:04:13 -04:00
Joseph Doherty
aac59c9fae
refactor: ScadaBridge validators onto OptionsValidatorBase (messages unchanged)
2026-06-01 18:56:04 -04:00
Joseph Doherty
ccf43312e8
feat(scadabridge): config-driven OTLP exporter opt-in (default Prometheus)
2026-06-01 17:14:35 -04:00
Joseph Doherty
a5f8651b0f
feat(scadabridge): track scadabridge.site.connection.up over site-stream lifetime (balanced open/close)
2026-06-01 17:11:39 -04:00
Joseph Doherty
15a626390b
fix(scadabridge): queue-depth seed uses Add (no lost concurrent enqueue) + clarify registration/discard comments
2026-06-01 17:07:03 -04:00
Joseph Doherty
782fb73015
feat(scadabridge): emit scadabridge.inbound_api.requests (by method) at inbound API entry
2026-06-01 17:03:10 -04:00
Joseph Doherty
547b685a42
feat(scadabridge): wire scadabridge.store_and_forward.queue.depth gauge to buffered count
2026-06-01 16:58:09 -04:00
Joseph Doherty
877f2e200b
feat(scadabridge): emit scadabridge.deployments.applied on deployment success
2026-06-01 16:52:09 -04:00
Joseph Doherty
c41cb41c7b
fix(scadabridge): default MetricsPort to 8084 (avoid site RemotingPort collision) + validate port distinctness
2026-06-01 16:46:59 -04:00
Joseph Doherty
fe25ac3e51
feat(scadabridge): add ScadaBridgeTelemetry meter + 4 instruments; register with OTel
2026-06-01 16:41:52 -04:00
Joseph Doherty
bbc9f09268
feat(scadabridge): add HTTP/1.1 metrics listener on site nodes (NodeOptions.MetricsPort=8082)
2026-06-01 16:36:59 -04:00
Joseph Doherty
f743ffaad2
feat(scadabridge): add shared TraceContextEnricher to log pipeline (trace correlation)
2026-06-01 15:40:42 -04:00
Joseph Doherty
b3070c0bda
feat(scadabridge): wire AddZbTelemetry + /metrics in both composition roots
2026-06-01 15:36:55 -04:00
Joseph Doherty
20a31835cf
build(scadabridge): reference ZB.MOM.WW.Telemetry packages from Gitea feed
2026-06-01 15:30:00 -04:00
Joseph Doherty
adf1bd2693
build: drop orphaned AspNetCore.HealthChecks.UI.Client ref (UIResponseWriter removed)
2026-06-01 13:56:12 -04:00
Joseph Doherty
bbff1d19b5
feat: adopt shared ZB.MOM.WW.Health probes; add /healthz; canonical writer
2026-06-01 13:46:49 -04:00
Joseph Doherty
2a7ff03718
feat: bridge ActorSystem into DI (transient) for shared health checks
2026-06-01 13:37:21 -04:00
Joseph Doherty
38e48299a4
build: reference ZB.MOM.WW.Health packages from the Gitea feed
2026-06-01 13:30:33 -04:00
Joseph Doherty
c899cb162c
refactor: scrub residual ScadaLink refs → ScadaBridge (env vars, config keys, assembly name, SQL login)
...
Renames the 13 SCADALINK_* runtime env vars → SCADABRIDGE_*, the ScadaLink__
.NET config keys → ScadaBridge__, the stale ScadaLink.Host.exe assembly name
→ ZB.MOM.WW.ScadaBridge.Host.exe, the scadalink_app SQL login → scadabridge_app,
and residual identifiers/comments/docs. Migration records (prior rename
tooling/design, DB-rename helper, this scrub script) carved out.
Adds tools/scrub-scadalink-refs.sh.
2026-05-31 21:50:38 -04:00
Joseph Doherty
add7210d9e
fix(dcl): route native alarm subscribe/unsubscribe through DataConnectionManagerActor
...
The NativeAlarmActor sends SubscribeAlarmsRequest to the DCL manager, but the
manager only routed tag/write/browse messages to the per-connection
DataConnectionActor — alarm subscribe/unsubscribe were unhandled and dead-lettered,
so native alarms never subscribed at runtime. Caught by live T28 deployment.
Mirrors the existing HandleRoute forwarding.
2026-05-31 03:25:28 -04:00
Joseph Doherty
046797e699
feat(ui): instance configure native alarm source override panel
2026-05-31 02:46:54 -04:00
Joseph Doherty
60f8e2c9a7
feat(ui): template editor Native Alarm Sources subsection
2026-05-31 02:40:52 -04:00
Joseph Doherty
1f6c4207df
feat(ui): enrich DebugView alarm table with severity + condition state + native metadata
2026-05-31 02:34:12 -04:00
Joseph Doherty
a6dcbf62cd
feat(cli): native-alarm-source commands (template add/list/remove + instance set/clear)
2026-05-31 02:30:05 -04:00
Joseph Doherty
3bf1d26d79
feat(management): handlers for native alarm source CRUD
2026-05-31 02:23:17 -04:00
Joseph Doherty
b1df6d5beb
feat(commons): management command contracts for native alarm sources
2026-05-31 02:18:37 -04:00
Joseph Doherty
0c6f9a9cff
feat(communication): map enriched alarm fields across gRPC (server + client)
2026-05-31 02:16:43 -04:00