feat(options): eager startup validation for edge/management options (InboundAPI, ESG, Notification, ManagementService) (arch-review 08 §1.5)

Claude-Session: https://claude.ai/code/session_01MtdgwpEeCUn6cUA5f1LMPj
2026-07-10 06:52:59 -04:00
parent 8b775f4ae1
commit fc918d4679
16 changed files with 404 additions and 4 deletions
@@ -0,0 +1,68 @@
+using Microsoft.Extensions.Options;
+
+namespace ZB.MOM.WW.ScadaBridge.InboundAPI.Tests;
+
+/// <summary>
+/// Arch-review 08 §1.5: <see cref="InboundApiOptions"/> feeds a per-request timeout
+/// (<see cref="InboundApiOptions.DefaultMethodTimeout"/>) and a body-size cap
+/// (<see cref="InboundApiOptions.MaxRequestBodyBytes"/>) into the inbound-API request
+/// pipeline; a zero/negative timeout or a non-positive body cap must be rejected fast at
+/// startup with a clear, key-naming message rather than silently degrading the endpoint.
+/// The <see cref="InboundApiOptions.ApiKeyPepper"/> is deliberately NOT required non-empty
+/// here (empty is a legitimate dev default; production pepper strength is enforced elsewhere).
+/// </summary>
+public class InboundApiOptionsValidatorTests
+{
+    private static ValidateOptionsResult Validate(InboundApiOptions options) =>
+        new InboundApiOptionsValidator().Validate(Options.DefaultName, options);
+
+    [Fact]
+    public void DefaultOptions_AreValid()
+    {
+        var result = Validate(new InboundApiOptions());
+        Assert.True(result.Succeeded, result.FailureMessage);
+    }
+
+    [Fact]
+    public void EmptyApiKeyPepper_IsValid()
+    {
+        var result = Validate(new InboundApiOptions { ApiKeyPepper = string.Empty });
+        Assert.True(result.Succeeded, result.FailureMessage);
+    }
+
+    [Fact]
+    public void ZeroDefaultMethodTimeout_IsRejected()
+    {
+        var result = Validate(new InboundApiOptions { DefaultMethodTimeout = TimeSpan.Zero });
+
+        Assert.True(result.Failed);
+        Assert.Contains("DefaultMethodTimeout", result.FailureMessage);
+    }
+
+    [Fact]
+    public void NegativeDefaultMethodTimeout_IsRejected()
+    {
+        var result = Validate(new InboundApiOptions { DefaultMethodTimeout = TimeSpan.FromSeconds(-1) });
+
+        Assert.True(result.Failed);
+        Assert.Contains("DefaultMethodTimeout", result.FailureMessage);
+    }
+
+    [Fact]
+    public void ZeroMaxRequestBodyBytes_IsRejected()
+    {
+        var result = Validate(new InboundApiOptions { MaxRequestBodyBytes = 0 });
+
+        Assert.True(result.Failed);
+        Assert.Contains("MaxRequestBodyBytes", result.FailureMessage);
+    }
+
+    [Fact]
+    public void NegativeMaxRequestBodyBytes_IsRejected()
+    {
+        var result = Validate(new InboundApiOptions { MaxRequestBodyBytes = -1 });
+
+        Assert.True(result.Failed);
+        Assert.Contains("MaxRequestBodyBytes", result.FailureMessage);
+    }
+}