test(ui): verify bUnit 2.7.2 with patched parser
This commit is contained in:
@@ -13,6 +13,7 @@
|
|||||||
<PackageVersion Include="Akka.Streams" Version="1.5.62" />
|
<PackageVersion Include="Akka.Streams" Version="1.5.62" />
|
||||||
<PackageVersion Include="Akka.Streams.TestKit" Version="1.5.62" />
|
<PackageVersion Include="Akka.Streams.TestKit" Version="1.5.62" />
|
||||||
<PackageVersion Include="Akka.TestKit.Xunit2" Version="1.5.62" />
|
<PackageVersion Include="Akka.TestKit.Xunit2" Version="1.5.62" />
|
||||||
|
<PackageVersion Include="AngleSharp" Version="1.5.2" />
|
||||||
<PackageVersion Include="bunit" Version="2.7.2" />
|
<PackageVersion Include="bunit" Version="2.7.2" />
|
||||||
<PackageVersion Include="coverlet.collector" Version="6.0.4" />
|
<PackageVersion Include="coverlet.collector" Version="6.0.4" />
|
||||||
<PackageVersion Include="FluentAssertions" Version="8.3.0" />
|
<PackageVersion Include="FluentAssertions" Version="8.3.0" />
|
||||||
@@ -198,19 +199,8 @@
|
|||||||
NuGetAuditSuppress/NoWarn.
|
NuGetAuditSuppress/NoWarn.
|
||||||
-->
|
-->
|
||||||
|
|
||||||
<!--
|
<!-- Test-only parser pin: CentralUI.Tests references AngleSharp directly.
|
||||||
GHSA-pgww-w46g-26qg (NU1902, moderate) on AngleSharp, reached only transitively via bunit
|
bUnit 2.7.2 render/event tests pass with patched AngleSharp 1.5.2. -->
|
||||||
in ZB.MOM.WW.ScadaBridge.CentralUI.Tests. With TreatWarningsAsErrors it made the WHOLE
|
|
||||||
SOLUTION BUILD RED, so no suite could run and every "0 warnings / green" gate was
|
|
||||||
unverifiable.
|
|
||||||
|
|
||||||
Resolved with a scoped NuGetAuditSuppress in that ONE test project (see its csproj for the
|
|
||||||
full rationale) — deliberately NOT a version pin here. A pin was tried first and reverted:
|
|
||||||
AngleSharp >= 1.5.0 is the only patched line, and it changes IHtmlCollection<T>'s indexer,
|
|
||||||
which makes every bunit build throw MissingMethodException at runtime (33 render tests
|
|
||||||
failed). Bumping bunit does not help either — even 2.7.2 resolves AngleSharp 1.4.0, which
|
|
||||||
is still vulnerable. There is no working patched combination upstream today.
|
|
||||||
-->
|
|
||||||
|
|
||||||
|
|
||||||
</Project>
|
</Project>
|
||||||
|
|||||||
+2
-23
@@ -10,6 +10,8 @@
|
|||||||
|
|
||||||
<ItemGroup>
|
<ItemGroup>
|
||||||
<PackageReference Include="bunit" />
|
<PackageReference Include="bunit" />
|
||||||
|
<!-- Direct test dependency activates the patched central parser pin. -->
|
||||||
|
<PackageReference Include="AngleSharp" />
|
||||||
<PackageReference Include="coverlet.collector" />
|
<PackageReference Include="coverlet.collector" />
|
||||||
<PackageReference Include="Microsoft.AspNetCore.TestHost" />
|
<PackageReference Include="Microsoft.AspNetCore.TestHost" />
|
||||||
<PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" />
|
<PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" />
|
||||||
@@ -39,29 +41,6 @@
|
|||||||
<ProjectReference Include="../../src/ZB.MOM.WW.ScadaBridge.ConfigurationDatabase/ZB.MOM.WW.ScadaBridge.ConfigurationDatabase.csproj" />
|
<ProjectReference Include="../../src/ZB.MOM.WW.ScadaBridge.ConfigurationDatabase/ZB.MOM.WW.ScadaBridge.ConfigurationDatabase.csproj" />
|
||||||
</ItemGroup>
|
</ItemGroup>
|
||||||
|
|
||||||
<!--
|
|
||||||
GHSA-pgww-w46g-26qg (NU1902, moderate) on AngleSharp, reached ONLY transitively via
|
|
||||||
bunit. Suppressed here, scoped to this one test project, because there is verifiably
|
|
||||||
no version combination that resolves it:
|
|
||||||
|
|
||||||
- AngleSharp < 1.5.0 is vulnerable (1.4.0 is what even the newest bunit resolves).
|
|
||||||
- AngleSharp >= 1.5.0 changed IHtmlCollection<T>'s indexer, so every bunit build
|
|
||||||
throws MissingMethodException at runtime - 33 CentralUI render tests fail.
|
|
||||||
- Bumping bunit does not help: checked up to 2.7.2, still AngleSharp 1.4.0.
|
|
||||||
|
|
||||||
So the choice is a suppressed advisory or an unbuildable/failing test suite. Scoped
|
|
||||||
suppression wins because the reach is genuinely nil: AngleSharp is an HTML parser used
|
|
||||||
by bunit to assert on rendered markup in unit tests. It ships in no production project
|
|
||||||
and processes no untrusted input - the "documents" it parses are our own components'
|
|
||||||
output. Revisit when bunit ships against AngleSharp 1.5+.
|
|
||||||
|
|
||||||
NOT the same call as GHSA-2m69-gcr7-jv3q (SQLitePCLRaw): that suppression was removed
|
|
||||||
in 2026-07 precisely because it was masking a vulnerability in PRODUCTION code paths.
|
|
||||||
This one is test-only, and a patched-but-working version does not exist upstream.
|
|
||||||
-->
|
|
||||||
<ItemGroup>
|
|
||||||
<NuGetAuditSuppress Include="https://github.com/advisories/GHSA-pgww-w46g-26qg" />
|
|
||||||
</ItemGroup>
|
|
||||||
|
|
||||||
<ItemGroup><ProjectReference Include="../../src/ZB.MOM.WW.ScadaBridge.CentralUI.SandboxWorker/ZB.MOM.WW.ScadaBridge.CentralUI.SandboxWorker.csproj" /></ItemGroup>
|
<ItemGroup><ProjectReference Include="../../src/ZB.MOM.WW.ScadaBridge.CentralUI.SandboxWorker/ZB.MOM.WW.ScadaBridge.CentralUI.SandboxWorker.csproj" /></ItemGroup>
|
||||||
</Project>
|
</Project>
|
||||||
Reference in New Issue
Block a user