dohertj2/ScadaBridge
1
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

test(ui): verify bUnit 2.7.2 with patched parser

Browse Source
This commit is contained in:
Joseph Doherty
2026-11-13 15:23:32 -05:00
parent c4ec51e89a
commit f8c2851d25
2 changed files with 5 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/ZB.MOM.WW.ScadaBridge.CentralUI.Tests/ZB.MOM.WW.ScadaBridge.CentralUI.Tests.csproj
+2 -23
View File
@@ -10,6 +10,8 @@
<ItemGroup>
<PackageReference Include="bunit" />
<!-- Direct test dependency activates the patched central parser pin. -->
<PackageReference Include="AngleSharp" />
<PackageReference Include="coverlet.collector" />
<PackageReference Include="Microsoft.AspNetCore.TestHost" />
<PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" />
@@ -39,29 +41,6 @@
<ProjectReference Include="../../src/ZB.MOM.WW.ScadaBridge.ConfigurationDatabase/ZB.MOM.WW.ScadaBridge.ConfigurationDatabase.csproj" />
</ItemGroup>
<!--
GHSA-pgww-w46g-26qg (NU1902, moderate) on AngleSharp, reached ONLY transitively via
bunit. Suppressed here, scoped to this one test project, because there is verifiably
no version combination that resolves it:
- AngleSharp < 1.5.0 is vulnerable (1.4.0 is what even the newest bunit resolves).
- AngleSharp >= 1.5.0 changed IHtmlCollection<T>'s indexer, so every bunit build
throws MissingMethodException at runtime - 33 CentralUI render tests fail.
- Bumping bunit does not help: checked up to 2.7.2, still AngleSharp 1.4.0.
So the choice is a suppressed advisory or an unbuildable/failing test suite. Scoped
suppression wins because the reach is genuinely nil: AngleSharp is an HTML parser used
by bunit to assert on rendered markup in unit tests. It ships in no production project
and processes no untrusted input - the "documents" it parses are our own components'
output. Revisit when bunit ships against AngleSharp 1.5+.
NOT the same call as GHSA-2m69-gcr7-jv3q (SQLitePCLRaw): that suppression was removed
in 2026-07 precisely because it was masking a vulnerability in PRODUCTION code paths.
This one is test-only, and a patched-but-working version does not exist upstream.
-->
<ItemGroup>
<NuGetAuditSuppress Include="https://github.com/advisories/GHSA-pgww-w46g-26qg" />
</ItemGroup>
<ItemGroup><ProjectReference Include="../../src/ZB.MOM.WW.ScadaBridge.CentralUI.SandboxWorker/ZB.MOM.WW.ScadaBridge.CentralUI.SandboxWorker.csproj" /></ItemGroup>
</Project>