feat(localdb): create config + sf_messages tables in the consolidated DB

Task 7. SiteLocalDbSetup.OnReady now applies SiteStorageSchema and StoreAndForwardSchema alongside the Phase 1 schemas, so the nine site configuration tables and the store-and-forward buffer live in the consolidated LocalDb file. Deliberately NOT registered for replication. The bespoke SiteReplicationActor and the StoreAndForward ReplicationService still own these tables until the Task 14 cutover deletes both and registers them in one commit; registering early would run two replicators over the same rows and let either one's defects hide behind the other's writes. Pinned by two tests through the real composition root: one asserting all twelve tables exist, one asserting ReplicatedTables is EXACTLY the Phase 1 pair. Non-vacuity verified by removing the DDL and observing the failure. Claude-Session: https://claude.ai/code/session_01BL2Vu1ESDQ9SCN4gVKkdts
2026-07-20 03:28:05 -04:00
parent fefbbb31da
commit f8aa02e2a9
2 changed files with 71 additions and 0 deletions
@@ -215,6 +215,62 @@ public class SiteLocalDbWiringTests : IDisposable
        Assert.Contains(LocalDbMetrics.MeterName, SiteServiceRegistration.ObservedMeters);
    }

+    [Fact]
+    public void Site_LocalDb_CreatesThePhase2Tables_InTheConsolidatedFile()
+    {
+        // Phase 2 (Task 7). The nine configuration tables and the store-and-forward buffer
+        // now live in the consolidated file rather than in scadabridge.db and
+        // store-and-forward.db. Asserting through the REAL composition root is what proves
+        // OnReady applies both schemas — the stores themselves also call Apply, so a test
+        // that went through a store would pass even if OnReady never touched them.
+        var db = _host.Services.GetRequiredService<ILocalDb>();
+
+        var tables = TableNames(db);
+
+        // One from each Phase 1 schema, then every Phase 2 table.
+        Assert.Contains("OperationTracking", tables);
+        Assert.Contains("site_events", tables);
+        Assert.Contains("sf_messages", tables);
+        foreach (var table in new[]
+        {
+            "deployed_configurations", "static_attribute_overrides", "shared_scripts",
+            "external_systems", "database_connections", "notification_lists",
+            "data_connection_definitions", "smtp_configurations", "native_alarm_state",
+        })
+        {
+            Assert.Contains(table, tables);
+        }
+    }
+
+    [Fact]
+    public void Site_LocalDb_DoesNotYetRegisterThePhase2Tables()
+    {
+        // The "not yet" is the assertion that matters, and it is why this is an EXACTLY
+        // check rather than a Contains. Until the Task 14 cutover, the bespoke
+        // SiteReplicationActor and the StoreAndForward ReplicationService still own these
+        // tables. Registering them early would run two replicators over the same rows and
+        // hide a defect in either one behind the other's writes.
+        //
+        // When Task 14 lands, this test does not get deleted — it gets inverted.
+        var db = _host.Services.GetRequiredService<ILocalDb>();
+
+        Assert.Equal(
+            ["OperationTracking", "site_events"],
+            db.ReplicatedTables.Keys.OrderBy(k => k, StringComparer.Ordinal).ToArray());
+    }
+
+    private static HashSet<string> TableNames(ILocalDb db)
+    {
+        using var connection = db.CreateConnection();
+        using var cmd = connection.CreateCommand();
+        cmd.CommandText = "SELECT name FROM sqlite_master WHERE type = 'table'";
+        using var reader = cmd.ExecuteReader();
+
+        var names = new HashSet<string>(StringComparer.Ordinal);
+        while (reader.Read()) names.Add(reader.GetString(0));
+        return names;
+    }
+
    [Fact]
    public void Site_LocalDb_CreatesTheConfiguredFile()
    {