fix(dcl): async OPC UA endpoint discovery bounded by OperationTimeoutMs/verify budget; adapter connect never runs on the actor thread (review 2026-10-21 02/P2)

2026-10-22 06:37:23 -04:00
parent cfe95a7e5a
commit e6406c494c
6 changed files with 170 additions and 28 deletions
@@ -957,7 +957,14 @@ public class DataConnectionActor : UntypedActor, IWithTimers
        // is still in flight swaps the adapter and bumps the counter, and the OUTGOING
        // adapter's answer must never be applied to its replacement.
        var generation = _adapterGeneration;
-        _adapter.ConnectAsync(_connectionDetails).ContinueWith(t =>
+        // Started on the thread pool, never inline: everything an adapter's ConnectAsync does
+        // before its first YIELDING await would otherwise run on this actor's dispatcher thread
+        // — OPC UA endpoint discovery was synchronous there and parked the thread for the SDK's
+        // operation timeout on every reconnect tick to a black-holed endpoint (review 2026-10-21
+        // 02/P2). Adapter and details are captured here, on the actor thread.
+        var adapter = _adapter;
+        var details = _connectionDetails;
+        Task.Run(() => adapter.ConnectAsync(details)).ContinueWith(t =>
        {
            if (t.IsCompletedSuccessfully)
                return new ConnectResult(true, null, generation);