feat(transport): normalize List attribute values to native JSON on import

This commit is contained in:
Joseph Doherty
2026-06-16 17:50:05 -04:00
parent 5841cec958
commit e3d804a1a6
4 changed files with 178 additions and 5 deletions
@@ -1040,7 +1040,7 @@ public sealed class BundleImporter : IBundleImporter
{
t.Attributes.Add(new TemplateAttribute(a.Name)
{
Value = a.Value,
Value = ImportValueNormalizer.NormalizeListValue(a.Value, a.DataType, a.ElementDataType),
DataType = a.DataType,
IsLocked = a.IsLocked,
Description = a.Description,
@@ -1115,11 +1115,17 @@ public sealed class BundleImporter : IBundleImporter
// Adds + Updates.
foreach (var attrDto in dto.Attributes)
{
// Normalise List values to the native-typed JSON form on import so the
// comparison (and the persisted value) match what the target already
// stores natively — otherwise an idempotent re-import of an old-form
// bundle would spuriously report a Value change.
var normalizedValue = ImportValueNormalizer.NormalizeListValue(
attrDto.Value, attrDto.DataType, attrDto.ElementDataType);
if (existingByName.TryGetValue(attrDto.Name, out var current))
{
// Update only if any field actually changed.
bool changed =
!string.Equals(current.Value, attrDto.Value, StringComparison.Ordinal) ||
!string.Equals(current.Value, normalizedValue, StringComparison.Ordinal) ||
current.DataType != attrDto.DataType ||
current.IsLocked != attrDto.IsLocked ||
!string.Equals(current.Description, attrDto.Description, StringComparison.Ordinal) ||
@@ -1127,7 +1133,7 @@ public sealed class BundleImporter : IBundleImporter
current.ElementDataType != attrDto.ElementDataType;
if (!changed) continue;
current.Value = attrDto.Value;
current.Value = normalizedValue;
current.DataType = attrDto.DataType;
current.IsLocked = attrDto.IsLocked;
current.Description = attrDto.Description;
@@ -1157,7 +1163,7 @@ public sealed class BundleImporter : IBundleImporter
{
var newAttr = new TemplateAttribute(attrDto.Name)
{
Value = attrDto.Value,
Value = normalizedValue,
DataType = attrDto.DataType,
IsLocked = attrDto.IsLocked,
Description = attrDto.Description,