fix(deployment): pending-updates tick uses a slim instance projection, hash-only flatten, one untracked mismatch snapshot read and a per-tick secret lookup memo (review 2026-10-21 04/P2)

2026-10-22 06:39:45 -04:00
parent 971a9886b8
commit df67fabe68
17 changed files with 443 additions and 128 deletions
@@ -711,23 +711,24 @@ public class DeploymentServiceTests : TestKit
        await _pipeline.Received().FlattenAndValidateAsync(1, Arg.Any<CancellationToken>(), true);
    }

-    /// <summary>Verifies that stale instance probe requests validate scripts false.</summary>
+    /// <summary>
+    /// The Transport stale-instance probe only needs the hash, so it uses the hash-only
+    /// flatten (no validation, no Roslyn compile) rather than the validating entry point.
+    /// </summary>
    /// <returns>A task that represents the asynchronous operation.</returns>
    [Fact]
-    public async Task StaleInstanceProbe_RequestsValidateScriptsFalse()
+    public async Task StaleInstanceProbe_UsesHashOnlyFlatten()
    {
-        // The Transport stale-instance probe also only needs the hash — same skip.
-
        _pipeline.CreateSession().Returns(_ => new FlattenSession(new TemplateGraphWatermark()));
-        _pipeline.FlattenAndValidateAsync(5, Arg.Any<CancellationToken>(), Arg.Any<bool>(), Arg.Any<FlattenSession?>())
-            .Returns(Result<FlatteningPipelineResult>.Success(
-                new FlatteningPipelineResult(new FlattenedConfiguration(), "sha256:probe", ValidationResult.Success())));
+        _pipeline.ComputeRevisionHashAsync(5, Arg.Any<FlattenSession?>(), Arg.Any<CancellationToken>())
+            .Returns(Result<string>.Success("sha256:probe"));
        var probe = new StaleInstanceProbe(_pipeline);

        var hash = await probe.GetCurrentRevisionHashAsync(5);

        Assert.Equal("sha256:probe", hash);
-        await _pipeline.Received(1).FlattenAndValidateAsync(5, Arg.Any<CancellationToken>(), false, Arg.Any<FlattenSession?>());
+        await _pipeline.DidNotReceive().FlattenAndValidateAsync(
+            Arg.Any<int>(), Arg.Any<CancellationToken>(), Arg.Any<bool>(), Arg.Any<FlattenSession?>());
    }

    // ── Comparison must produce a structured diff ──