feat(audit)!: ScadaBridge C3 — swap to canonical ZB.MOM.WW.Audit.AuditEvent across seams/emitters/DTO/redactor wiring; transitional 24-col storage shim (Task 2.5)

tests/ZB.MOM.WW.ScadaBridge.Commons.Tests/Messages/Integration/CachedCallTelemetryTests.cs

@@ -1,6 +1,7 @@
-using ZB.MOM.WW.ScadaBridge.Commons.Entities.Audit;
+using ZB.MOM.WW.Audit;
 using ZB.MOM.WW.ScadaBridge.Commons.Messages.Integration;
 using ZB.MOM.WW.ScadaBridge.Commons.Types;
+using ZB.MOM.WW.ScadaBridge.Commons.Types.Audit;
 using ZB.MOM.WW.ScadaBridge.Commons.Types.Enums;
 
 namespace ZB.MOM.WW.ScadaBridge.Commons.Tests.Messages.Integration;
@@ -28,23 +29,23 @@ public class CachedCallTelemetryTests
         string? errorMessage = null,
         int? httpStatus = null)
     {
-        return new AuditEvent
-        {
-            EventId = Guid.NewGuid(),
-            OccurredAtUtc = FixedNowUtc,
-            Channel = AuditChannel.ApiOutbound,
-            Kind = kind,
-            CorrelationId = correlationId ?? trackedId.Value,
-            SourceSiteId = SiteId,
-            SourceInstanceId = InstanceName,
-            SourceScript = SourceScript,
-            Target = "ERP.GetOrder",
-            Status = status,
-            HttpStatus = httpStatus,
-            ErrorMessage = errorMessage,
-            PayloadTruncated = false,
-            ForwardState = AuditForwardState.Pending,
-        };
+        // C3 (Task 2.5): build the canonical ZB.MOM.WW.Audit.AuditEvent via the
+        // shared factory; the ScadaBridge domain fields ride in DetailsJson and
+        // are read back as typed properties via AsRow() in the assertions.
+        // ForwardState is no longer a packet field — it is a site-storage-only
+        // concern handled by the SQLite writer.
+        return ScadaBridgeAuditEventFactory.Create(
+            channel: AuditChannel.ApiOutbound,
+            kind: kind,
+            status: status,
+            occurredAtUtc: FixedNowUtc,
+            target: "ERP.GetOrder",
+            correlationId: correlationId ?? trackedId.Value,
+            sourceSiteId: SiteId,
+            sourceInstanceId: InstanceName,
+            sourceScript: SourceScript,
+            httpStatus: httpStatus,
+            errorMessage: errorMessage);
     }
 
     private static SiteCallOperational BuildOperational(
@@ -82,8 +83,8 @@ public class CachedCallTelemetryTests
 
         var packet = new CachedCallTelemetry(audit, operational);
 
-        Assert.Equal(AuditKind.CachedSubmit, packet.Audit.Kind);
-        Assert.Equal(AuditStatus.Submitted, packet.Audit.Status);
+        Assert.Equal(AuditKind.CachedSubmit, packet.Audit.AsRow().Kind);
+        Assert.Equal(AuditStatus.Submitted, packet.Audit.AsRow().Status);
         Assert.Equal(nameof(AuditStatus.Submitted), packet.Operational.Status);
         Assert.Equal(0, packet.Operational.RetryCount);
         Assert.Null(packet.Operational.TerminalAtUtc);
@@ -109,13 +110,13 @@ public class CachedCallTelemetryTests
 
         var packet = new CachedCallTelemetry(audit, operational);
 
-        Assert.Equal(AuditKind.ApiCallCached, packet.Audit.Kind);
-        Assert.Equal(AuditStatus.Attempted, packet.Audit.Status);
+        Assert.Equal(AuditKind.ApiCallCached, packet.Audit.AsRow().Kind);
+        Assert.Equal(AuditStatus.Attempted, packet.Audit.AsRow().Status);
         Assert.Equal(nameof(AuditStatus.Attempted), packet.Operational.Status);
         // Retry-count alignment: the operational row carries the canonical N;
         // the audit row's error/http surface the same attempt's outcome.
-        Assert.Equal(packet.Audit.ErrorMessage, packet.Operational.LastError);
-        Assert.Equal(packet.Audit.HttpStatus, packet.Operational.HttpStatus);
+        Assert.Equal(packet.Audit.AsRow().ErrorMessage, packet.Operational.LastError);
+        Assert.Equal(packet.Audit.AsRow().HttpStatus, packet.Operational.HttpStatus);
         Assert.Equal(2, packet.Operational.RetryCount);
         Assert.Null(packet.Operational.TerminalAtUtc);
     }
@@ -138,8 +139,8 @@ public class CachedCallTelemetryTests
 
         var packet = new CachedCallTelemetry(audit, operational);
 
-        Assert.Equal(AuditKind.DbWriteCached, packet.Audit.Kind);
-        Assert.Equal(AuditStatus.Attempted, packet.Audit.Status);
+        Assert.Equal(AuditKind.DbWriteCached, packet.Audit.AsRow().Kind);
+        Assert.Equal(AuditStatus.Attempted, packet.Audit.AsRow().Status);
         Assert.Equal(1, packet.Operational.RetryCount);
     }
 
@@ -161,8 +162,8 @@ public class CachedCallTelemetryTests
 
         var packet = new CachedCallTelemetry(audit, operational);
 
-        Assert.Equal(AuditKind.CachedResolve, packet.Audit.Kind);
-        Assert.Equal(terminalStatus, packet.Audit.Status);
+        Assert.Equal(AuditKind.CachedResolve, packet.Audit.AsRow().Kind);
+        Assert.Equal(terminalStatus, packet.Audit.AsRow().Status);
         Assert.Equal(terminalStatus.ToString(), packet.Operational.Status);
         Assert.NotNull(packet.Operational.TerminalAtUtc);
         Assert.Equal(terminalAt, packet.Operational.TerminalAtUtc);