test(communication)+test(sitecallaudit): cap parallelism, delta/collection-serialize gauge asserts, replace sleep-then-assert, stop leaked 100ms tickers (arch-review 2026-08-19 P8-5 + P8-6, register rows 40/82/95/96/102 patterns)

2026-08-19 15:03:03 -04:00
parent 9a3f006721
commit d9d72f1bc5
7 changed files with 422 additions and 227 deletions
@@ -11,6 +11,18 @@ namespace ZB.MOM.WW.ScadaBridge.Communication.Tests;
 /// relative to a baseline so the process-wide static instruments are robust to any
 /// parallel test interleaving.
 /// </summary>
+/// <remarks>
+/// Register row 102's shape: a fixed-baseline delta only survives contributors that hold
+/// constant or increase — a parallel class's actors moving the SAME process-global gauge
+/// and then STOPPING after this test captures its baseline makes <c>baseline + N</c>
+/// unreachable forever. <see cref="SiteAlarmAggregatorActor"/> calls
+/// <see cref="ScadaBridgeTelemetry.LiveAlarmAggregatorStarted"/>/
+/// <see cref="ScadaBridgeTelemetry.LiveAlarmAggregatorStopped"/> from its own
+/// PreStart/PostStop, so every actor <c>Grpc.SiteAlarmAggregatorActorTests</c> spins up
+/// moves this exact gauge — serialized into the same collection (row-96 pattern) so the
+/// two classes never interleave.
+/// </remarks>
+[Collection("SiteAlarmAggregatorGauge")]
 public class SiteAlarmLiveCacheTelemetryTests
 {
    private static long ReadGauge(string instrumentName)