fix(template-engine): DiffService covers native alarm sources — Deployments diff view no longer blind to native-alarm edits

Claude-Session: https://claude.ai/code/session_01MtdgwpEeCUn6cUA5f1LMPj
2026-07-09 16:42:00 -04:00
parent 0302694f9a
commit d833219920
3 changed files with 133 additions and 3 deletions
@@ -221,6 +221,114 @@ public class DiffServiceTests
        Assert.Equal(DiffChangeType.Changed, diff.AlarmChanges[0].ChangeType);
    }

+    [Fact]
+    public void ComputeDiff_NativeAlarmSourceReferenceChange_DetectedAsChanged()
+    {
+        // PLAN-05 Task 12: native alarm source edits must surface in the diff so
+        // the Deployments diff view is not blind to native-alarm binding changes.
+        var oldConfig = new FlattenedConfiguration
+        {
+            InstanceUniqueName = "Instance1",
+            NativeAlarmSources =
+            [
+                new ResolvedNativeAlarmSource { CanonicalName = "PumpAlarms", ConnectionName = "Opc1", SourceReference = "ns=2;s=PumpA" }
+            ]
+        };
+        var newConfig = new FlattenedConfiguration
+        {
+            InstanceUniqueName = "Instance1",
+            NativeAlarmSources =
+            [
+                new ResolvedNativeAlarmSource { CanonicalName = "PumpAlarms", ConnectionName = "Opc1", SourceReference = "ns=2;s=PumpB" }
+            ]
+        };
+
+        var diff = _sut.ComputeDiff(oldConfig, newConfig);
+
+        Assert.True(diff.HasChanges);
+        Assert.Single(diff.NativeAlarmSourceChanges);
+        Assert.Equal(DiffChangeType.Changed, diff.NativeAlarmSourceChanges[0].ChangeType);
+        Assert.Equal("PumpAlarms", diff.NativeAlarmSourceChanges[0].CanonicalName);
+    }
+
+    [Fact]
+    public void ComputeDiff_NativeAlarmSourceAdded_DetectedAsAdded()
+    {
+        var oldConfig = new FlattenedConfiguration { InstanceUniqueName = "Instance1" };
+        var newConfig = new FlattenedConfiguration
+        {
+            InstanceUniqueName = "Instance1",
+            NativeAlarmSources =
+            [
+                new ResolvedNativeAlarmSource { CanonicalName = "PumpAlarms", ConnectionName = "Opc1", SourceReference = "ns=2;s=PumpA" }
+            ]
+        };
+
+        var diff = _sut.ComputeDiff(oldConfig, newConfig);
+
+        Assert.True(diff.HasChanges);
+        Assert.Single(diff.NativeAlarmSourceChanges);
+        Assert.Equal(DiffChangeType.Added, diff.NativeAlarmSourceChanges[0].ChangeType);
+    }
+
+    [Fact]
+    public void ComputeDiff_NativeAlarmSourceRemoved_DetectedAsRemoved()
+    {
+        var oldConfig = new FlattenedConfiguration
+        {
+            InstanceUniqueName = "Instance1",
+            NativeAlarmSources =
+            [
+                new ResolvedNativeAlarmSource { CanonicalName = "PumpAlarms", ConnectionName = "Opc1", SourceReference = "ns=2;s=PumpA" }
+            ]
+        };
+        var newConfig = new FlattenedConfiguration { InstanceUniqueName = "Instance1" };
+
+        var diff = _sut.ComputeDiff(oldConfig, newConfig);
+
+        Assert.True(diff.HasChanges);
+        Assert.Single(diff.NativeAlarmSourceChanges);
+        Assert.Equal(DiffChangeType.Removed, diff.NativeAlarmSourceChanges[0].ChangeType);
+    }
+
+    [Fact]
+    public void ComputeDiff_NativeAlarmSourceLockChange_DetectedAsChanged()
+    {
+        var oldConfig = new FlattenedConfiguration
+        {
+            InstanceUniqueName = "Instance1",
+            NativeAlarmSources =
+            [
+                new ResolvedNativeAlarmSource { CanonicalName = "PumpAlarms", ConnectionName = "Opc1", SourceReference = "ns=2;s=PumpA", IsLocked = false }
+            ]
+        };
+        var newConfig = new FlattenedConfiguration
+        {
+            InstanceUniqueName = "Instance1",
+            NativeAlarmSources =
+            [
+                new ResolvedNativeAlarmSource { CanonicalName = "PumpAlarms", ConnectionName = "Opc1", SourceReference = "ns=2;s=PumpA", IsLocked = true }
+            ]
+        };
+
+        var diff = _sut.ComputeDiff(oldConfig, newConfig);
+
+        Assert.Single(diff.NativeAlarmSourceChanges);
+        Assert.Equal(DiffChangeType.Changed, diff.NativeAlarmSourceChanges[0].ChangeType);
+    }
+
+    [Fact]
+    public void ComputeDiff_NativeAlarmSourceUnchanged_NoDiff()
+    {
+        var source = new ResolvedNativeAlarmSource { CanonicalName = "PumpAlarms", ConnectionName = "Opc1", SourceReference = "ns=2;s=PumpA", ConditionFilter = "HighHigh" };
+        var oldConfig = new FlattenedConfiguration { InstanceUniqueName = "Instance1", NativeAlarmSources = [source] };
+        var newConfig = new FlattenedConfiguration { InstanceUniqueName = "Instance1", NativeAlarmSources = [source with { }] };
+
+        var diff = _sut.ComputeDiff(oldConfig, newConfig);
+
+        Assert.Empty(diff.NativeAlarmSourceChanges);
+    }
+
    [Fact]
    public void ConnectionsEqual_IdenticalConfigs_ReturnsTrue()
    {